submodules: update clippy from 164310dd to 49ff0d9d #62861

matthiaskrgr · 2019-07-22T01:16:33Z

Changes:

Fix breakage due to rust-lang/rust#60913
Fix breakage due to rust-lang/rust#62705
rustup https://github.com/rust-lang/rust/pull/62679/
Update pulldown-cmark to 0.5.3
rustup https://github.com/rust-lang/rust/pull/62764
Format code
Decrease maximum length for stderr files
Improved imports
Fix "unknown clippy lint" error in UI test.
Corrections for PR review.
Implement lint for inherent to_string() method.
UI Test Cleanup: Extract match_ref_pats tests
Update UI tests
Allow no_effect lint
Remove comment
cargo fmt
UI Test Cleanup: Split up checked_unwrap tests
Removed linting on never type.
UI Test Cleanup: Split out out_of_bounds_indexing
false positives fixes of `implicit_return`

Fixes clippy toolstate
r? @oli-obk

Changes: ```` Fix breakage due to rust-lang#60913 Fix breakage due to rust-lang#62705 rustup rust-lang#62679 Update pulldown-cmark to 0.5.3 rustup rust-lang#62764 Format code Decrease maximum length for stderr files Improved imports Fix "unkown clippy lint" error in UI test. Corrections for PR review. Implement lint for inherent to_string() method. UI Test Cleanup: Extract match_ref_pats tests Update UI tests Allow no_effect lint Remove comment cargo fmt UI Test Cleanup: Split up checked_unwrap tests Removed lintining on never type. UI Test Cleanup: Split out out_of_bounds_indexing false positives fixes of `implicit_return` ````

rust-highfive · 2019-07-22T01:16:44Z

⚠️ Warning ⚠️

These commits modify submodules.

rust-highfive · 2019-07-22T03:42:52Z

The job LinuxTools of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-07-22T01:17:03.6381279Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-22T01:17:03.6563527Z ##[command]git config gc.auto 0
2019-07-22T01:17:03.6651477Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-22T01:17:03.6714272Z ##[command]git config --get-all http.proxy
2019-07-22T01:17:03.6855945Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62861/merge:refs/remotes/pull/62861/merge
---
2019-07-22T01:17:36.9941694Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-22T01:17:36.9941886Z 
2019-07-22T01:17:36.9942103Z   git checkout -b <new-branch-name>
2019-07-22T01:17:36.9942130Z 
2019-07-22T01:17:36.9942174Z HEAD is now at a8c499b7f Merge c5810baacf2c6e1d8cf64b94ab18484c44b6ce3f into 273f42b5964c29dda2c5a349dd4655529767b07f
2019-07-22T01:17:37.0086459Z ##[section]Finishing: Checkout
2019-07-22T01:17:37.0093041Z ##[section]Starting: Decide whether to run this job
2019-07-22T01:17:37.0096516Z Task         : Bash
2019-07-22T01:17:37.0096563Z Description  : Run a Bash script on macOS, Linux, or Windows
2019-07-22T01:17:37.0096609Z Version      : 3.151.2
2019-07-22T01:17:37.0096671Z Author       : Microsoft Corporation
2019-07-22T01:17:37.0096671Z Author       : Microsoft Corporation
2019-07-22T01:17:37.0096721Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
2019-07-22T01:17:37.0096771Z ==============================================================================
2019-07-22T01:17:37.1572146Z Generating script.
2019-07-22T01:17:37.1607632Z ========================== Starting Command Output ===========================
2019-07-22T01:17:37.1624667Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/d2d9a217-e8af-44a9-b387-a76286e8e737.sh
2019-07-22T01:17:37.5940751Z Executing the job since submodules are updated
2019-07-22T01:17:37.6062104Z ##[section]Finishing: Decide whether to run this job
2019-07-22T01:17:37.6074046Z ==============================================================================
2019-07-22T01:17:37.6074109Z Task         : Bash
2019-07-22T01:17:37.6074155Z Description  : Run a Bash script on macOS, Linux, or Windows
2019-07-22T01:17:37.6074241Z Version      : 3.151.2
---
2019-07-22T03:42:20.0583822Z The state of "clippy-driver" has changed from "build-fail" to "test-pass"
2019-07-22T03:42:20.0584247Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-22T03:42:20.0838714Z [master fa6115d] (linux CI update)
2019-07-22T03:42:20.0838807Z  1 file changed, 1 insertion(+)
2019-07-22T03:42:20.7915696Z remote: Invalid username or password.
2019-07-22T03:42:20.7916663Z fatal: Authentication failed for 'https://github.com/rust-lang-nursery/rust-toolstate.git/'
2019-07-22T03:42:24.1612810Z  * branch            master     -> FETCH_HEAD
2019-07-22T03:42:24.1784930Z HEAD is now at 854a323 (windows CI update)
2019-07-22T03:42:24.1900841Z The state of "clippy-driver" has changed from "build-fail" to "test-pass"
2019-07-22T03:42:24.1902764Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-22T03:42:24.1902764Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-22T03:42:24.2081791Z [master 1788851] (linux CI update)
2019-07-22T03:42:24.2081864Z  1 file changed, 1 insertion(+)
2019-07-22T03:42:24.5378504Z fatal: could not read Username for 'https://github.com': No such device or address
2019-07-22T03:42:24.8885625Z  * branch            master     -> FETCH_HEAD
2019-07-22T03:42:24.9042935Z HEAD is now at 854a323 (windows CI update)
2019-07-22T03:42:24.9156432Z The state of "clippy-driver" has changed from "build-fail" to "test-pass"
2019-07-22T03:42:24.9157212Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-22T03:42:24.9157212Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-22T03:42:24.9343465Z [master 1788851] (linux CI update)
2019-07-22T03:42:24.9343588Z  1 file changed, 1 insertion(+)
2019-07-22T03:42:25.2497763Z fatal: could not read Username for 'https://github.com': No such device or address
2019-07-22T03:42:27.5928025Z  * branch            master     -> FETCH_HEAD
2019-07-22T03:42:27.6107641Z HEAD is now at 854a323 (windows CI update)
2019-07-22T03:42:27.6223012Z The state of "clippy-driver" has changed from "build-fail" to "test-pass"
2019-07-22T03:42:27.6223306Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-22T03:42:27.6223306Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-22T03:42:27.6403871Z [master cb29f52] (linux CI update)
2019-07-22T03:42:27.6405937Z  1 file changed, 1 insertion(+)
2019-07-22T03:42:27.9630229Z fatal: could not read Username for 'https://github.com': No such device or address
2019-07-22T03:42:28.3120106Z  * branch            master     -> FETCH_HEAD
2019-07-22T03:42:28.3276824Z HEAD is now at 854a323 (windows CI update)
2019-07-22T03:42:28.3397943Z The state of "clippy-driver" has changed from "build-fail" to "test-pass"
2019-07-22T03:42:28.3398839Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-22T03:42:28.3398839Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-22T03:42:28.3585257Z [master d1b78c4] (linux CI update)
2019-07-22T03:42:28.3585332Z  1 file changed, 1 insertion(+)
2019-07-22T03:42:28.6827189Z fatal: could not read Username for 'https://github.com': No such device or address
2019-07-22T03:42:30.0367660Z  * branch            master     -> FETCH_HEAD
2019-07-22T03:42:30.0525909Z HEAD is now at 854a323 (windows CI update)
2019-07-22T03:42:30.0525909Z HEAD is now at 854a323 (windows CI update)
2019-07-22T03:42:31.1529107Z ##[error]Bash exited with code '1'.
2019-07-22T03:42:31.1573156Z ##[section]Starting: Checkout
2019-07-22T03:42:31.1575677Z ==============================================================================
2019-07-22T03:42:31.1575747Z Task         : Get sources
2019-07-22T03:42:31.1575792Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2019-07-22T06:13:27Z

@bors r+ p=1

bors · 2019-07-22T06:13:28Z

📌 Commit c5810ba has been approved by oli-obk

bors · 2019-07-22T06:13:29Z

🌲 The tree is currently closed for pull requests below priority 1500, this pull request will be tested once the tree is reopened

bors · 2019-07-23T09:52:15Z

⌛ Testing commit c5810ba with merge f4b76dbcfca31f2d03b3ca2d4de7cae4b9fd65e9...

rust-highfive · 2019-07-23T09:58:30Z

Your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-07-23T09:56:42.9925790Z Script contents:
2019-07-23T09:56:42.9926624Z aws s3 cp --acl public-read cpu-usage.csv s3://$DEPLOY_BUCKET/rustc-builds/$BUILD_SOURCEVERSION/cpu-$SYSTEM_JOBNAME.csv
2019-07-23T09:56:42.9953455Z ========================== Starting Command Output ===========================
2019-07-23T09:56:42.9991604Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/cdd4786c-c6ea-44c5-8271-21cd1b36867d.sh
2019-07-23T09:56:43.0100554Z /home/vsts/work/_temp/cdd4786c-c6ea-44c5-8271-21cd1b36867d.sh: line 1: aws: command not found
2019-07-23T09:56:43.0140206Z ##[error]Bash exited with code '127'.
2019-07-23T09:56:43.0175043Z ##[section]Starting: Checkout
2019-07-23T09:56:43.0176916Z ==============================================================================
2019-07-23T09:56:43.0177021Z Task         : Get sources
2019-07-23T09:56:43.0177101Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-07-23T09:58:43Z

💔 Test failed - checks-azure

pietroalbini · 2019-07-23T10:37:21Z

@bors retry

A VM lost network access apparently?

matthiaskrgr · 2019-07-24T01:02:49Z

Status: this needs rust-lang/rust-clippy#4297 to be included in this pr to work.
I also want to wait out the current rollup in case it breaks clippy again, will check back in the morning.

bors · 2019-07-24T13:51:33Z

⌛ Testing commit c5810ba with merge a893c3a66a5b035be666b0355bf0d8be8e122395...

bors · 2019-07-24T15:58:55Z

💔 Test failed - checks-azure

rust-highfive · 2019-07-24T15:58:56Z

The job x86_64-gnu-tools of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-07-24T15:34:10.7062232Z    Compiling cargo_metadata v0.8.0
2019-07-24T15:34:16.7122479Z [RUSTC-TIMING] toml test:false 17.872
2019-07-24T15:34:32.9154256Z [RUSTC-TIMING] cargo_metadata test:false 22.203
2019-07-24T15:34:32.9200385Z    Compiling clippy_lints v0.0.212 (/checkout/src/tools/clippy/clippy_lints)
2019-07-24T15:34:39.4247780Z error[E0599]: no method named `as_place_ref` found for type `&rustc::mir::Place<'tcx>` in the current scope
2019-07-24T15:34:39.4266122Z     |
2019-07-24T15:34:39.4266122Z     |
2019-07-24T15:34:39.4273068Z 296 |     } = place.as_place_ref();
2019-07-24T15:34:39.4284359Z 
2019-07-24T15:34:39.7678368Z [RUSTC-TIMING] cargo_metadata test:false 23.050
2019-07-24T15:34:40.0541407Z error: aborting due to previous error
2019-07-24T15:34:40.0541533Z 
2019-07-24T15:34:40.0541533Z 
2019-07-24T15:34:40.0577903Z For more information about this error, try `rustc --explain E0599`.
2019-07-24T15:34:40.1238788Z [RUSTC-TIMING] clippy_lints test:false 7.198
2019-07-24T15:34:40.1260968Z error: Could not compile `clippy_lints`.
2019-07-24T15:34:40.1272775Z warning: build failed, waiting for other jobs to finish...
2019-07-24T15:34:46.1533684Z error[E0599]: no method named `as_place_ref` found for type `&rustc::mir::Place<'tcx>` in the current scope
2019-07-24T15:34:46.1535195Z     |
2019-07-24T15:34:46.1535195Z     |
2019-07-24T15:34:46.1535648Z 296 |     } = place.as_place_ref();
2019-07-24T15:34:46.1536568Z 
2019-07-24T15:34:46.7614066Z error: aborting due to previous error
2019-07-24T15:34:46.7614175Z 
2019-07-24T15:34:46.7614457Z For more information about this error, try `rustc --explain E0599`.
---
2019-07-24T15:56:50.1345664Z Verifying status of rustfmt...
2019-07-24T15:56:50.1356836Z Verifying status of clippy-driver...
2019-07-24T15:56:50.1385156Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-07-24T15:56:50.1385277Z 
2019-07-24T15:56:50.1385619Z ⚠️ We detected that this PR updated 'clippy-driver', but its tests failed.
2019-07-24T15:56:50.1385675Z 
2019-07-24T15:56:50.1385960Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-07-24T15:56:50.1386038Z commit another update.
2019-07-24T15:56:50.1386073Z 
2019-07-24T15:56:50.1386340Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-07-24T15:56:50.1386597Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-07-24T15:56:50.1386685Z proper steps.
2019-07-24T15:56:51.1519684Z ##[error]Bash exited with code '3'.
2019-07-24T15:56:51.1554147Z ##[section]Starting: Upload CPU usage statistics
2019-07-24T15:56:51.1563242Z ==============================================================================
2019-07-24T15:56:51.1563340Z Task         : Bash
2019-07-24T15:56:51.1563431Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

matthiaskrgr · 2019-07-24T17:23:14Z

updated

matthiaskrgr · 2019-07-24T17:24:02Z

Oops, I can't reopen apparently, I'll make a new pr....

rust-highfive assigned oli-obk Jul 22, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 23, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 24, 2019

matthiaskrgr closed this Jul 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

submodules: update clippy from 164310dd to 49ff0d9d #62861

submodules: update clippy from 164310dd to 49ff0d9d #62861

matthiaskrgr commented Jul 22, 2019

rust-highfive commented Jul 22, 2019

rust-highfive commented Jul 22, 2019

oli-obk commented Jul 22, 2019

bors commented Jul 22, 2019

bors commented Jul 22, 2019

bors commented Jul 23, 2019

rust-highfive commented Jul 23, 2019

bors commented Jul 23, 2019

pietroalbini commented Jul 23, 2019

matthiaskrgr commented Jul 24, 2019

bors commented Jul 24, 2019

bors commented Jul 24, 2019

rust-highfive commented Jul 24, 2019

matthiaskrgr commented Jul 24, 2019 •

edited

Loading

matthiaskrgr commented Jul 24, 2019

submodules: update clippy from 164310dd to 49ff0d9d #62861

submodules: update clippy from 164310dd to 49ff0d9d #62861

Conversation

matthiaskrgr commented Jul 22, 2019

rust-highfive commented Jul 22, 2019

rust-highfive commented Jul 22, 2019

oli-obk commented Jul 22, 2019

bors commented Jul 22, 2019

bors commented Jul 22, 2019

bors commented Jul 23, 2019

rust-highfive commented Jul 23, 2019

bors commented Jul 23, 2019

pietroalbini commented Jul 23, 2019

matthiaskrgr commented Jul 24, 2019

bors commented Jul 24, 2019

bors commented Jul 24, 2019

rust-highfive commented Jul 24, 2019

matthiaskrgr commented Jul 24, 2019 • edited Loading

matthiaskrgr commented Jul 24, 2019

matthiaskrgr commented Jul 24, 2019 •

edited

Loading