Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rustfmt and RLS #63235

Merged
merged 1 commit into from
Aug 4, 2019
Merged

Update Rustfmt and RLS #63235

merged 1 commit into from
Aug 4, 2019

Conversation

Xanewok
Copy link
Member

@Xanewok Xanewok commented Aug 3, 2019

Closes #63195

cc @topecongiro

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2019
@Xanewok
Copy link
Member Author

Xanewok commented Aug 3, 2019

@bors p=1 since this fixes broken tools

@Xanewok
Copy link
Member Author

Xanewok commented Aug 3, 2019

Niko is away from what I know and since this fixes breakage introduced by #62293...

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned nikomatsakis Aug 3, 2019
@Centril
Copy link
Contributor

Centril commented Aug 3, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Aug 3, 2019

📌 Commit 5bcce82 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2019
@bors
Copy link
Contributor

bors commented Aug 3, 2019

⌛ Testing commit 5bcce82 with merge 1709976...

bors added a commit that referenced this pull request Aug 3, 2019
@bors
Auto merge of #63235 - Xanewok:update-rls, r=Centril
1709976 
Update Rustfmt and RLS

Closes #63195

cc @topecongiro
@bors
Copy link
Contributor

bors commented Aug 4, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 1709976 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 4, 2019
@bors bors merged commit 5bcce82 into rust-lang:master Aug 4, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #63235!

Tested on commit 1709976.
Direct link to PR: #63235

🎉 rls on windows: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rustfmt on windows: build-fail → test-pass (cc @topecongiro, @rust-lang/infra).
🎉 rustfmt on linux: build-fail → test-pass (cc @topecongiro, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 4, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#63235!
8eac612 
Tested on commit rust-lang/rust@1709976.
Direct link to PR: <rust-lang/rust#63235>

🎉 rls on windows: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rustfmt on windows: build-fail → test-pass (cc @topecongiro, @rust-lang/infra).
🎉 rustfmt on linux: build-fail → test-pass (cc @topecongiro, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rls no longer builds after rust-lang/rust#62507
5 participants
@Xanewok @rust-highfive @Centril @bors @nikomatsakis