Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#62507 #63195

Closed
rust-highfive opened this issue Aug 1, 2019 · 2 comments · Fixed by #63235
Closed

rls no longer builds after rust-lang/rust#62507 #63195

rust-highfive opened this issue Aug 1, 2019 · 2 comments · Fixed by #63235
Assignees
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #62507, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @petrochenkov, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @alexcrichton, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 1, 2019
@phil-opp
Copy link
Contributor

phil-opp commented Aug 2, 2019

This affects rustfmt too: https://rust-lang.github.io/rustup-components-history/

@Xanewok
Copy link
Member

Xanewok commented Aug 2, 2019

Happened because of

2019-08-01T13:23:36.8982444Z �[0m�[0m�[1m�[32m   Compiling�[0m rustc-ap-rustc_data_structures v542.0.0
2019-08-01T13:23:37.0454949Z �[0m�[1m�[38;5;9merror[E0658]�[0m�[0m�[1m: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable�[0m
2019-08-01T13:23:37.0456824Z �[0m    �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_data_structures-542.0.0/bit_set.rs:1269:3�[0m

in https://dev.azure.com/rust-lang/rust/_build/results?buildId=4891.

IIUC this will need a coordinated upgrade to rustc-ap-* once again
@topecongiro @kngwyu

blame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants