Improve invalid_value lint message #63483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
RalfJung
commented
Aug 12, 2019
Centril
reviewed
Aug 12, 2019
|
r? @Centril r=me when-green + squashed :) |
RalfJung
force-pushed
the
invalid-value
branch
from
b34d0c7
to
0499923
Compare
|
The corresponding pipeline is long done but GH doesn't show it as green... strange. @bors r=Centril |
|
📌 Commit 0499923 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 Improving a new lint for the beta. |
bors
added a commit
that referenced
this pull request
Aug 12, 2019
Improve invalid_value lint message The lint now explains which type is involved and why it cannot be initialized this way. It also points at the innermost struct/enum field that has an offending type, if any. See AltF02/x11-rs#99 (comment) for how this helps in some real-world code hitting this lint.
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint now explains which type is involved and why it cannot be initialized this way. It also points at the innermost struct/enum field that has an offending type, if any.
See AltF02/x11-rs#99 (comment) for how this helps in some real-world code hitting this lint.