Rollup of 6 pull requests #63790
Merged
Rollup of 6 pull requests #63790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solve the problem of `ParentScope` entries for eager expansions not exising in the resolver map by creating them on demand.
…ng an expression Maybe it made sense when it was introduced, but now it's doing something incorrect.
…-Simulacrum take into account the system theme Fixes rust-lang#61079. The CSS can now take into account the system theme. I used it to generate some content on the document and from there, if no theme has already been selected, it'll look at the system level theme. r? @QuietMisdreavus cc @fenhl
Fix nested eager expansions in arguments of `format_args` Fixes rust-lang#63460 Fixes rust-lang#63685 (regression from making `format_args` opaque - rust-lang#63114) r? @matthewjasper
update Miri Fixes rust-lang#63673 r? @oli-obk
…ichton ci: move libc mirrors to the rust-lang-ci-mirrors bucket Finishing up rust-lang#63485. Already moved the objects. r? @alexcrichton
Improve diagnostics: break/continue in wrong context - Fix rust-lang#63712 - Use `` `break` `` or `` `continue` `` instead of always `break` in `cannot _...` - Show the enclosing closure or async block we're talking about - `` `break` outside of loop `` -> `` `break` outside of a loop `` for consistency r? @estebank
Run Clippy without json-rendered flag Removed in rust-lang#62766 Replacing it with `--json=diagnostic-rendered-ansi` fails: ``` error: using `--json` requires also using `--error-format=json` ``` Running `./x.py clippy src/libstd` locally works fine (with colors) on Linux so I don't know if there is something to fix.
|
@bors r+ p=6 rollup=never |
|
📌 Commit 1294774 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 21, 2019
Rollup of 6 pull requests Successful merges: - #61236 (take into account the system theme) - #63717 (Fix nested eager expansions in arguments of `format_args`) - #63747 (update Miri) - #63772 (ci: move libc mirrors to the rust-lang-ci-mirrors bucket) - #63780 (Improve diagnostics: break/continue in wrong context) - #63781 (Run Clippy without json-rendered flag) Failed merges: r? @ghost
|
☀️ Test successful - checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Aug 21, 2019
Tested on commit rust-lang/rust@e44fdf9. Direct link to PR: <rust-lang/rust#63790> 🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra). 🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
format_args#63717 (Fix nested eager expansions in arguments offormat_args)Failed merges:
r? @ghost