pprust: Do not print spaces before some tokens #63897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
estebank
approved these changes
Aug 25, 2019
|
r=me if you don't want to wait for @Mark-Simulacrum to see this. |
|
@bors r=estebank |
|
📌 Commit 5b7df09 has been approved by |
bors
added
S-waiting-on-bors
|
r? @estebank |
bors
added a commit
that referenced
this pull request
Aug 26, 2019
pprust: Do not print spaces before some tokens Fixes #63896 r? @Mark-Simulacrum
|
☀️ Test successful - checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Aug 26, 2019
Tested on commit rust-lang/rust@9fa8f14. Direct link to PR: <rust-lang/rust#63897> 💔 rustc-guide on linux: test-pass → test-fail (cc @mark-i-m @spastorino @amanjeev, @rust-lang/infra).
petrochenkov
added
the
beta-nominated
pietroalbini
added
the
T-compiler
Centril
added
I-nominated
T-lang
|
Nominating for the language team as a proxy for the more general issue of pretty printing stability. |
|
discussed at T-compiler meeting. approved for beta-backport. (The T-lang tagging, AFAICT, is not part of the beta-backport nomination.) |
pnkfelix
added
the
beta-accepted
bors
added a commit
that referenced
this pull request
Sep 14, 2019
[beta] Rollup backports Cherry-picked: - Permit unwinding through FFI by default #62603 - pprust: Do not print spaces before some tokens #63897 - Account for doc comments coming from proc macros without spans #63930 - Support "soft" feature-gating using a lint #64066 - Update xLTO compatibility table in rustc book. #64092 - Include compiler-rt in the source tarball #64240 - Update LLVM submodule #64317 r? @Mark-Simulacrum
cuviper
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63896
r? @Mark-Simulacrum