Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure interned constants are immutable #63955

Merged
merged 8 commits into from
Sep 16, 2019
Merged

Make sure interned constants are immutable #63955

merged 8 commits into from
Sep 16, 2019

Commits on Sep 15, 2019

  1. const interning: move mutability computation into intern_shallow, and… 

    … always intern constants as immutable
    @RalfJung
    RalfJung committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    6137691 View commit details
    Browse the repository at this point in the history

  2. all memory behind a constant must be immutable

    @RalfJung
    RalfJung committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    7b8693e View commit details
    Browse the repository at this point in the history

  3. drop redundant ParamEnv, and avoid constructing InternVisitor without… 

    … visiting
    @RalfJung
    RalfJung committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    75c82b4 View commit details
    Browse the repository at this point in the history

  4. relocations -> allocations

    @RalfJung
    RalfJung committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    b1d4d2b View commit details
    Browse the repository at this point in the history

  5. note a FIXME

    @RalfJung
    RalfJung committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    14e3506 View commit details
    Browse the repository at this point in the history

  6. assert that nobody asks for mutable constants

    @RalfJung
    RalfJung committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    3424811 View commit details
    Browse the repository at this point in the history

  7. explain ty == None

    @RalfJung
    RalfJung committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    224e2e5 View commit details
    Browse the repository at this point in the history

  8. update intern classification comment

    @RalfJung
    RalfJung committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    5462ecb View commit details
    Browse the repository at this point in the history