Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline Compiler #64016

Merged
merged 4 commits into from
Sep 25, 2019
Merged

Streamline Compiler #64016

merged 4 commits into from
Sep 25, 2019

Commits on Sep 1, 2019

  1. Configuration menu
    Copy the full SHA
    d61605c View commit details
    Browse the repository at this point in the history
  2. Remove lower_to_hir() call from prepare_output().

    It's a false dependency. The result isn't used and there are no
    relevant side-effects.
    nnethercote committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    cd0c21b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. Move call site of dep_graph_future().

    `Compiler::register_plugins()` calls `passes::register_plugins()`, which
    calls `Compiler::dep_graph_future()`. This is the only way in which a
    `passes` function calls a `Compiler` function.
    
    This commit moves the `dep_graph_future()` call out of
    `passes::register_plugins()` and into `Compiler::register_plugins()`,
    which is a more sensible spot for it. This will delay the loading of the
    dep graph slightly -- from the middle of plugin registration to the end
    of plugin registration -- but plugin registration is fast enough
    (especially compared to expansion) that the impact should be neglible.
    nnethercote committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    d264a56 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. Add a comment to Compiler::compile().

    `Compiler::compile()` is different to all the other `Compiler` methods
    because it lacks a `Queries` entry. It only has one call site, which is
    in a test that doesn't need its specific characteristics.
    
    This patch replaces that call with a call to `Compile::link()`, which is
    similar enough for the test's purposes. It also notes that the method is
    an illustrative example of how `Compiler` can be used.
    nnethercote committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    2521189 View commit details
    Browse the repository at this point in the history