Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move path parsing earlier #64120

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@nnethercote
Copy link
Contributor

commented Sep 3, 2019

It's a hot enough path that moving it slightly earlier gives a tiny but easy speedup.

r? @petrochenkov

Move path parsing earlier.
It's a hot enough path that moving it slightly earlier gives a tiny but
easy speedup.
@nnethercote

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

⌛️ Trying commit 8c74eb7 with merge d6f850c...

bors added a commit that referenced this pull request Sep 3, 2019
Auto merge of #64120 - nnethercote:move-path-parsing-earlier, r=<try>
Move path parsing earlier

It's a hot enough path that moving it slightly earlier gives a tiny but easy speedup.

r? @petrochenkov
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

☀️ Try build successful - checks-azure
Build commit: d6f850c

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@rust-timer

This comment has been minimized.

Copy link

commented Sep 3, 2019

Success: Queued d6f850c with parent 815dec9, comparison URL.

@rust-timer

This comment has been minimized.

Copy link

commented Sep 3, 2019

Finished benchmarking try commit d6f850c, comparison URL.

@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@nnethercote
r=me if you like the perf results

@nnethercote

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

The improvements are tiny but clear.

@bors r=petrochenkov

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

📌 Commit 8c74eb7 has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Sep 4, 2019
Rollup merge of rust-lang#64120 - nnethercote:move-path-parsing-earli…
…er, r=petrochenkov

Move path parsing earlier

It's a hot enough path that moving it slightly earlier gives a tiny but easy speedup.

r? @petrochenkov
bors added a commit that referenced this pull request Sep 4, 2019
Auto merge of #64137 - Centril:rollup-4am55q3, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #63166 (Add Result::cloned{,_err} and Result::copied{,_err})
 - #63930 (Account for doc comments coming from proc macros without spans)
 - #63985 (Stabilize pin_into_inner in 1.39.0)
 - #64023 (libstd fuchsia fixes)
 - #64030 (Fix unlock ordering in SGX synchronization primitives)
 - #64041 (use TokenStream rather than &[TokenTree] for built-in macros)
 - #64043 (Add some more tests for underscore imports)
 - #64092 (Update xLTO compatibility table in rustc book.)
 - #64120 (Move path parsing earlier)
 - #64123 (Added warning around code with reference to uninit bytes)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Sep 4, 2019
Auto merge of #64137 - Centril:rollup-4am55q3, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #63166 (Add Result::cloned{,_err} and Result::copied{,_err})
 - #63930 (Account for doc comments coming from proc macros without spans)
 - #63985 (Stabilize pin_into_inner in 1.39.0)
 - #64023 (libstd fuchsia fixes)
 - #64030 (Fix unlock ordering in SGX synchronization primitives)
 - #64041 (use TokenStream rather than &[TokenTree] for built-in macros)
 - #64043 (Add some more tests for underscore imports)
 - #64092 (Update xLTO compatibility table in rustc book.)
 - #64120 (Move path parsing earlier)
 - #64123 (Added warning around code with reference to uninit bytes)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
Rollup merge of rust-lang#64120 - nnethercote:move-path-parsing-earli…
…er, r=petrochenkov

Move path parsing earlier

It's a hot enough path that moving it slightly earlier gives a tiny but easy speedup.

r? @petrochenkov
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
Rollup merge of rust-lang#64120 - nnethercote:move-path-parsing-earli…
…er, r=petrochenkov

Move path parsing earlier

It's a hot enough path that moving it slightly earlier gives a tiny but easy speedup.

r? @petrochenkov
bors added a commit that referenced this pull request Sep 5, 2019
Auto merge of #64160 - Centril:rollup-vrfj1pt, r=Centril
Rollup of 15 pull requests

Successful merges:

 - #62860 (Stabilize checked_duration_since for 1.38.0)
 - #63549 (Rev::rposition counts from the wrong end)
 - #63985 (Stabilize pin_into_inner in 1.39.0)
 - #64005 (Add a `Place::is_indirect` method to determine whether a `Place` contains a `Deref` projection)
 - #64031 (Harden `param_attrs` test wrt. usage of a proc macro `#[attr]`)
 - #64038 (Check impl trait substs when checking for recursive types)
 - #64043 (Add some more tests for underscore imports)
 - #64092 (Update xLTO compatibility table in rustc book.)
 - #64110 (Refer to "`self` type" instead of "receiver type")
 - #64120 (Move path parsing earlier)
 - #64123 (Added warning around code with reference to uninit bytes)
 - #64128 (unused_parens: account for or-patterns and `&(mut x)`)
 - #64141 (Minimize uses of `LocalInternedString`)
 - #64142 (Fix doc links in `std::cmp` module)
 - #64148 (fix a few typos in comments)

Failed merges:

r? @ghost

@bors bors merged commit 8c74eb7 into rust-lang:master Sep 5, 2019

5 checks passed

homu Test successful
Details
pr Build #20190903.20 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details

@nnethercote nnethercote deleted the nnethercote:move-path-parsing-earlier branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.