Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix miri #64211

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Fix miri #64211

merged 1 commit into from
Sep 6, 2019

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 6, 2019

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2019
@eddyb
Copy link
Member

eddyb commented Sep 6, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Sep 6, 2019

📌 Commit 39bfb36 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2019
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 6, 2019

@bors p=1

@bors
Copy link
Contributor

bors commented Sep 6, 2019

⌛ Testing commit 39bfb36 with merge 4894123...

bors added a commit that referenced this pull request Sep 6, 2019
@bors
Auto merge of #64211 - oli-obk:miri, r=eddyb
4894123 
Fix miri

fixes  #64109

cc @HeroicKatora
cc @RalfJung
@bors
Copy link
Contributor

bors commented Sep 6, 2019

☀️ Test successful - checks-azure
Approved by: eddyb
Pushing 4894123 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 6, 2019
@bors bors merged commit 39bfb36 into rust-lang:master Sep 6, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #64211!

Tested on commit 4894123.
Direct link to PR: #64211

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 6, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#64211!
19696a6 
Tested on commit rust-lang/rust@4894123.
Direct link to PR: <rust-lang/rust#64211>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
@RalfJung
Copy link
Member

RalfJung commented Sep 8, 2019 via email

@oli-obk oli-obk deleted the miri branch September 8, 2019 10:13
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 8, 2019

I opened rust-lang/miri#942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#63561
5 participants
@oli-obk @rust-highfive @eddyb @bors @RalfJung