Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#63561 #64109

Closed
rust-highfive opened this issue Sep 3, 2019 · 2 comments · Fixed by #64211
Closed

miri no longer builds after rust-lang/rust#63561 #64109

rust-highfive opened this issue Sep 3, 2019 · 2 comments · Fixed by #64211
Assignees
Labels
P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #63561, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @HeroicKatora, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 3, 2019
@RalfJung RalfJung mentioned this issue Sep 3, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Sep 3, 2019

I need to port parts of tag_allocation from miri to rustc and only keep the actual miri-parts in miri. I'll try to get it done by tomorrow night.

@nikomatsakis
Copy link
Contributor

check-in from compiler triage:

Go @oli-obk, go! 🐎

@nikomatsakis nikomatsakis added the P-high High priority label Sep 5, 2019
@oli-obk oli-obk mentioned this issue Sep 6, 2019
@bors bors closed this as completed in 4894123 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants