Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #64253

Closed
wants to merge 13 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Sep 7, 2019

Successful merges:

Failed merges:

r? @ghost

tmandry and others added 13 commits August 29, 2019 17:51
We never allowed the warnings, only made them not denied.
…mertj

libstd fuchsia fixes

This fixes two bugs in libstd on Fuchsia:

- `zx_time_t` was changed to an `i64`, but this never made it into libstd
- When spawning processes where any of the stdio were null, libstd attempts to open `/dev/null`, which doesn't exist on Fuchsia

r? @cramertj
…crichton

Ensure edition lints and internal lints are enabled with deny-warnings=false

Previously we only passed the deny command line flags if deny-warnings was enabled, but now we either pass -W... or -D... for each of the flags as appropriate.

This is also a breaking change to x.py as it changes `--warnings=allow` to `--warnings=warn` which is what that flag actually did; we don't have an allow warnings mode.
@Centril
Copy link
Contributor Author

Centril commented Sep 7, 2019

@bors r+ p=4 rollup=never

@bors
Copy link
Contributor

bors commented Sep 7, 2019

📌 Commit 1a67cb4 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 7, 2019
@Centril Centril closed this Sep 7, 2019
@Centril Centril deleted the rollup-lllctxz branch September 7, 2019 15:34
@rust-highfive
Copy link
Collaborator

The job LinuxTools of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-07T14:18:23.0688718Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-07T14:18:23.0881490Z ##[command]git config gc.auto 0
2019-09-07T14:18:23.0960563Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-07T14:18:23.1037124Z ##[command]git config --get-all http.proxy
2019-09-07T14:18:24.1116405Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64253/merge:refs/remotes/pull/64253/merge
---
2019-09-07T16:12:39.8054905Z    Compiling mdbook-linkcheck v0.3.0
2019-09-07T16:12:57.2285667Z    Compiling rustbook v0.1.0 (/checkout/src/tools/rustbook)
2019-09-07T16:13:01.8396984Z     Finished release [optimized] target(s) in 8m 43s
2019-09-07T16:14:33.8053134Z Error: there are broken links
2019-09-07T16:14:33.8053340Z  Caused By: "https://cs.au.dk/~amoeller/spa/" returned 503 Service Unavailable
2019-09-07T16:14:33.8090352Z 
2019-09-07T16:14:33.8091854Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rustbook" "linkcheck" "/checkout/src/doc/rustc-guide"
2019-09-07T16:14:33.8092015Z expected success, got: exit code: 101
2019-09-07T16:14:33.8092368Z 
---
2019-09-07T16:33:46.7484293Z 
2019-09-07T16:33:46.7486661Z error: error pattern ' tried to deallocate Stack memory but gave Machine(Rust) as the kind' not found!
2019-09-07T16:33:46.7492655Z test [compile-fail] compile-fail/slice-too-big.rs ... ok
2019-09-07T16:33:46.7492774Z status: exit code: 1
2019-09-07T16:33:46.7500917Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/compile-fail/stack_free.rs" "-L" "/tmp/compiletestSbZa3M" "--target=x86_64-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/tmp/compiletestSbZa3M/stack_free.stage-id" "--edition" "2018" "-Astable-features" "--sysroot" "/home/user/.cache/miri/HOST" "-Zmiri-disable-validation" "-L" "/tmp/compiletestSbZa3M/stack_free.stage-id.aux" "-A" "unused"
2019-09-07T16:33:46.7501349Z ------------------------------------------
2019-09-07T16:33:46.7501402Z 
2019-09-07T16:33:46.7501617Z ------------------------------------------
2019-09-07T16:33:46.7501659Z stderr:
---
2019-09-07T16:33:46.7511340Z     |     ^^^^^^^^^^^^^
2019-09-07T16:33:46.7511408Z     = note: inside call to `main` at /checkout/src/libstd/rt.rs:64:34
2019-09-07T16:33:46.7511453Z     = note: inside call to closure at /checkout/src/libstd/rt.rs:52:53
2019-09-07T16:33:46.7511507Z     = note: inside call to closure at /checkout/src/libstd/panicking.rs:296:40
2019-09-07T16:33:46.7511926Z     = note: inside call to `std::panicking::try::do_call::<[closure@DefId(1:5902 ~ std[e07c]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/panicking.rs:292:5
2019-09-07T16:33:46.7512325Z     = note: inside call to `std::panicking::try::<i32, [closure@DefId(1:5902 ~ std[e07c]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe]>` at /checkout/src/libstd/panic.rs:394:9
2019-09-07T16:33:46.7512736Z     = note: inside call to `std::panic::catch_unwind::<[closure@DefId(1:5902 ~ std[e07c]::rt[0]::lang_start_internal[0]::{{closure}}[0]) 0:&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe], i32>` at /checkout/src/libstd/rt.rs:52:25
2019-09-07T16:33:46.7513196Z     = note: inside call to `std::rt::lang_start::<()>`
2019-09-07T16:33:46.7513233Z 
2019-09-07T16:33:46.7513272Z error: aborting due to previous error
2019-09-07T16:33:46.7513299Z 
---
2019-09-07T16:33:53.9663251Z This PR updated 'src/doc/rustc-guide', verifying if status is 'test-pass'...
2019-09-07T16:33:53.9678478Z 
2019-09-07T16:33:53.9679255Z ⚠️ We detected that this PR updated 'rustc-guide', but its tests failed.
2019-09-07T16:33:53.9679797Z 
2019-09-07T16:33:53.9680221Z If you do intend to update 'rustc-guide', please check the error messages above and
2019-09-07T16:33:53.9680416Z commit another update.
2019-09-07T16:33:53.9680714Z 
2019-09-07T16:33:53.9681085Z If you do NOT intend to update 'rustc-guide', please ensure you did not accidentally
2019-09-07T16:33:53.9681344Z change the submodule at 'src/doc/rustc-guide'. You may ask your reviewer for the
2019-09-07T16:33:53.9681560Z proper steps.
2019-09-07T16:33:53.9703165Z   local time: Sat Sep  7 16:33:53 UTC 2019
2019-09-07T16:33:54.1197710Z   network time: Sat, 07 Sep 2019 16:33:54 GMT
2019-09-07T16:33:54.1201604Z == end clock drift check ==
2019-09-07T16:33:54.1201604Z == end clock drift check ==
2019-09-07T16:33:54.7757933Z ##[error]Bash exited with code '3'.
2019-09-07T16:33:54.7800681Z ##[section]Starting: Checkout
2019-09-07T16:33:54.7802483Z ==============================================================================
2019-09-07T16:33:54.7802529Z Task         : Get sources
2019-09-07T16:33:54.7802569Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants