Update rustc-guide #64195

mark-i-m · 2019-09-05T22:06:53Z

rust-highfive · 2019-09-05T22:06:56Z

⚠️ Warning ⚠️

These commits modify submodules.

rust-highfive · 2019-09-06T00:01:38Z

The job LinuxTools of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-05T22:07:33.3122688Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-05T22:07:33.3304297Z ##[command]git config gc.auto 0
2019-09-05T22:07:33.3385433Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-05T22:07:33.3447095Z ##[command]git config --get-all http.proxy
2019-09-05T22:07:33.3637782Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64195/merge:refs/remotes/pull/64195/merge
---
2019-09-05T23:49:38.4470179Z    Compiling mdbook v0.3.1
2019-09-05T23:50:10.7346463Z    Compiling mdbook-linkcheck v0.3.0
2019-09-05T23:50:22.4199500Z    Compiling rustbook v0.1.0 (/checkout/src/tools/rustbook)
2019-09-05T23:50:26.3068559Z     Finished release [optimized] target(s) in 7m 38s
2019-09-05T23:50:26.3324887Z thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error(Msg("Unable to create missing chapters"), State { next_error: Some(Error(Io(Os { code: 30, kind: Other, message: "Read-only file system" }), State { next_error: None, backtrace: InternalBacktrace { backtrace: None } })), backtrace: InternalBacktrace { backtrace: None } })', src/libcore/result.rs:1084:5
2019-09-05T23:50:26.3326644Z 
2019-09-05T23:50:26.3326852Z 
2019-09-05T23:50:26.3327352Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rustbook" "linkcheck" "/checkout/src/doc/rustc-guide"
2019-09-05T23:50:26.3327719Z expected success, got: exit code: 101
---
2019-09-06T00:01:17.2008799Z This PR updated 'src/doc/rustc-guide', verifying if status is 'test-pass'...
2019-09-06T00:01:17.2019690Z 
2019-09-06T00:01:17.2020385Z ⚠️ We detected that this PR updated 'rustc-guide', but its tests failed.
2019-09-06T00:01:17.2020457Z 
2019-09-06T00:01:17.2020777Z If you do intend to update 'rustc-guide', please check the error messages above and
2019-09-06T00:01:17.2020834Z commit another update.
2019-09-06T00:01:17.2020863Z 
2019-09-06T00:01:17.2021168Z If you do NOT intend to update 'rustc-guide', please ensure you did not accidentally
2019-09-06T00:01:17.2021443Z change the submodule at 'src/doc/rustc-guide'. You may ask your reviewer for the
2019-09-06T00:01:17.2021495Z proper steps.
2019-09-06T00:01:17.2044725Z   local time: Fri Sep  6 00:01:17 UTC 2019
2019-09-06T00:01:17.3692205Z   network time: Fri, 06 Sep 2019 00:01:17 GMT
2019-09-06T00:01:17.3693182Z == end clock drift check ==
2019-09-06T00:01:17.3693182Z == end clock drift check ==
2019-09-06T00:01:19.0905257Z ##[error]Bash exited with code '3'.
2019-09-06T00:01:19.0934588Z ##[section]Starting: Checkout
2019-09-06T00:01:19.0936161Z ==============================================================================
2019-09-06T00:01:19.0936218Z Task         : Get sources
2019-09-06T00:01:19.0936255Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

mark-i-m · 2019-09-06T16:28:16Z

Seems that clippy/miri are not building? Rebased.

rust-highfive · 2019-09-06T18:34:54Z

The job LinuxTools of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-06T16:27:51.4029599Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-06T16:27:51.4254145Z ##[command]git config gc.auto 0
2019-09-06T16:27:51.4314817Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-06T16:27:51.4367243Z ##[command]git config --get-all http.proxy
2019-09-06T16:27:51.4516248Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64195/merge:refs/remotes/pull/64195/merge
---
2019-09-06T18:16:02.8618112Z    Compiling mdbook v0.3.1
2019-09-06T18:16:33.9059089Z    Compiling mdbook-linkcheck v0.3.0
2019-09-06T18:16:47.1011897Z    Compiling rustbook v0.1.0 (/checkout/src/tools/rustbook)
2019-09-06T18:16:51.1314943Z     Finished release [optimized] target(s) in 8m 02s
2019-09-06T18:16:51.1573292Z thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error(Msg("Unable to create missing chapters"), State { next_error: Some(Error(Io(Os { code: 30, kind: Other, message: "Read-only file system" }), State { next_error: None, backtrace: InternalBacktrace { backtrace: None } })), backtrace: InternalBacktrace { backtrace: None } })', src/libcore/result.rs:1084:5
2019-09-06T18:16:51.1574704Z 
2019-09-06T18:16:51.1574827Z 
2019-09-06T18:16:51.1575594Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rustbook" "linkcheck" "/checkout/src/doc/rustc-guide"
2019-09-06T18:16:51.1578018Z expected success, got: exit code: 101
---
2019-09-06T18:34:19.5294421Z This PR updated 'src/doc/rustc-guide', verifying if status is 'test-pass'...
2019-09-06T18:34:19.5304002Z 
2019-09-06T18:34:19.5305015Z ⚠️ We detected that this PR updated 'rustc-guide', but its tests failed.
2019-09-06T18:34:19.5305052Z 
2019-09-06T18:34:19.5305271Z If you do intend to update 'rustc-guide', please check the error messages above and
2019-09-06T18:34:19.5305713Z commit another update.
2019-09-06T18:34:19.5305789Z 
2019-09-06T18:34:19.5307074Z If you do NOT intend to update 'rustc-guide', please ensure you did not accidentally
2019-09-06T18:34:19.5307706Z change the submodule at 'src/doc/rustc-guide'. You may ask your reviewer for the
2019-09-06T18:34:19.5307801Z proper steps.
2019-09-06T18:34:19.5324592Z   local time: Fri Sep  6 18:34:19 UTC 2019
2019-09-06T18:34:19.6822048Z   network time: Fri, 06 Sep 2019 18:34:19 GMT
2019-09-06T18:34:19.6822126Z == end clock drift check ==
2019-09-06T18:34:19.6822126Z == end clock drift check ==
2019-09-06T18:34:20.3460481Z ##[error]Bash exited with code '3'.
2019-09-06T18:34:20.3495327Z ##[section]Starting: Checkout
2019-09-06T18:34:20.3497436Z ==============================================================================
2019-09-06T18:34:20.3497513Z Task         : Get sources
2019-09-06T18:34:20.3497561Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

ehuss · 2019-09-06T18:54:30Z

2019-09-06T18:16:51.1573292Z thread 'main' panicked at 'called Result::unwrap() on an Err value: Error(Msg("Unable to create missing chapters"), State { next_error: Some(Error(Io(Os { code: 30, kind: Other, message: "Read-only file system" }), State { next_error: None, backtrace: InternalBacktrace { backtrace: None } })), backtrace: InternalBacktrace { backtrace: None } })', src/libcore/result.rs:1084:5

It looks like some chapters were deleted, but they were not removed from SUMMARY.md.

mark-i-m · 2019-09-06T19:30:55Z

This passes locally for me. In the past, we did have that problem, but it should be correct now. The error "Read-only file system" is a bit weird.

ehuss · 2019-09-06T20:12:21Z

it should be correct now.

I think this PR needs to update the submodule to 941968db2fd9c85788a4f971c8e425d46b4cb734 to pick up rust-lang/rustc-dev-guide#439 to make it pass. Since the docker volume is mounted readonly, it protects against issues like this where the source tree is modified.

mark-i-m · 2019-09-06T21:02:24Z

Huh? I thought I had. Just pushed.

ehuss · 2019-09-06T23:41:18Z

@bors r+

bors · 2019-09-06T23:41:20Z

📌 Commit 13413d6 has been approved by ehuss

@ehuss

Update rustc-guide r? @ehuss

@ehuss

Update rustc-guide r? @ehuss

Centril · 2019-09-07T18:01:04Z

Failed in #64257 (comment), @bors r-

mark-i-m · 2019-09-09T01:20:47Z

@ehuss That looks like a transient failure. It is still passing locally.

@Centril In future, I don't think we should attempt to rollup rustc-guide updates, as they have a chance of spurious failures that could frustrate the rollup.

mark-i-m · 2019-09-09T01:26:39Z

Also rebased.

ehuss · 2019-09-09T02:21:19Z

@bors r+

bors · 2019-09-09T02:21:20Z

📌 Commit 7c2dad2 has been approved by ehuss

bors · 2019-09-09T04:44:24Z

⌛ Testing commit 7c2dad2 with merge 1e86913...

@ehuss

Update rustc-guide r? @ehuss

bors · 2019-09-09T08:39:55Z

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing 1e86913 to master...

rust-highfive · 2019-09-09T08:41:08Z

📣 Toolstate changed by #64195!

Tested on commit 1e86913.
Direct link to PR: #64195

🎉 rustc-guide on linux: test-fail → test-pass (cc @mark-i-m @spastorino @amanjeev, @rust-lang/infra).

@mark-i-m

Tested on commit rust-lang/rust@1e86913. Direct link to PR: <rust-lang/rust#64195> 🎉 rustc-guide on linux: test-fail → test-pass (cc @mark-i-m @spastorino @amanjeev, @rust-lang/infra).

rust-highfive assigned ehuss Sep 5, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2019

mark-i-m force-pushed the update-rustc-guide-1 branch from 2cf94b9 to 4c4f25c Compare September 6, 2019 16:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2019

Centril added a commit to Centril/rust that referenced this pull request Sep 7, 2019

Rollup merge of rust-lang#64195 - mark-i-m:update-rustc-guide-1, r=ehuss

ea2851e

Update rustc-guide r? @ehuss

Centril mentioned this pull request Sep 7, 2019

Rollup of 4 pull requests #64253

Closed

Centril added a commit to Centril/rust that referenced this pull request Sep 7, 2019

Rollup merge of rust-lang#64195 - mark-i-m:update-rustc-guide-1, r=ehuss

9aaeef0

Update rustc-guide r? @ehuss

Centril mentioned this pull request Sep 7, 2019

Rollup of 6 pull requests #64257

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2019

mark-i-m added 2 commits September 8, 2019 20:25

update rustc-guide

19db48a

update guide

7c2dad2

mark-i-m force-pushed the update-rustc-guide-1 branch from 13413d6 to 7c2dad2 Compare September 9, 2019 01:25

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2019

bors added a commit that referenced this pull request Sep 9, 2019

Auto merge of #64195 - mark-i-m:update-rustc-guide-1, r=ehuss

1e86913

Update rustc-guide r? @ehuss

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2019

bors merged commit 7c2dad2 into rust-lang:master Sep 9, 2019

mark-i-m deleted the update-rustc-guide-1 branch December 11, 2019 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rustc-guide #64195

Update rustc-guide #64195

mark-i-m commented Sep 5, 2019

rust-highfive commented Sep 5, 2019

rust-highfive commented Sep 6, 2019

mark-i-m commented Sep 6, 2019

rust-highfive commented Sep 6, 2019

ehuss commented Sep 6, 2019

mark-i-m commented Sep 6, 2019

ehuss commented Sep 6, 2019

mark-i-m commented Sep 6, 2019

ehuss commented Sep 6, 2019

bors commented Sep 6, 2019

Centril commented Sep 7, 2019

mark-i-m commented Sep 9, 2019

mark-i-m commented Sep 9, 2019

ehuss commented Sep 9, 2019

bors commented Sep 9, 2019

bors commented Sep 9, 2019

bors commented Sep 9, 2019

rust-highfive commented Sep 9, 2019

Update rustc-guide #64195

Update rustc-guide #64195

Conversation

mark-i-m commented Sep 5, 2019

rust-highfive commented Sep 5, 2019

rust-highfive commented Sep 6, 2019

mark-i-m commented Sep 6, 2019

rust-highfive commented Sep 6, 2019

ehuss commented Sep 6, 2019

mark-i-m commented Sep 6, 2019

ehuss commented Sep 6, 2019

mark-i-m commented Sep 6, 2019

ehuss commented Sep 6, 2019

bors commented Sep 6, 2019

Centril commented Sep 7, 2019

mark-i-m commented Sep 9, 2019

mark-i-m commented Sep 9, 2019

ehuss commented Sep 9, 2019

bors commented Sep 9, 2019

bors commented Sep 9, 2019

bors commented Sep 9, 2019

rust-highfive commented Sep 9, 2019