Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor librustc_errors::Handler API #64272

Open
wants to merge 7 commits into
base: master
from

Conversation

@Mark-Simulacrum
Copy link
Member

commented Sep 7, 2019

This should be reviewed by-commit.

The last commit moves all fields into an inner struct behind a single lock; this is done to prevent possible deadlocks in a multi-threaded compiler, as well as inconsistent state observation.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

cc @aturon as part of parallel rustc efforts

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Sep 8, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-07T23:26:27.6605321Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-07T23:26:27.6787784Z ##[command]git config gc.auto 0
2019-09-07T23:26:27.6883063Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-07T23:26:27.6935546Z ##[command]git config --get-all http.proxy
2019-09-07T23:26:27.7100700Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64272/merge:refs/remotes/pull/64272/merge
---
2019-09-08T00:30:14.1302506Z .................................................................................................... 1500/9006
2019-09-08T00:30:20.3751415Z .................................................................................................... 1600/9006
2019-09-08T00:30:33.8973999Z ......................................................i...............i............................. 1700/9006
2019-09-08T00:30:42.2217558Z .................................................................................................... 1800/9006
2019-09-08T00:30:57.4130387Z .............................................iiiii.................................................. 1900/9006
2019-09-08T00:31:09.0978836Z .................................................................................................... 2100/9006
2019-09-08T00:31:11.8491275Z .................................................................................................... 2200/9006
2019-09-08T00:31:15.7505757Z .................................................................................................... 2300/9006
2019-09-08T00:31:24.2614095Z .................................................................................................... 2400/9006
---
2019-09-08T00:34:32.8336446Z ..................................i..............i.................................................. 4700/9006
2019-09-08T00:34:45.2255388Z .................................................................................................... 4800/9006
2019-09-08T00:34:51.7007089Z .................................................................................................... 4900/9006
2019-09-08T00:35:02.9086269Z .................................................................................................... 5000/9006
2019-09-08T00:35:09.3211884Z ...............ii.ii................................................................................ 5100/9006
2019-09-08T00:35:20.6588904Z .................................................................................................... 5300/9006
2019-09-08T00:35:31.3248635Z ..............................................................................i..................... 5400/9006
2019-09-08T00:35:39.5823302Z .................................................................................................... 5500/9006
2019-09-08T00:35:46.0594517Z .................................................................................................... 5600/9006
2019-09-08T00:35:46.0594517Z .................................................................................................... 5600/9006
2019-09-08T00:35:57.2098016Z ........................................................................ii...i..ii...........i...... 5700/9006
2019-09-08T00:36:23.5811661Z .................................................................................................... 5900/9006
2019-09-08T00:36:34.3965979Z .................................................................................................... 6000/9006
2019-09-08T00:36:34.3965979Z .................................................................................................... 6000/9006
2019-09-08T00:36:41.8735400Z ..........................................................................i..ii..................... 6100/9006
2019-09-08T00:37:13.2350422Z .................................................................................................... 6300/9006
2019-09-08T00:37:15.5258580Z .................................i.................................................................. 6400/9006
2019-09-08T00:37:17.9270179Z .................................................................................................... 6500/9006
2019-09-08T00:37:20.7656865Z .....i.............................................................................................. 6600/9006
---
2019-09-08T00:42:27.5070284Z  finished in 22.545
2019-09-08T00:42:27.5071321Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-08T00:42:27.5071407Z 
2019-09-08T00:42:27.5071452Z running 150 tests
2019-09-08T00:42:31.5009340Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/150
2019-09-08T00:42:32.7868001Z ..iiii..............i.........iii.i.......ii......
2019-09-08T00:42:32.7873872Z 
2019-09-08T00:42:32.7880179Z  finished in 5.873
2019-09-08T00:42:32.8074096Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-08T00:42:33.0014957Z 
---
2019-09-08T00:42:35.5022165Z  finished in 2.436
2019-09-08T00:42:35.5022554Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-08T00:42:35.5022730Z 
2019-09-08T00:42:35.5023584Z running 9 tests
2019-09-08T00:42:35.5056121Z iiiiiiiii
2019-09-08T00:42:35.5056934Z 
2019-09-08T00:42:35.5057042Z  finished in 0.187
2019-09-08T00:42:35.5057787Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-08T00:42:35.6782483Z 
---
2019-09-08T00:42:54.8360602Z  finished in 19.365
2019-09-08T00:42:54.8636851Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-08T00:42:55.0475695Z 
2019-09-08T00:42:55.0476127Z running 123 tests
2019-09-08T00:43:20.1362358Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-08T00:43:25.2464544Z i.i.i......iii.i.....ii
2019-09-08T00:43:25.2466252Z 
2019-09-08T00:43:25.2469171Z  finished in 30.383
2019-09-08T00:43:25.2479157Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-08T00:43:25.2479975Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-08T00:58:25.9087287Z 
2019-09-08T00:58:25.9088597Z    Doc-tests core
2019-09-08T00:58:31.5533535Z 
2019-09-08T00:58:31.5560361Z running 2395 tests
2019-09-08T00:58:43.4875557Z ......iiiii......................................................................................... 100/2395
2019-09-08T00:58:55.2858189Z .........................................................................ii......................... 200/2395
2019-09-08T00:59:22.8053856Z .................................................................................................... 400/2395
2019-09-08T00:59:22.8053856Z .................................................................................................... 400/2395
2019-09-08T00:59:34.0388876Z .......................................i..i.................iiii.................................... 500/2395
2019-09-08T00:59:56.0934189Z .................................................................................................... 700/2395
2019-09-08T01:00:07.3952419Z .................................................................................................... 800/2395
2019-09-08T01:00:18.7574509Z .................................................................................................... 900/2395
2019-09-08T01:00:30.3379694Z .................................................................................................... 1000/2395
---
2019-09-08T01:05:57.3785173Z 
2019-09-08T01:05:57.3785553Z running 991 tests
2019-09-08T01:06:20.6583134Z i................................................................................................... 100/991
2019-09-08T01:06:33.3633529Z .................................................................................................... 200/991
2019-09-08T01:06:42.2674618Z .................iii......i......i...i......i....................................................... 300/991
2019-09-08T01:06:48.3975491Z .................................................................................................... 400/991
2019-09-08T01:06:56.9323524Z ..................................i..i.................................ii........................... 500/991
2019-09-08T01:07:13.1330476Z .................................................................................................... 700/991
2019-09-08T01:07:13.1330476Z .................................................................................................... 700/991
2019-09-08T01:07:21.7743224Z .................iiii............................................................................... 800/991
2019-09-08T01:07:37.8682190Z .................................................................................................... 900/991
2019-09-08T01:07:45.9687163Z .......................................iiii................................................
2019-09-08T01:07:45.9690479Z 
2019-09-08T01:07:45.9728355Z  finished in 265.809
2019-09-08T01:07:45.9745647Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-08T01:07:46.2968628Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-09-08T01:08:10.7718281Z 
2019-09-08T01:08:10.7775429Z  finished in 3.131
2019-09-08T01:08:10.7785268Z Testing rustc stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-08T01:08:11.0074405Z    Compiling rustc v0.0.0 (/checkout/src/librustc)
2019-09-08T01:08:32.5332150Z error[E0616]: field `flags` of struct `syntax::rustc_errors::Handler` is private
2019-09-08T01:08:32.5332734Z   --> src/librustc/session/config/tests.rs:90:18
2019-09-08T01:08:32.5333006Z    |
2019-09-08T01:08:32.5333365Z 90 |         assert!(!sess.diagnostic().flags.can_emit_warnings);
2019-09-08T01:08:32.5333770Z 
2019-09-08T01:08:32.5333770Z 
2019-09-08T01:08:32.5347084Z error[E0616]: field `flags` of struct `syntax::rustc_errors::Handler` is private
2019-09-08T01:08:32.5347895Z    --> src/librustc/session/config/tests.rs:100:17
2019-09-08T01:08:32.5348677Z     |
2019-09-08T01:08:32.5349388Z 100 |         assert!(sess.diagnostic().flags.can_emit_warnings);
2019-09-08T01:08:32.5350146Z 
2019-09-08T01:08:32.5350146Z 
2019-09-08T01:08:32.5362619Z error[E0616]: field `flags` of struct `syntax::rustc_errors::Handler` is private
2019-09-08T01:08:32.5363293Z    --> src/librustc/session/config/tests.rs:108:17
2019-09-08T01:08:32.5364191Z     |
2019-09-08T01:08:32.5364739Z 108 |         assert!(sess.diagnostic().flags.can_emit_warnings);
2019-09-08T01:08:32.5365954Z 
2019-09-08T01:08:40.7509403Z error: aborting due to 3 previous errors
2019-09-08T01:08:40.7510342Z 
2019-09-08T01:08:40.7510998Z For more information about this error, try `rustc --explain E0616`.
---
2019-09-08T01:08:41.0839356Z == clock drift check ==
2019-09-08T01:08:41.0856972Z   local time: Sun Sep  8 01:08:41 UTC 2019
2019-09-08T01:08:41.3672192Z   network time: Sun, 08 Sep 2019 01:08:41 GMT
2019-09-08T01:08:41.3672473Z == end clock drift check ==
2019-09-08T01:08:41.9802391Z ##[error]Bash exited with code '1'.
2019-09-08T01:08:41.9852330Z ##[section]Starting: Checkout
2019-09-08T01:08:41.9855152Z ==============================================================================
2019-09-08T01:08:41.9855231Z Task         : Get sources
2019-09-08T01:08:41.9855298Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum

This comment was marked as resolved.

Copy link
Member Author

commented Sep 8, 2019

Will fix tests after review probably, they shouldn't really be a major impact.

src/librustc_errors/lib.rs Outdated Show resolved Hide resolved

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:parallel-handler branch from 52b3d1f to 0b94900 Sep 9, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Sep 9, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-09T14:24:26.4387585Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-09T14:24:26.4598834Z ##[command]git config gc.auto 0
2019-09-09T14:24:26.4661175Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-09T14:24:26.4730660Z ##[command]git config --get-all http.proxy
2019-09-09T14:24:26.4861092Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64272/merge:refs/remotes/pull/64272/merge
---
2019-09-09T15:22:01.6115346Z .................................................................................................... 1500/9009
2019-09-09T15:22:07.1184140Z .................................................................................................... 1600/9009
2019-09-09T15:22:18.9530391Z ......................................................i...............i............................. 1700/9009
2019-09-09T15:22:26.3595594Z .................................................................................................... 1800/9009
2019-09-09T15:22:39.7894966Z .............................................iiiii.................................................. 1900/9009
2019-09-09T15:22:49.9842879Z .................................................................................................... 2100/9009
2019-09-09T15:22:52.3385948Z .................................................................................................... 2200/9009
2019-09-09T15:22:55.7118244Z .................................................................................................... 2300/9009
2019-09-09T15:23:03.0444979Z .................................................................................................... 2400/9009
---
2019-09-09T15:25:48.5666908Z ...................................i...............i................................................ 4700/9009
2019-09-09T15:25:59.2394946Z .................................................................................................... 4800/9009
2019-09-09T15:26:05.1863035Z .................................................................................................... 4900/9009
2019-09-09T15:26:15.0079986Z .................................................................................................... 5000/9009
2019-09-09T15:26:20.6727257Z .................ii.ii.............................................................................. 5100/9009
2019-09-09T15:26:30.3886623Z .................................................................................................... 5300/9009
2019-09-09T15:26:39.8372162Z ................................................................................i................... 5400/9009
2019-09-09T15:26:47.1618705Z .................................................................................................... 5500/9009
2019-09-09T15:26:52.6726075Z .................................................................................................... 5600/9009
2019-09-09T15:26:52.6726075Z .................................................................................................... 5600/9009
2019-09-09T15:27:02.6258012Z ..........................................................................ii...i..ii...........i.... 5700/9009
2019-09-09T15:27:26.0378840Z .................................................................................................... 5900/9009
2019-09-09T15:27:32.9298862Z .................................................................................................... 6000/9009
2019-09-09T15:27:32.9298862Z .................................................................................................... 6000/9009
2019-09-09T15:27:37.7852710Z ............................................................................i..ii................... 6100/9009
2019-09-09T15:28:05.1068504Z .................................................................................................... 6300/9009
2019-09-09T15:28:07.0502387Z ...................................i................................................................ 6400/9009
2019-09-09T15:28:09.0279071Z .................................................................................................... 6500/9009
2019-09-09T15:28:11.2831406Z .......i............................................................................................ 6600/9009
---
2019-09-09T15:32:34.8032824Z  finished in 18.378
2019-09-09T15:32:34.8203570Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T15:32:34.9751856Z 
2019-09-09T15:32:34.9752744Z running 150 tests
2019-09-09T15:32:37.9604209Z i....iii......iii..iiii....i..............................i.i..................i....i.........ii.i.i 100/150
2019-09-09T15:32:39.8057058Z ..iiii..............i.........iii.i.......ii......
2019-09-09T15:32:39.8058732Z 
2019-09-09T15:32:39.8075581Z  finished in 4.986
2019-09-09T15:32:39.8244012Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T15:32:39.9712724Z 
---
2019-09-09T15:32:41.9282228Z  finished in 2.103
2019-09-09T15:32:41.9470340Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T15:32:42.0908325Z 
2019-09-09T15:32:42.0909530Z running 9 tests
2019-09-09T15:32:42.0911207Z iiiiiiiii
2019-09-09T15:32:42.0911729Z 
2019-09-09T15:32:42.0913330Z  finished in 0.144
2019-09-09T15:32:42.1078742Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T15:32:42.2504295Z 
---
2019-09-09T15:32:59.2386651Z  finished in 17.130
2019-09-09T15:32:59.2557941Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T15:32:59.3984102Z 
2019-09-09T15:32:59.3984249Z running 123 tests
2019-09-09T15:33:20.9431916Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-09T15:33:25.1507974Z i.i.i......iii.i.....ii
2019-09-09T15:33:25.1509694Z 
2019-09-09T15:33:25.1513504Z  finished in 25.895
2019-09-09T15:33:25.1520271Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T15:33:25.1521515Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-09T15:46:08.4937742Z .................................................................................................... 100/977
2019-09-09T15:46:08.5074881Z .................................................................................................... 200/977
2019-09-09T15:46:08.5165102Z .................................................................................................... 300/977
2019-09-09T15:46:08.5297921Z .................................................................................................... 400/977
2019-09-09T15:46:08.6922143Z ..ii................................................................................................ 500/977
2019-09-09T15:46:08.7185107Z .................................................................................................... 700/977
2019-09-09T15:46:08.7358919Z .................................................................................................... 800/977
2019-09-09T15:46:09.2098591Z .................................................................................................... 900/977
2019-09-09T15:46:10.1755493Z .............................................................................
2019-09-09T15:46:10.1755493Z .............................................................................
2019-09-09T15:46:10.1755734Z test result: ok. 975 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out
2019-09-09T15:46:10.1757201Z 
2019-09-09T15:46:10.1758154Z    Doc-tests core
2019-09-09T15:46:14.8453128Z 
2019-09-09T15:46:14.8454445Z running 2400 tests
2019-09-09T15:46:25.1103652Z ......iiiii......................................................................................... 100/2400
2019-09-09T15:46:34.8863661Z ...........................................................................ii....................... 200/2400
2019-09-09T15:46:45.9810427Z .................................................................................................i.. 300/2400
2019-09-09T15:46:58.1418701Z .................................................................................................... 400/2400
2019-09-09T15:47:07.6733089Z ............................................i..i.................iiii............................... 500/2400
2019-09-09T15:47:26.2146531Z .................................................................................................... 700/2400
2019-09-09T15:47:35.7428616Z .................................................................................................... 800/2400
2019-09-09T15:47:45.2076038Z .................................................................................................... 900/2400
2019-09-09T15:47:54.6617835Z .................................................................................................... 1000/2400
---
2019-09-09T15:52:30.0388379Z 
2019-09-09T15:52:30.0388675Z running 991 tests
2019-09-09T15:52:49.3432049Z i................................................................................................... 100/991
2019-09-09T15:52:59.8666626Z .................................................................................................... 200/991
2019-09-09T15:53:07.4350089Z .................iii......i......i...i......i....................................................... 300/991
2019-09-09T15:53:12.6263414Z .................................................................................................... 400/991
2019-09-09T15:53:19.9436860Z ..................................i..i.................................ii........................... 500/991
2019-09-09T15:53:33.6694345Z .................................................................................................... 700/991
2019-09-09T15:53:33.6694345Z .................................................................................................... 700/991
2019-09-09T15:53:41.1236004Z .................iiii............................................................................... 800/991
2019-09-09T15:53:55.0593774Z .................................................................................................... 900/991
2019-09-09T15:54:01.9959186Z .......................................iiii................................................
2019-09-09T15:54:01.9960522Z 
2019-09-09T15:54:02.0013288Z  finished in 225.263
2019-09-09T15:54:02.0015411Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T15:54:02.2774194Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-09-09T15:57:08.6456361Z    --> src/libsyntax/tests.rs:143:23
2019-09-09T15:57:08.6457109Z     |
2019-09-09T15:57:08.6457633Z 143 |           let emitter = EmitterWriter::new(
2019-09-09T15:57:08.6458078Z     |  _______________________^
2019-09-09T15:57:08.6458613Z 144 | |             Box::new(Shared { data: output.clone() }),
2019-09-09T15:57:08.6459210Z 145 | |             Some(source_map.clone()),
2019-09-09T15:57:08.6460468Z ...   |
2019-09-09T15:57:08.6460841Z 149 | |             None,
2019-09-09T15:57:08.6461251Z 150 | |         );
2019-09-09T15:57:08.6461640Z     | |_________^ expected 7 parameters
2019-09-09T15:57:08.6461640Z     | |_________^ expected 7 parameters
2019-09-09T15:57:08.6461775Z 
2019-09-09T15:57:11.3969353Z error[E0061]: this function takes 7 parameters but 6 parameters were supplied
2019-09-09T15:57:11.3970691Z   --> src/libsyntax/parse/lexer/tests.rs:14:19
2019-09-09T15:57:11.3971195Z    |
2019-09-09T15:57:11.3971717Z 14 |       let emitter = EmitterWriter::new(
2019-09-09T15:57:11.3972488Z    |  ___________________^
2019-09-09T15:57:11.3972963Z 15 | |         Box::new(io::sink()),
2019-09-09T15:57:11.3973419Z 16 | |         Some(sm.clone()),
2019-09-09T15:57:11.3974496Z ...  |
2019-09-09T15:57:11.3975031Z 20 | |         None,
2019-09-09T15:57:11.3975703Z 21 | |     );
2019-09-09T15:57:11.3976169Z    | |_____^ expected 7 parameters
---
2019-09-09T15:57:12.9313411Z 
2019-09-09T15:57:12.9313863Z To learn more, run the command again with --verbose.
2019-09-09T15:57:12.9322044Z 
2019-09-09T15:57:12.9322408Z 
2019-09-09T15:57:12.9323301Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
2019-09-09T15:57:12.9323453Z 
2019-09-09T15:57:12.9323481Z 
2019-09-09T15:57:12.9334545Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-09T15:57:12.9334629Z Build completed unsuccessfully in 1:25:48
2019-09-09T15:57:12.9334629Z Build completed unsuccessfully in 1:25:48
2019-09-09T15:57:12.9384581Z == clock drift check ==
2019-09-09T15:57:12.9405086Z   local time: Mon Sep  9 15:57:12 UTC 2019
2019-09-09T15:57:13.0961705Z   network time: Mon, 09 Sep 2019 15:57:13 GMT
2019-09-09T15:57:13.0967522Z == end clock drift check ==
2019-09-09T15:57:13.6661908Z ##[error]Bash exited with code '1'.
2019-09-09T15:57:13.6700929Z ##[section]Starting: Checkout
2019-09-09T15:57:13.6702469Z ==============================================================================
2019-09-09T15:57:13.6702524Z Task         : Get sources
2019-09-09T15:57:13.6702577Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:parallel-handler branch from 0b94900 to 33aaa1f Sep 9, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Sep 9, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-09T22:06:52.1941928Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-09T22:06:52.2124907Z ##[command]git config gc.auto 0
2019-09-09T22:06:52.2238009Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-09T22:06:52.2258985Z ##[command]git config --get-all http.proxy
2019-09-09T22:06:52.2423610Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64272/merge:refs/remotes/pull/64272/merge
---
2019-09-09T23:08:58.6552993Z .................................................................................................... 1500/9006
2019-09-09T23:09:04.3338031Z .................................................................................................... 1600/9006
2019-09-09T23:09:17.3798824Z .......................................................i...............i............................ 1700/9006
2019-09-09T23:09:24.9332942Z .................................................................................................... 1800/9006
2019-09-09T23:09:39.1383402Z ..............................................iiiii................................................. 1900/9006
2019-09-09T23:09:49.7658912Z .................................................................................................... 2100/9006
2019-09-09T23:09:52.2301504Z .................................................................................................... 2200/9006
2019-09-09T23:09:55.9175000Z .................................................................................................... 2300/9006
2019-09-09T23:10:03.4935497Z .................................................................................................... 2400/9006
---
2019-09-09T23:13:03.5267610Z .................................i...............i.................................................. 4700/9006
2019-09-09T23:13:15.2829228Z .................................................................................................... 4800/9006
2019-09-09T23:13:21.5763513Z .................................................................................................... 4900/9006
2019-09-09T23:13:32.3948871Z .................................................................................................... 5000/9006
2019-09-09T23:13:38.4979988Z ................ii.ii............................................................................... 5100/9006
2019-09-09T23:13:49.1061362Z .................................................................................................... 5300/9006
2019-09-09T23:13:59.3782685Z ...............................................................................i.................... 5400/9006
2019-09-09T23:14:07.4057634Z .................................................................................................... 5500/9006
2019-09-09T23:14:13.6403351Z .................................................................................................... 5600/9006
2019-09-09T23:14:13.6403351Z .................................................................................................... 5600/9006
2019-09-09T23:14:24.6746996Z .........................................................................ii...i..ii...........i..... 5700/9006
2019-09-09T23:14:50.7135529Z .................................................................................................... 5900/9006
2019-09-09T23:15:00.7098763Z .................................................................................................... 6000/9006
2019-09-09T23:15:00.7098763Z .................................................................................................... 6000/9006
2019-09-09T23:15:09.2454482Z ...........................................................................i..ii.................... 6100/9006
2019-09-09T23:15:39.1818859Z .................................................................................................... 6300/9006
2019-09-09T23:15:41.2480001Z ..................................i................................................................. 6400/9006
2019-09-09T23:15:43.4083860Z .................................................................................................... 6500/9006
2019-09-09T23:15:46.0134341Z ......i............................................................................................. 6600/9006
---
2019-09-09T23:20:26.8793639Z  finished in 19.312
2019-09-09T23:20:26.8976442Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T23:20:27.0541619Z 
2019-09-09T23:20:27.0542047Z running 150 tests
2019-09-09T23:20:30.2546548Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/150
2019-09-09T23:20:32.1962759Z ..iiii..............i.........iii.i.......ii......
2019-09-09T23:20:32.1966921Z 
2019-09-09T23:20:32.1967246Z  finished in 5.298
2019-09-09T23:20:32.2146003Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T23:20:32.3651366Z 
---
2019-09-09T23:20:34.4724081Z  finished in 2.257
2019-09-09T23:20:34.4899797Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T23:20:34.6429615Z 
2019-09-09T23:20:34.6430538Z running 9 tests
2019-09-09T23:20:34.6431463Z iiiiiiiii
2019-09-09T23:20:34.6431941Z 
2019-09-09T23:20:34.6435942Z  finished in 0.153
2019-09-09T23:20:34.6619719Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T23:20:34.8145863Z 
---
2019-09-09T23:20:52.7050909Z  finished in 18.043
2019-09-09T23:20:52.7244992Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T23:20:52.8797938Z 
2019-09-09T23:20:52.8799008Z running 123 tests
2019-09-09T23:21:15.9018138Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-09T23:21:20.4264483Z i.i.i......iii.i.....ii
2019-09-09T23:21:20.4266279Z 
2019-09-09T23:21:20.4272192Z  finished in 27.702
2019-09-09T23:21:20.4283638Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T23:21:20.4284335Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-09T23:35:07.6609681Z 
2019-09-09T23:35:07.6611053Z    Doc-tests core
2019-09-09T23:35:12.9974995Z 
2019-09-09T23:35:12.9976096Z running 2400 tests
2019-09-09T23:35:24.3994564Z ......iiiii......................................................................................... 100/2400
2019-09-09T23:35:35.7976892Z ...........................................................................ii....................... 200/2400
2019-09-09T23:35:48.4456512Z .................................................................................................i.. 300/2400
2019-09-09T23:36:02.2033784Z .................................................................................................... 400/2400
2019-09-09T23:36:12.9968788Z ............................................i..i.................iiii............................... 500/2400
2019-09-09T23:36:34.1417465Z .................................................................................................... 700/2400
2019-09-09T23:36:44.8574373Z .................................................................................................... 800/2400
2019-09-09T23:36:55.6148842Z .................................................................................................... 900/2400
2019-09-09T23:37:06.3527151Z .................................................................................................... 1000/2400
---
2019-09-09T23:42:05.9063173Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:611:13
2019-09-09T23:42:05.9073718Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:623:13
2019-09-09T23:42:07.9594721Z ..........................thread '<unnamed>' panicked at 'What the answer to my lifetimes dilemma is?', src/libstd/sys_common/remutex.rs:233:13
2019-09-09T23:42:07.9647371Z ........................ 700/763
2019-09-09T23:42:07.9750591Z ...................................thread '<unnamed>.' panicked at 'explicit panic', src/libstd/thread/mod.rs:1535:13
2019-09-09T23:42:08.5825249Z ...........thread '<unnamed>' panicked at 'Box<Any>', src/libstd/thread/mod.rs:1667:13
2019-09-09T23:42:08.5843017Z ..........thread '<unnamed>' panicked at 'owned string', src/libstd/thread/mod.rs:1653:13
2019-09-09T23:42:08.5844183Z thread '<unnamed>' panicked at 'Box<Any>', src/libstd/thread/mod.rs:1685:13
2019-09-09T23:42:14.0777584Z ......
2019-09-09T23:42:14.0778719Z test result: ok. 763 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
2019-09-09T23:42:14.0778891Z 
---
2019-09-09T23:42:15.3434392Z 
2019-09-09T23:42:15.3461977Z running 991 tests
2019-09-09T23:42:37.1145930Z i................................................................................................... 100/991
2019-09-09T23:42:48.9232422Z .................................................................................................... 200/991
2019-09-09T23:42:57.2995104Z .................iii......i......i...i......i....................................................... 300/991
2019-09-09T23:43:03.3029330Z .................................................................................................... 400/991
2019-09-09T23:43:11.3651789Z ..................................i..i.................................ii........................... 500/991
2019-09-09T23:43:26.8270383Z .................................................................................................... 700/991
2019-09-09T23:43:26.8270383Z .................................................................................................... 700/991
2019-09-09T23:43:35.1902551Z .................iiii............................................................................... 800/991
2019-09-09T23:43:50.5823681Z .................................................................................................... 900/991
2019-09-09T23:43:58.4167330Z .......................................iiii................................................
2019-09-09T23:43:58.4171223Z 
2019-09-09T23:43:58.4216454Z  finished in 251.653
2019-09-09T23:43:58.4233590Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-09T23:43:58.7535271Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-09-09T23:47:36.3044543Z   --> src/libsyntax/parse/lexer/tests.rs:14:19
2019-09-09T23:47:36.3045380Z    |
2019-09-09T23:47:36.3046040Z 14 |       let emitter = EmitterWriter::new(
2019-09-09T23:47:36.3047058Z    |  ___________________^
2019-09-09T23:47:36.3047706Z 15 | |         Box::new(io::sink()),
2019-09-09T23:47:36.3048361Z 16 | |         Some(sm.clone()),
2019-09-09T23:47:36.3049887Z ...  |
2019-09-09T23:47:36.3050404Z 20 | |         None,
2019-09-09T23:47:36.3051083Z 21 | |     );
2019-09-09T23:47:36.3051668Z    | |_____^ expected 7 parameters
---
2019-09-09T23:47:38.2078587Z 
2019-09-09T23:47:38.2079964Z To learn more, run the command again with --verbose.
2019-09-09T23:47:38.2099171Z 
2019-09-09T23:47:38.2099497Z 
2019-09-09T23:47:38.2100251Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
2019-09-09T23:47:38.2100449Z 
2019-09-09T23:47:38.2100474Z 
2019-09-09T23:47:38.2113327Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-09T23:47:38.2113612Z Build completed unsuccessfully in 1:33:05
2019-09-09T23:47:38.2113612Z Build completed unsuccessfully in 1:33:05
2019-09-09T23:47:38.2168967Z == clock drift check ==
2019-09-09T23:47:38.2185380Z   local time: Mon Sep  9 23:47:38 UTC 2019
2019-09-09T23:47:38.3700445Z   network time: Mon, 09 Sep 2019 23:47:38 GMT
2019-09-09T23:47:38.3706770Z == end clock drift check ==
2019-09-09T23:47:38.9714046Z ##[error]Bash exited with code '1'.
2019-09-09T23:47:38.9757919Z ##[section]Starting: Checkout
2019-09-09T23:47:38.9760594Z ==============================================================================
2019-09-09T23:47:38.9760650Z Task         : Get sources
2019-09-09T23:47:38.9760711Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:parallel-handler branch from 33aaa1f to 66cc1e3 Sep 10, 2019

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

CI is green here and this is good to go for review

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

☔️ The latest upstream changes (presumably #64456) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:parallel-handler branch from 66cc1e3 to 8f210f3 Sep 14, 2019

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2019

Rebased.

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2019

☔️ The latest upstream changes (presumably #60584) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:parallel-handler branch from 8f210f3 to 434e67b Sep 15, 2019

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2019

Rebased, again.

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:parallel-handler branch 2 times, most recently from 5802065 to 71f9add Sep 15, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Sep 16, 2019

The job LinuxTools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-16T21:13:18.5712299Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-16T21:13:19.3611971Z ##[command]git config gc.auto 0
2019-09-16T21:13:19.3616994Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-16T21:13:19.3620865Z ##[command]git config --get-all http.proxy
2019-09-16T21:13:19.3624821Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64272/merge:refs/remotes/pull/64272/merge
---
2019-09-16T23:07:07.4402372Z  Caused By: "https://rust-lang.github.io/chalk/doc/chalk_engine/context/index.html" returned 404 Not Found
2019-09-16T23:07:07.4402814Z  Caused By: "https://rust-lang.github.io/chalk/doc/chalk_parse/index.html" returned 404 Not Found
2019-09-16T23:07:07.4403265Z  Caused By: "https://rust-lang.github.io/chalk/doc/chalk/index.html" returned 404 Not Found
2019-09-16T23:07:07.4403696Z  Caused By: "https://rust-lang.github.io/chalk/doc/chalki/index.html" returned 404 Not Found
2019-09-16T23:07:07.4404732Z  Caused By: There was an error while fetching "http://fitzgeraldnick.com/2018/12/13/rust-raps.html", http://fitzgeraldnick.com/2018/12/13/rust-raps.html: error trying to connect: Connection refused (os error 111)
2019-09-16T23:07:07.4405204Z 
2019-09-16T23:07:07.4405898Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rustbook" "linkcheck" "/checkout/src/doc/rustc-guide"
2019-09-16T23:07:07.4406171Z expected success, got: exit code: 101
2019-09-16T23:07:07.4406304Z 
---
2019-09-16T23:26:25.1853039Z    |
2019-09-16T23:26:25.1853517Z 76 |     rustc_driver::report_ices_to_stderr_if_any(|| {
2019-09-16T23:26:25.1854019Z    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `rustc_driver`
2019-09-16T23:26:25.1859410Z 
2019-09-16T23:26:25.1933834Z warning: use of deprecated item 'rustc_plugin': import this through `rustc_driver::plugin` instead to make TLS work correctly. See ***/issues/62717
2019-09-16T23:26:25.1935362Z   |
2019-09-16T23:26:25.1935634Z 7 | extern crate rustc_plugin;
2019-09-16T23:26:25.1935913Z   | ^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-09-16T23:26:25.1936127Z   |
---
2019-09-16T23:36:38.8692660Z Verifying status of edition-guide...
2019-09-16T23:36:38.8705350Z Verifying status of rls...
2019-09-16T23:36:38.8719262Z This PR updated 'src/tools/rls', verifying if status is 'test-pass'...
2019-09-16T23:36:38.8733394Z 
2019-09-16T23:36:38.8734497Z ⚠️ We detected that this PR updated 'rls', but its tests failed.
2019-09-16T23:36:38.8734600Z 
2019-09-16T23:36:38.8735114Z If you do intend to update 'rls', please check the error messages above and
2019-09-16T23:36:38.8735189Z commit another update.
2019-09-16T23:36:38.8735218Z 
2019-09-16T23:36:38.8735507Z If you do NOT intend to update 'rls', please ensure you did not accidentally
2019-09-16T23:36:38.8735742Z change the submodule at 'src/tools/rls'. You may ask your reviewer for the
2019-09-16T23:36:38.8735790Z proper steps.
2019-09-16T23:36:38.8753531Z   local time: Mon Sep 16 23:36:38 UTC 2019
2019-09-16T23:36:39.0361137Z   network time: Mon, 16 Sep 2019 23:36:39 GMT
2019-09-16T23:36:39.0364466Z == end clock drift check ==
2019-09-16T23:36:39.0364466Z == end clock drift check ==
2019-09-16T23:36:40.3282519Z ##[error]Bash exited with code '3'.
2019-09-16T23:36:40.3327555Z ##[section]Starting: Checkout
2019-09-16T23:36:40.3329809Z ==============================================================================
2019-09-16T23:36:40.3329888Z Task         : Get sources
2019-09-16T23:36:40.3329941Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:parallel-handler branch from 71f9add to 4cc5aaa Sep 17, 2019

@estebank

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Sorry for the radio silence, I'll review this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.