Refactor librustc_errors::Handler API #64272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aturon as part of parallel rustc efforts |
Mark-Simulacrum
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fbstj
reviewed
Sep 8, 2019
Mark-Simulacrum
force-pushed
the
parallel-handler
branch
from
52b3d1f
to
0b94900
Compare
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
force-pushed
the
parallel-handler
branch
from
0b94900
to
33aaa1f
Compare
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
force-pushed
the
parallel-handler
branch
from
33aaa1f
to
66cc1e3
Compare
|
CI is green here and this is good to go for review |
|
☔ The latest upstream changes (presumably #64456) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrum
force-pushed
the
parallel-handler
branch
from
66cc1e3
to
8f210f3
Compare
|
Rebased. |
|
☔ The latest upstream changes (presumably #60584) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrum
force-pushed
the
parallel-handler
branch
from
8f210f3
to
434e67b
Compare
|
Rebased, again. |
Mark-Simulacrum
force-pushed
the
parallel-handler
branch
2 times, most recently
from
5802065
to
71f9add
Compare
This comment has been minimized.
This comment has been minimized.
This avoids concurrency-related bugs when locks are acquired for too short a time and similar cases.
Mark-Simulacrum
force-pushed
the
parallel-handler
branch
from
71f9add
to
4cc5aaa
Compare
|
Sorry for the radio silence, I'll review this tomorrow. |
|
Thanks for the clean commit history. It all makes sense, but making it stand alone merge to minimize the chance for conflicts. @bors r+ rollup=never |
|
📌 Commit 4cc5aaa has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 23, 2019
Refactor librustc_errors::Handler API This should be reviewed by-commit. The last commit moves all fields into an inner struct behind a single lock; this is done to prevent possible deadlocks in a multi-threaded compiler, as well as inconsistent state observation.
|
☀️ Test successful - checks-azure |
phansch
added a commit
to phansch/rust
that referenced
this pull request
Oct 15, 2019
rust-lang#64272 replaced `DiagnosticBuilder` with `Diagnostic` in some places. This commit just renames the DB variable from `db` to `diag` where it wasn't renamed.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 15, 2019
Refactor: Rename `db` locals to `diag` rust-lang#64272 replaced `DiagnosticBuilder` with `Diagnostic` in some places. This PR just renames the db variable from `db` to `diag` where it wasn't renamed. r? @Mark-Simulacrum
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 15, 2019
Refactor: Rename `db` locals to `diag` rust-lang#64272 replaced `DiagnosticBuilder` with `Diagnostic` in some places. This PR just renames the db variable from `db` to `diag` where it wasn't renamed. r? @Mark-Simulacrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reviewed by-commit.
The last commit moves all fields into an inner struct behind a single lock; this is done to prevent possible deadlocks in a multi-threaded compiler, as well as inconsistent state observation.