Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate `types.err` in locals further to avoid spurious knock-down errors #64674

Merged
merged 2 commits into from Sep 23, 2019

Conversation

@estebank
Copy link
Contributor

commented Sep 21, 2019

Fix #33575, fix #44504.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 21, 2019

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2019

cc @eddyb

src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/coercion.rs Outdated Show resolved Hide resolved
src/test/ui/issues/issue-33575.rs Outdated Show resolved Hide resolved
@Centril

This comment has been minimized.

Copy link
Member

commented Sep 21, 2019

r=me with comments addressed (if you want).

@estebank

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2019

@bors r=Centril

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2019

📌 Commit daed674 has been approved by Centril

@Centril

This comment has been minimized.

Copy link
Member

commented Sep 22, 2019

Centril added a commit to Centril/rust that referenced this pull request Sep 22, 2019
…tril

Propagate `types.err` in locals further to avoid spurious knock-down errors

Fix rust-lang#33575, fix rust-lang#44504.
bors added a commit that referenced this pull request Sep 22, 2019
Rollup of 9 pull requests

Successful merges:

 - #64158 (panic=abort support in libtest)
 - #64294 (Fix `Stdio::piped` example code and lint)
 - #64508 (or-patterns: Push `PatKind/PatternKind::Or` at top level to HIR & HAIR)
 - #64546 (Bugfix/rfc 2451 rerebalance tests)
 - #64670 (Cleanup syntax::ext::build)
 - #64674 (Propagate `types.err` in locals further to avoid spurious knock-down errors)
 - #64676 (Parse assoc type bounds in generic params and provide custom diagnostic)
 - #64677 (remove outdated comment)
 - #64679 (Infer consts more consistently)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 22, 2019
…tril

Propagate `types.err` in locals further to avoid spurious knock-down errors

Fix rust-lang#33575, fix rust-lang#44504.
bors added a commit that referenced this pull request Sep 23, 2019
Rollup of 7 pull requests

Successful merges:

 - #64294 (Fix `Stdio::piped` example code and lint)
 - #64670 (Cleanup syntax::ext::build)
 - #64674 (Propagate `types.err` in locals further to avoid spurious knock-down errors)
 - #64676 (Parse assoc type bounds in generic params and provide custom diagnostic)
 - #64677 (remove outdated comment)
 - #64679 (Infer consts more consistently)
 - #64688 (Clarify the "since" tidy check)

Failed merges:

r? @ghost
@bors bors merged commit daed674 into rust-lang:master Sep 23, 2019
4 checks passed
4 checks passed
pr Build #20190922.3 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.