Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point at definition when misusing ADT #64691

Merged
merged 1 commit into from Sep 29, 2019

Conversation

@estebank
Copy link
Contributor

commented Sep 22, 2019

When given struct Foo(usize) and using it as Foo {} or Foo, point at Foo's definition in the error.

When given `struct Foo(usize)` and using it as `Foo {}` or `Foo`, point at
`Foo`'s definition in the error.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 22, 2019

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Copy link
Member

commented Sep 29, 2019

r? @Centril @bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

📌 Commit 2ae9016 has been approved by Centril

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

⌛️ Testing commit 2ae9016 with merge d0eff0b...

bors added a commit that referenced this pull request Sep 29, 2019
Point at definition when misusing ADT

When given `struct Foo(usize)` and using it as `Foo {}` or `Foo`, point at `Foo`'s definition in the error.
Centril added a commit to Centril/rust that referenced this pull request Sep 29, 2019
Point at definition when misusing ADT

When given `struct Foo(usize)` and using it as `Foo {}` or `Foo`, point at `Foo`'s definition in the error.
@Centril

This comment has been minimized.

Copy link
Member

commented Sep 29, 2019

@bors retry rolled up.

bors added a commit that referenced this pull request Sep 29, 2019
Rollup of 7 pull requests

Successful merges:

 - #64691 (Point at definition when misusing ADT)
 - #64735 (Add long error explanation for E0533)
 - #64825 (Point at enclosing match when expecting `()` in arm)
 - #64858 (Add support for relating slices in `super_relate_consts`)
 - #64894 (syntax: fix dropping of attribute on first param of non-method assocated fn)
 - #64896 (Remove legacy grammar)
 - #64898 (fixed typo)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 29, 2019
Point at definition when misusing ADT

When given `struct Foo(usize)` and using it as `Foo {}` or `Foo`, point at `Foo`'s definition in the error.
bors added a commit that referenced this pull request Sep 29, 2019
Rollup of 6 pull requests

Successful merges:

 - #64691 (Point at definition when misusing ADT)
 - #64735 (Add long error explanation for E0533)
 - #64825 (Point at enclosing match when expecting `()` in arm)
 - #64858 (Add support for relating slices in `super_relate_consts`)
 - #64894 (syntax: fix dropping of attribute on first param of non-method assocated fn)
 - #64898 (fixed typo)

Failed merges:

r? @ghost
@bors bors merged commit 2ae9016 into rust-lang:master Sep 29, 2019
4 of 5 checks passed
4 of 5 checks passed
homu Testing commit 2ae90165534f18aa5020ae84f5e3768e99139069 with merge d0eff0b2d4afd9dd13cdb59d7ee7ba61e9dbe394...
Details
pr Build #20190922.32 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.