Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double panic when printing query stack during an ICE #64799

Merged
merged 2 commits into from
Sep 29, 2019
Merged

Fix double panic when printing query stack during an ICE #64799

merged 2 commits into from
Sep 29, 2019

Commits on Sep 26, 2019

  1. Use existing Handler to print query stack 

    When the panic handler is run, the existing Handler may be in a weird
state if it was responsible for triggering the panic. By using a freshly
created Handler, we avoid trying to re-entrantly lock a HandlerInner,
which was causing a double panic on ICEs.
    @Aaron1011
    Aaron1011 committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    e9aa0e7 View commit details
    Browse the repository at this point in the history

  2. Add note about global state in try_print_query_stack

    @Aaron1011
    Aaron1011 committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    97906bc View commit details
    Browse the repository at this point in the history