Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rtpSpawn's parameters type(It's prototype has been updated in libc) #64818

Merged
merged 2 commits into from
Sep 28, 2019

Conversation

BaoshanPang
Copy link
Contributor

bpangWR and others added 2 commits September 25, 2019 20:10
update rtpSpawn's parameters type(It's prototype has been updated in …
@BaoshanPang
Copy link
Contributor Author

cc @n-salim

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2019
@alexcrichton
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Sep 26, 2019

📌 Commit c81d359 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2019
@BaoshanPang
Copy link
Contributor Author

@alexcrichton

Can this change be merged into beta branch too? We are going to make a rust release for vxWorks, and we want to choose one from nightly and beta depend on which one is more stable for us.

@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 26, 2019
@alexcrichton
Copy link
Member

Sure thing, I'll tag this as nominated. Anyone from @rust-lang/libs object to backporting this?

@sfackler
Copy link
Member

SGTM

@BaoshanPang
Copy link
Contributor Author

@alexcrichton

Thanks a lot.

Centril added a commit to Centril/rust that referenced this pull request Sep 27, 2019
update rtpSpawn's parameters type(It's prototype has been updated in libc)

r? @alexcrichton
Centril added a commit to Centril/rust that referenced this pull request Sep 27, 2019
update rtpSpawn's parameters type(It's prototype has been updated in libc)

r? @alexcrichton
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 28, 2019
update rtpSpawn's parameters type(It's prototype has been updated in libc)

r? @alexcrichton
bors added a commit that referenced this pull request Sep 28, 2019
Rollup of 14 pull requests

Successful merges:

 - #63492 (Remove redundancy from the implementation of C variadics.)
 - #64703 (Docs: slice elements are equidistant)
 - #64745 (Include message on tests that should panic but do not)
 - #64781 (Remove stray references to the old global tcx)
 - #64794 (Remove unused DepTrackingMap)
 - #64802 (Account for tail expressions when pointing at return type)
 - #64809 (hir: Disallow `target_feature` on constants)
 - #64815 (Fix div_duration() marked as stable by mistake)
 - #64818 (update rtpSpawn's parameters type(It's prototype has been updated in libc))
 - #64830 (Thou shallt not `.abort_if_errors()`)
 - #64836 (Stabilize map_get_key_value feature)
 - #64845 (pin.rs: fix links to primitives in documentation)
 - #64847 (Upgrade env_logger to 0.7)
 - #64851 (Add mailmap entry for Dustin Bensing by request)

Failed merges:

 - #64824 (No StableHasherResult everywhere)

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 28, 2019
update rtpSpawn's parameters type(It's prototype has been updated in libc)

r? @alexcrichton
bors added a commit that referenced this pull request Sep 28, 2019
Rollup of 14 pull requests

Successful merges:

 - #64703 (Docs: slice elements are equidistant)
 - #64745 (Include message on tests that should panic but do not)
 - #64781 (Remove stray references to the old global tcx)
 - #64794 (Remove unused DepTrackingMap)
 - #64802 (Account for tail expressions when pointing at return type)
 - #64809 (hir: Disallow `target_feature` on constants)
 - #64815 (Fix div_duration() marked as stable by mistake)
 - #64818 (update rtpSpawn's parameters type(It's prototype has been updated in libc))
 - #64830 (Thou shallt not `.abort_if_errors()`)
 - #64836 (Stabilize map_get_key_value feature)
 - #64845 (pin.rs: fix links to primitives in documentation)
 - #64847 (Upgrade env_logger to 0.7)
 - #64851 (Add mailmap entry for Dustin Bensing by request)
 - #64859 (check_match: improve diagnostics for `let A = 2;` with `const A: i32 = 3`)

Failed merges:

r? @ghost
@bors bors merged commit c81d359 into rust-lang:master Sep 28, 2019
@tmandry tmandry mentioned this pull request Oct 2, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 2, 2019
[BETA] Backport changes

- update rtpSpawn's parameters type(It's prototype has been updated in libc) rust-lang#64818
- Fix div_duration() marked as stable by mistake rust-lang#64815
- Use https for curl when building for linux rust-lang#64786
- remove rtp.rs, and move rtpSpawn and RTP_ID_ERROR to libc rust-lang#64720

r? @ghost
@tmandry tmandry removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants