Improve sidebar styling to make its integration easier #64948
Conversation
|
Could you post some screenshots or something? |
|
It doesn't change the UI at all, that's point. However, by setting where is the bottom of the sidebar and removing its height, it prevents it from being bigger than the screen in the opposite of what you can see here. That's what I tried (badly) to explain in the first comment. ;) |
|
So presumably with this merged that page will no longer have hyper cut off at the bottom?
|
|
Absolutely. Update your CSS with my changes on your page if you want to check it live. :) |
|
That sounds like exactly what I wanted screenshots of. However, it looks like a correct and reasonable change based on just the CSS. So: @bors r+ |
|
📌 Commit 4aa526f has been approved by |
bors
added
the
S-waiting-on-bors
…ing, r=Mark-Simulacrum Improve sidebar styling to make its integration easier Part of rust-lang/docs.rs#417 Setting the height was an error: forcing the element bottom to be at the bottom allows to change to top of the sidebar. r? @Mark-Simulacrum
Rollup of 13 pull requests Successful merges: - #64581 (Fix unreachable_code warnings for try{} block ok-wrapped expressions) - #64850 (Remove inlines from DepNode code) - #64914 (regression test for 64453 borrow check error.) - #64922 (Use PlaceBuilder to avoid a lot of slice -> vec -> slice convertions) - #64948 (Improve sidebar styling to make its integration easier) - #64961 (Make comment about dummy type a bit more clear) - #64967 (Don't mark borrows of zero-sized arrays as indirectly mutable) - #64973 (Fix typo while setting `compile-flags` in test) - #64980 (Enable support for `IndirectlyMutableLocals` in `rustc_peek` ) - #64989 (Fix ICE #64964) - #64991 ([const-prop] Correctly handle locals that can't be propagated) - #64995 (Remove rustdoc warning) - #64997 (rustc book: nitpick SLP vectorization) Failed merges: r? @ghost
|
Oh I see what you mean. Well, the bug was specific to docs.rs so it didn't make sense to me to have a screenshot about a bug that doesn't impact rustdoc directly. |
Part of rust-lang/docs.rs#417
Setting the height was an error: forcing the element bottom to be at the bottom allows to change to top of the sidebar.
r? @Mark-Simulacrum