Compare primary with maximum of childrens' line num instead of dropping it
#65010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @estebank |
|
r=me, but can you verify locally that it is doing the right thing? We cannot test for this output sadly due to the line number anonymization we perform on all |
|
I'm sorry, I can't test it localy, rustc would take forever to build on my machine. However, now the code behaves just like before the commit, so functionality should be fixed. |
|
Confirmed locally. @bors r+ rollup |
|
📌 Commit df203a2 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 2, 2019
Compare `primary` with maximum of `children`s' line num instead of dropping it Fix rust-lang#65001.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 2, 2019
Compare `primary` with maximum of `children`s' line num instead of dropping it Fix rust-lang#65001.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 3, 2019
Compare `primary` with maximum of `children`s' line num instead of dropping it Fix rust-lang#65001.
bors
added a commit
that referenced
this pull request
Oct 3, 2019
Rollup of 7 pull requests Successful merges: - #63678 (Improve HRTB error span when -Zno-leak-check is used) - #64931 (Reword E0392 slightly) - #64959 (syntax: improve parameter without type suggestions) - #64975 (Implement Clone::clone_from for LinkedList) - #64993 (BacktraceStatus: add Eq impl) - #64998 (Filter out RLS output directories on tidy runs) - #65010 (Compare `primary` with maximum of `children`s' line num instead of dropping it) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #65001.