Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split libsyntax apart #65324

Merged
merged 3 commits into from Nov 10, 2019
Merged

Split libsyntax apart #65324

merged 3 commits into from Nov 10, 2019

Conversation

@Centril
Copy link
Member

Centril commented Oct 12, 2019

In this PR the general idea is to separate the AST, parser, and friends by a more data / logic structure (tho not fully realized!) by separating out the parser and macro expansion code from libsyntax. Specifically have now three crates instead of one (libsyntax):

  • libsyntax:

    • concrete syntax tree (syntax::ast)

    • definition of tokens and token-streams (syntax::{token, tokenstream}) -- used by syntax::ast

    • visitors (syntax::visit, syntax::mut_visit)

    • shared definitions between libsyntax_expand

    • feature gating (syntax::feature_gate) -- we could possibly move this out to its own crater later.

    • attribute and meta item utilities, including used-marking (syntax::attr)

    • pretty printer (syntax::print) -- this should possibly be moved out later. For now I've reduced down the dependencies to a single essential one which could be broken via ParseSess. This entails that e.g. Debug impls for Path cannot reference the pretty printer.

    • definition of ParseSess (syntax::sess) -- this is used by syntax::{attr, print, feature_gate} and is a common definition used by the parser and other things like librustc.

    • the syntax::source_map -- this includes definitions used by syntax::ast and other things but could ostensibly be moved syntax_pos since that is more related to this module.

    • a smattering of misc utilities not sufficiently important to itemize -- some of these could be moved to where they are used (often a single place) but I wanted to limit the scope of this PR.

  • librustc_parse:

    • parser (rustc_parse::parser) -- reading a file and such are defined in the crate root tho.

    • lexer (rustc_parse::lexer)

    • validation of meta grammar (post-expansion) in (rustc_parse::validate_attr)

  • libsyntax_expand -- this defines the infra for macro expansion and conditional compilation but this is not libsyntax_ext; we might want to merge them later but currently libsyntax_expand is depended on by librustc_metadata which libsyntax_ext is not.

    • conditional compilation (syntax_expand::config) -- moved from syntax::config to here

    • the bulk of this crate is made up of the old syntax::ext

r? @estebank

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Oct 12, 2019

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-12T04:22:46.0853686Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-12T04:22:46.0864154Z ##[command]git config gc.auto 0
2019-10-12T04:22:46.0865909Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-12T04:22:46.0868952Z ##[command]git config --get-all http.proxy
2019-10-12T04:22:46.0919222Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65324/merge:refs/remotes/pull/65324/merge
---
2019-10-12T04:29:19.4627227Z    Compiling rustc_macros v0.1.0 (/checkout/src/librustc_macros)
2019-10-12T04:29:27.1221309Z     Checking syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
2019-10-12T04:29:28.4260381Z     Checking rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-10-12T04:29:29.5546598Z     Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2019-10-12T04:29:37.4840879Z     Checking syntax_parse v0.0.0 (/checkout/src/libsyntax_parse)
2019-10-12T04:29:39.7066615Z error: the feature `mem_take` has been stable since 1.40.0 and no longer requires an attribute to enable
2019-10-12T04:29:39.7067082Z  --> src/libsyntax_parse/lib.rs:4:12
2019-10-12T04:29:39.7067589Z 4 | #![feature(mem_take)]
2019-10-12T04:29:39.7067870Z   |            ^^^^^^^^
2019-10-12T04:29:39.7068084Z   |
2019-10-12T04:29:39.7068362Z   = note: `-D stable-features` implied by `-D warnings`
---
2019-10-12T04:30:21.3618305Z == clock drift check ==
2019-10-12T04:30:21.3636228Z   local time: Sat Oct 12 04:30:21 UTC 2019
2019-10-12T04:30:21.6347635Z   network time: Sat, 12 Oct 2019 04:30:21 GMT
2019-10-12T04:30:21.6350972Z == end clock drift check ==
2019-10-12T04:30:22.2002282Z ##[error]Bash exited with code '1'.
2019-10-12T04:30:22.2049169Z ##[section]Starting: Checkout
2019-10-12T04:30:22.2050819Z ==============================================================================
2019-10-12T04:30:22.2050881Z Task         : Get sources
2019-10-12T04:30:22.2050917Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Oct 12, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-12T04:44:06.0303899Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-12T04:44:06.0837767Z ##[command]git config gc.auto 0
2019-10-12T04:44:06.0923074Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-12T04:44:06.0999483Z ##[command]git config --get-all http.proxy
2019-10-12T04:44:06.1165522Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65324/merge:refs/remotes/pull/65324/merge
---
2019-10-12T04:54:15.3092832Z    Compiling rustc_macros v0.1.0 (/checkout/src/librustc_macros)
2019-10-12T04:54:24.1981536Z    Compiling syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
2019-10-12T04:54:25.6640890Z    Compiling rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-10-12T04:54:43.2447730Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2019-10-12T04:55:30.3477121Z    Compiling syntax_parse v0.0.0 (/checkout/src/libsyntax_parse)
2019-10-12T04:56:16.6751237Z    Compiling syntax_macros v0.0.0 (/checkout/src/libsyntax_macros)
2019-10-12T05:01:25.0794726Z    Compiling rustc_passes v0.0.0 (/checkout/src/librustc_passes)
2019-10-12T05:02:13.4377011Z    Compiling rustc_traits v0.0.0 (/checkout/src/librustc_traits)
2019-10-12T05:03:27.3904405Z    Compiling rustc_mir v0.0.0 (/checkout/src/librustc_mir)
2019-10-12T05:06:07.3571582Z    Compiling rustc_lint v0.0.0 (/checkout/src/librustc_lint)
---
2019-10-12T05:18:23.4662952Z    Compiling rustc_macros v0.1.0 (/checkout/src/librustc_macros)
2019-10-12T05:18:34.5688535Z    Compiling syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
2019-10-12T05:18:42.8419767Z    Compiling rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-10-12T05:19:04.9346951Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2019-10-12T05:20:00.9353266Z    Compiling syntax_parse v0.0.0 (/checkout/src/libsyntax_parse)
2019-10-12T05:20:56.9292581Z    Compiling syntax_macros v0.0.0 (/checkout/src/libsyntax_macros)
2019-10-12T05:27:17.6192804Z    Compiling rustc_mir v0.0.0 (/checkout/src/librustc_mir)
2019-10-12T05:32:19.2097910Z    Compiling rustc_traits v0.0.0 (/checkout/src/librustc_traits)
2019-10-12T05:33:47.5775653Z    Compiling rustc_passes v0.0.0 (/checkout/src/librustc_passes)
2019-10-12T05:34:42.9859324Z    Compiling rustc_lint v0.0.0 (/checkout/src/librustc_lint)
---
2019-10-12T05:46:51.6721256Z .................................................................................................... 1600/9146
2019-10-12T05:46:59.3010257Z .................................................................................................... 1700/9146
2019-10-12T05:47:10.6851014Z .................i...............i.................................................................. 1800/9146
2019-10-12T05:47:17.8947153Z .................................................................................................... 1900/9146
2019-10-12T05:47:33.4645404Z ........iiiii....................................................................................... 2000/9146
2019-10-12T05:47:43.4082509Z .................................................................................................... 2200/9146
2019-10-12T05:47:46.0841691Z .................................................................................................... 2300/9146
2019-10-12T05:47:51.8638442Z .................................................................................................... 2400/9146
2019-10-12T05:47:58.1234716Z .................................................................................................... 2500/9146
---
2019-10-12T05:50:53.7566262Z .................................................................................................... 4700/9146
2019-10-12T05:51:01.1885436Z .i...............i.................................................................................. 4800/9146
2019-10-12T05:51:12.4631232Z .................................................................................................... 4900/9146
2019-10-12T05:51:18.1209451Z .................................................................................................... 5000/9146
2019-10-12T05:51:29.4705898Z ...............................................................................................ii.ii 5100/9146
2019-10-12T05:51:40.1096585Z .................................................................................................... 5300/9146
2019-10-12T05:51:50.1899438Z .................................................................................................... 5400/9146
2019-10-12T05:51:57.1266210Z .............................................................i...................................... 5500/9146
2019-10-12T05:52:04.5613024Z .................................................................................................... 5600/9146
2019-10-12T05:52:04.5613024Z .................................................................................................... 5600/9146
2019-10-12T05:52:12.0760212Z .................................................................................................... 5700/9146
2019-10-12T05:52:22.3829173Z ..........................................................ii...i..ii...........i.................... 5800/9146
2019-10-12T05:52:48.5723776Z .................................................................................................... 6000/9146
2019-10-12T05:52:57.9103167Z .................................................................................................... 6100/9146
2019-10-12T05:52:57.9103167Z .................................................................................................... 6100/9146
2019-10-12T05:53:05.4315516Z ................................................................i..ii............................... 6200/9146
2019-10-12T05:53:34.8290724Z .................................................................................................... 6400/9146
2019-10-12T05:53:36.9806623Z ........................i........................................................................... 6500/9146
2019-10-12T05:53:39.2261736Z .................................................................................................i.. 6600/9146
2019-10-12T05:53:42.0052052Z .................................................................................................... 6700/9146
---
2019-10-12T05:58:24.5814268Z  finished in 5.667
2019-10-12T05:58:24.6003418Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-12T05:58:24.7672229Z 
2019-10-12T05:58:24.7672375Z running 153 tests
2019-10-12T05:58:28.0776614Z i....iii......iii..iiii....i..............................i.i..................i....i............ii. 100/153
2019-10-12T05:58:30.0916049Z i.i..iiii..............i.........iii.i.......ii......
2019-10-12T05:58:30.0916779Z 
2019-10-12T05:58:30.0921705Z  finished in 5.492
2019-10-12T05:58:30.1108358Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-12T05:58:30.2836029Z 
---
2019-10-12T05:58:32.3745850Z  finished in 2.263
2019-10-12T05:58:32.3924548Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-12T05:58:32.5533852Z 
2019-10-12T05:58:32.5534694Z running 9 tests
2019-10-12T05:58:32.5535650Z iiiiiiiii
2019-10-12T05:58:32.5536197Z 
2019-10-12T05:58:32.5536250Z  finished in 0.160
2019-10-12T05:58:32.5738961Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-12T05:58:32.7568723Z 
---
2019-10-12T05:58:51.1540312Z  finished in 18.578
2019-10-12T05:58:51.1760236Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-12T05:58:51.3484851Z 
2019-10-12T05:58:51.3485199Z running 123 tests
2019-10-12T05:59:16.6716391Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-12T05:59:21.5657807Z i.i.i......iii.i.....ii
2019-10-12T05:59:21.5661064Z 
2019-10-12T05:59:21.5662333Z  finished in 30.390
2019-10-12T05:59:21.5671270Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-12T05:59:21.5673920Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2019-10-12T05:59:21.5673920Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2019-10-12T05:59:21.5884861Z Check compiletest suite=ui-fulldeps mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-12T05:59:21.7508370Z 
2019-10-12T05:59:21.7511081Z running 69 tests
2019-10-12T05:59:47.1059873Z F............F....................................F...FFFFFFF..F.....
2019-10-12T05:59:47.1092998Z 
2019-10-12T05:59:47.1093727Z ---- [ui] ui-fulldeps/ast_stmt_expr_attr.rs stdout ----
2019-10-12T05:59:47.1104355Z 
2019-10-12T05:59:47.1105218Z error: test compilation failed although it shouldn't!
2019-10-12T05:59:47.1105218Z error: test compilation failed although it shouldn't!
2019-10-12T05:59:47.1105557Z status: exit code: 1
2019-10-12T05:59:47.1106543Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/ast_stmt_expr_attr.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/ast_stmt_expr_attr/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/ast_stmt_expr_attr/auxiliary"
2019-10-12T05:59:47.1107619Z ------------------------------------------
2019-10-12T05:59:47.1107755Z 
2019-10-12T05:59:47.1108025Z ------------------------------------------
2019-10-12T05:59:47.1109267Z stderr:
---
2019-10-12T05:59:47.1110505Z 
2019-10-12T05:59:47.1110568Z error[E0432]: unresolved import `syntax::parse`
2019-10-12T05:59:47.1111406Z   --> /checkout/src/test/ui-fulldeps/ast_stmt_expr_attr.rs:15:13
2019-10-12T05:59:47.1111471Z    |
2019-10-12T05:59:47.1111542Z LL | use syntax::parse::{ParseSess, PResult};
2019-10-12T05:59:47.1111794Z    |             ^^^^^ could not find `parse` in `syntax`
2019-10-12T05:59:47.1111892Z error[E0433]: failed to resolve: could not find `parse` in `syntax`
2019-10-12T05:59:47.1112463Z   --> /checkout/src/test/ui-fulldeps/ast_stmt_expr_attr.rs:17:13
2019-10-12T05:59:47.1112513Z    |
2019-10-12T05:59:47.1112585Z LL | use syntax::parse::parser::Parser;
---
2019-10-12T05:59:47.1114275Z 
2019-10-12T05:59:47.1114334Z error[E0412]: cannot find type `Parser` in this scope
2019-10-12T05:59:47.1114582Z   --> /checkout/src/test/ui-fulldeps/ast_stmt_expr_attr.rs:26:71
2019-10-12T05:59:47.1114629Z    |
2019-10-12T05:59:47.1114904Z LL | pub fn string_to_parser<'a>(ps: &'a ParseSess, source_str: String) -> Parser<'a> {
2019-10-12T05:59:47.1115019Z 
2019-10-12T05:59:47.1115063Z error[E0412]: cannot find type `Parser` in this scope
2019-10-12T05:59:47.1115329Z   --> /checkout/src/test/ui-fulldeps/ast_stmt_expr_attr.rs:31:20
2019-10-12T05:59:47.1115385Z    |
2019-10-12T05:59:47.1115385Z    |
2019-10-12T05:59:47.1115617Z LL |     F: FnOnce(&mut Parser<'a>) -> PResult<'a, T>,
2019-10-12T05:59:47.1115716Z 
2019-10-12T05:59:47.1115757Z error: aborting due to 8 previous errors
2019-10-12T05:59:47.1115785Z 
2019-10-12T05:59:47.1115846Z Some errors have detailed explanations: E0412, E0432, E0433.
2019-10-12T05:59:47.1115846Z Some errors have detailed explanations: E0412, E0432, E0433.
2019-10-12T05:59:47.1116092Z For more information about an error, try `rustc --explain E0412`.
2019-10-12T05:59:47.1116126Z 
2019-10-12T05:59:47.1116355Z ------------------------------------------
2019-10-12T05:59:47.1116387Z 
2019-10-12T05:59:47.1116411Z 
2019-10-12T05:59:47.1116634Z ---- [ui] ui-fulldeps/gated-plugin.rs stdout ----
2019-10-12T05:59:47.1116667Z 
2019-10-12T05:59:47.1116963Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-12T05:59:47.1117025Z status: exit code: 1
2019-10-12T05:59:47.1117784Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/auxiliary"
2019-10-12T05:59:47.1118115Z ------------------------------------------
2019-10-12T05:59:47.1118169Z 
2019-10-12T05:59:47.1118398Z ------------------------------------------
2019-10-12T05:59:47.1118444Z stderr:
2019-10-12T05:59:47.1118444Z stderr:
2019-10-12T05:59:47.1118809Z ------------------------------------------
2019-10-12T05:59:47.1118863Z error[E0432]: unresolved import `syntax::ext::base::SyntaxExtension`
2019-10-12T05:59:47.1119132Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:10:5
2019-10-12T05:59:47.1119203Z    |
2019-10-12T05:59:47.1119246Z LL | use syntax::ext::base::SyntaxExtension;
2019-10-12T05:59:47.1119296Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `SyntaxExtension` in `ext::base`
2019-10-12T05:59:47.1119327Z 
2019-10-12T05:59:47.1119801Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-12T05:59:47.1120081Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:14:1
2019-10-12T05:59:47.1120188Z LL | #[plugin_registrar]
2019-10-12T05:59:47.1120235Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-12T05:59:47.1120293Z    |
2019-10-12T05:59:47.1120336Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-12T05:59:47.1121724Z ---- [ui] ui-fulldeps/mod_dir_path_canonicalized.rs stdout ----
2019-10-12T05:59:47.1121757Z 
2019-10-12T05:59:47.1121998Z error: test compilation failed although it shouldn't!
2019-10-12T05:59:47.1122047Z status: exit code: 1
2019-10-12T05:59:47.1122799Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/mod_dir_path_canonicalized.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/mod_dir_path_canonicalized/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/mod_dir_path_canonicalized/auxiliary"
2019-10-12T05:59:47.1123157Z ------------------------------------------
2019-10-12T05:59:47.1123190Z 
2019-10-12T05:59:47.1123435Z ------------------------------------------
2019-10-12T05:59:47.1123481Z stderr:
2019-10-12T05:59:47.1123481Z stderr:
2019-10-12T05:59:47.1123693Z ------------------------------------------
2019-10-12T05:59:47.1123764Z error[E0432]: unresolved imports `syntax::parse`, `syntax::parse`
2019-10-12T05:59:47.1124071Z    |
2019-10-12T05:59:47.1124071Z    |
2019-10-12T05:59:47.1124131Z LL | use syntax::parse::{self, ParseSess};
2019-10-12T05:59:47.1124177Z    |             ^^^^^   ^^^^ no `parse` in the root
2019-10-12T05:59:47.1124283Z    |             could not find `parse` in `syntax`
2019-10-12T05:59:47.1124323Z 
2019-10-12T05:59:47.1124364Z error: aborting due to previous error
2019-10-12T05:59:47.1124392Z 
2019-10-12T05:59:47.1124392Z 
2019-10-12T05:59:47.1124848Z For more information about this error, try `rustc --explain E0432`.
2019-10-12T05:59:47.1124889Z 
2019-10-12T05:59:47.1125145Z ------------------------------------------
2019-10-12T05:59:47.1125178Z 
2019-10-12T05:59:47.1125203Z 
2019-10-12T05:59:47.1125445Z ---- [ui] ui-fulldeps/plugin-args-1.rs stdout ----
2019-10-12T05:59:47.1125478Z 
2019-10-12T05:59:47.1126140Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-10-12T05:59:47.1126227Z status: exit code: 1
2019-10-12T05:59:47.1126996Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-1/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-1/auxiliary"
2019-10-12T05:59:47.1127549Z ------------------------------------------
2019-10-12T05:59:47.1127584Z 
2019-10-12T05:59:47.1127822Z ------------------------------------------
2019-10-12T05:59:47.1127868Z stderr:
2019-10-12T05:59:47.1127868Z stderr:
2019-10-12T05:59:47.1128079Z ------------------------------------------
2019-10-12T05:59:47.1128153Z error[E0432]: unresolved imports `syntax::ext::base::SyntaxExtension`, `syntax::ext::base::SyntaxExtensionKind`
2019-10-12T05:59:47.1128411Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:13:25
2019-10-12T05:59:47.1128461Z    |
2019-10-12T05:59:47.1128524Z LL | use syntax::ext::base::{SyntaxExtension, SyntaxExtensionKind};
2019-10-12T05:59:47.1128591Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^ no `SyntaxExtensionKind` in `ext::base`
2019-10-12T05:59:47.1128639Z    |                         |
2019-10-12T05:59:47.1128796Z    |                         no `SyntaxExtension` in `ext::base`
2019-10-12T05:59:47.1128835Z 
2019-10-12T05:59:47.1128893Z error[E0432]: unresolved imports `syntax::ext::base::TTMacroExpander`, `syntax::ext::base::ExtCtxt`, `syntax::ext::base::MacResult`, `syntax::ext::base::MacEager`
2019-10-12T05:59:47.1129204Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:14:25
2019-10-12T05:59:47.1129256Z    |
2019-10-12T05:59:47.1129303Z LL | use syntax::ext::base::{TTMacroExpander, ExtCtxt, MacResult, MacEager};
2019-10-12T05:59:47.1129376Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^  ^^^^^^^^ no `MacEager` in `ext::base`
2019-10-12T05:59:47.1129479Z    |                         |                |        no `MacResult` in `ext::base`
2019-10-12T05:59:47.1129557Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-12T05:59:47.1129557Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-12T05:59:47.1129614Z    |                         no `TTMacroExpander` in `ext::base`
2019-10-12T05:59:47.1129644Z 
2019-10-12T05:59:47.1130033Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-12T05:59:47.1130306Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:36:1
2019-10-12T05:59:47.1130413Z LL | #[plugin_registrar]
2019-10-12T05:59:47.1130457Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-12T05:59:47.1130498Z    |
2019-10-12T05:59:47.1130542Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-12T05:59:47.1132008Z 
2019-10-12T05:59:47.1132033Z 
2019-10-12T05:59:47.1132283Z ---- [ui] ui-fulldeps/plugin-args-2.rs stdout ----
2019-10-12T05:59:47.1132317Z 
2019-10-12T05:59:47.1132593Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-10-12T05:59:47.1132648Z status: exit code: 1
2019-10-12T05:59:47.1133408Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-2/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-2/auxiliary"
2019-10-12T05:59:47.1133934Z ------------------------------------------
2019-10-12T05:59:47.1133968Z 
2019-10-12T05:59:47.1134197Z ------------------------------------------
2019-10-12T05:59:47.1134260Z stderr:
2019-10-12T05:59:47.1134260Z stderr:
2019-10-12T05:59:47.1134474Z ------------------------------------------
2019-10-12T05:59:47.1134532Z error[E0432]: unresolved imports `syntax::ext::base::SyntaxExtension`, `syntax::ext::base::SyntaxExtensionKind`
2019-10-12T05:59:47.1135085Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:13:25
2019-10-12T05:59:47.1135145Z    |
2019-10-12T05:59:47.1135191Z LL | use syntax::ext::base::{SyntaxExtension, SyntaxExtensionKind};
2019-10-12T05:59:47.1135267Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^ no `SyntaxExtensionKind` in `ext::base`
2019-10-12T05:59:47.1135316Z    |                         |
2019-10-12T05:59:47.1135364Z    |                         no `SyntaxExtension` in `ext::base`
2019-10-12T05:59:47.1135421Z 
2019-10-12T05:59:47.1135592Z error[E0432]: unresolved imports `syntax::ext::base::TTMacroExpander`, `syntax::ext::base::ExtCtxt`, `syntax::ext::base::MacResult`, `syntax::ext::base::MacEager`
2019-10-12T05:59:47.1135905Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:14:25
2019-10-12T05:59:47.1135977Z    |
2019-10-12T05:59:47.1136024Z LL | use syntax::ext::base::{TTMacroExpander, ExtCtxt, MacResult, MacEager};
2019-10-12T05:59:47.1136080Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^  ^^^^^^^^ no `MacEager` in `ext::base`
2019-10-12T05:59:47.1136197Z    |                         |                |        no `MacResult` in `ext::base`
2019-10-12T05:59:47.1136249Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-12T05:59:47.1136249Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-12T05:59:47.1136315Z    |                         no `TTMacroExpander` in `ext::base`
2019-10-12T05:59:47.1136345Z 
2019-10-12T05:59:47.1136732Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-12T05:59:47.1137028Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:36:1
2019-10-12T05:59:47.1137118Z LL | #[plugin_registrar]
2019-10-12T05:59:47.1137179Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-12T05:59:47.1137221Z    |
2019-10-12T05:59:47.1137265Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-12T05:59:47.1137920Z 
2019-10-12T05:59:47.1137945Z 
2019-10-12T05:59:47.1138169Z ---- [ui] ui-fulldeps/plugin-args-3.rs stdout ----
2019-10-12T05:59:47.1138218Z 
2019-10-12T05:59:47.1138503Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-10-12T05:59:47.1138556Z status: exit code: 1
2019-10-12T05:59:47.1139318Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-3/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-3/auxiliary"
2019-10-12T05:59:47.1139644Z ------------------------------------------
2019-10-12T05:59:47.1139680Z 
2019-10-12T05:59:47.1139897Z ------------------------------------------
2019-10-12T05:59:47.1140057Z stderr:
2019-10-12T05:59:47.1140057Z stderr:
2019-10-12T05:59:47.1140321Z ------------------------------------------
2019-10-12T05:59:47.1140389Z error[E0432]: unresolved imports `syntax::ext::base::SyntaxExtension`, `syntax::ext::base::SyntaxExtensionKind`
2019-10-12T05:59:47.1140648Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:13:25
2019-10-12T05:59:47.1140722Z    |
2019-10-12T05:59:47.1140768Z LL | use syntax::ext::base::{SyntaxExtension, SyntaxExtensionKind};
2019-10-12T05:59:47.1140823Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^ no `SyntaxExtensionKind` in `ext::base`
2019-10-12T05:59:47.1141115Z    |                         |
2019-10-12T05:59:47.1141165Z    |                         no `SyntaxExtension` in `ext::base`
2019-10-12T05:59:47.1141195Z 
2019-10-12T05:59:47.1141270Z error[E0432]: unresolved imports `syntax::ext::base::TTMacroExpander`, `syntax::ext::base::ExtCtxt`, `syntax::ext::base::MacResult`, `syntax::ext::base::MacEager`
2019-10-12T05:59:47.1141598Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:14:25
2019-10-12T05:59:47.1141663Z    |
2019-10-12T05:59:47.1141728Z LL | use syntax::ext::base::{TTMacroExpander, ExtCtxt, MacResult, MacEager};
2019-10-12T05:59:47.1141909Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^  ^^^^^^^^ no `MacEager` in `ext::base`
2019-10-12T05:59:47.1142040Z    |                         |                |        no `MacResult` in `ext::base`
2019-10-12T05:59:47.1142092Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-12T05:59:47.1142092Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-12T05:59:47.1142142Z    |                         no `TTMacroExpander` in `ext::base`
2019-10-12T05:59:47.1142190Z 
2019-10-12T05:59:47.1142589Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-12T05:59:47.1142858Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:36:1
2019-10-12T05:59:47.1142977Z LL | #[plugin_registrar]
2019-10-12T05:59:47.1143022Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-12T05:59:47.1143081Z    |
2019-10-12T05:59:47.1143132Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-12T05:59:47.1143791Z 
2019-10-12T05:59:47.1143816Z 
2019-10-12T05:59:47.1144048Z ---- [ui] ui-fulldeps/plugin-as-extern-crate.rs stdout ----
2019-10-12T05:59:47.1144082Z 
2019-10-12T05:59:47.1144371Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-12T05:59:47.1144425Z status: exit code: 1
2019-10-12T05:59:47.1145193Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-as-extern-crate/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-as-extern-crate/auxiliary"
2019-10-12T05:59:47.1145532Z ------------------------------------------
2019-10-12T05:59:47.1145583Z 
2019-10-12T05:59:47.1145803Z ------------------------------------------
2019-10-12T05:59:47.1145850Z stderr:
2019-10-12T05:59:47.1145850Z stderr:
2019-10-12T05:59:47.1146060Z ------------------------------------------
2019-10-12T05:59:47.1146129Z error[E0432]: unresolved import `syntax::ext::base::SyntaxExtension`
2019-10-12T05:59:47.1146386Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:10:5
2019-10-12T05:59:47.1146565Z    |
2019-10-12T05:59:47.1146609Z LL | use syntax::ext::base::SyntaxExtension;
2019-10-12T05:59:47.1146669Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `SyntaxExtension` in `ext::base`
2019-10-12T05:59:47.1146700Z 
2019-10-12T05:59:47.1147098Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-12T05:59:47.1147372Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:14:1
2019-10-12T05:59:47.1147480Z LL | #[plugin_registrar]
2019-10-12T05:59:47.1147524Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-12T05:59:47.1147582Z    |
2019-10-12T05:59:47.1147626Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-12T05:59:47.1148283Z 
2019-10-12T05:59:47.1148325Z 
2019-10-12T05:59:47.1148647Z ---- [ui] ui-fulldeps/plugin-attr-register-deny.rs stdout ----
2019-10-12T05:59:47.1148689Z 
2019-10-12T05:59:47.1148995Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-12T05:59:47.1149068Z status: exit code: 1
2019-10-12T05:59:47.1149834Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny/auxiliary"
2019-10-12T05:59:47.1150194Z ------------------------------------------
2019-10-12T05:59:47.1150229Z 
2019-10-12T05:59:47.1150472Z ------------------------------------------
2019-10-12T05:59:47.1150519Z stderr:
2019-10-12T05:59:47.1150519Z stderr:
2019-10-12T05:59:47.1150731Z ------------------------------------------
2019-10-12T05:59:47.1150799Z error[E0432]: unresolved import `syntax::ext::base::SyntaxExtension`
2019-10-12T05:59:47.1151349Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:10:5
2019-10-12T05:59:47.1151408Z    |
2019-10-12T05:59:47.1151473Z LL | use syntax::ext::base::SyntaxExtension;
2019-10-12T05:59:47.1151523Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `SyntaxExtension` in `ext::base`
2019-10-12T05:59:47.1151554Z 
2019-10-12T05:59:47.1151926Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-12T05:59:47.1152218Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:14:1
2019-10-12T05:59:47.1152327Z LL | #[plugin_registrar]
2019-10-12T05:59:47.1152382Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-12T05:59:47.1152423Z    |
2019-10-12T05:59:47.1152485Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-12T05:59:47.1153134Z 
2019-10-12T05:59:47.1153175Z 
2019-10-12T05:59:47.1153398Z ---- [ui] ui-fulldeps/plugin-reexport.rs stdout ----
2019-10-12T05:59:47.1153429Z 
2019-10-12T05:59:47.1153703Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-12T05:59:47.1153922Z status: exit code: 1
2019-10-12T05:59:47.1154714Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-reexport/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-reexport/auxiliary"
2019-10-12T05:59:47.1155050Z ------------------------------------------
2019-10-12T05:59:47.1155087Z 
2019-10-12T05:59:47.1155321Z ------------------------------------------
2019-10-12T05:59:47.1155368Z stderr:
2019-10-12T05:59:47.1155368Z stderr:
2019-10-12T05:59:47.1155580Z ------------------------------------------
2019-10-12T05:59:47.1155648Z error[E0432]: unresolved import `syntax::ext::base::SyntaxExtension`
2019-10-12T05:59:47.1155914Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:10:5
2019-10-12T05:59:47.1155965Z    |
2019-10-12T05:59:47.1156108Z LL | use syntax::ext::base::SyntaxExtension;
2019-10-12T05:59:47.1156167Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `SyntaxExtension` in `ext::base`
2019-10-12T05:59:47.1156198Z 
2019-10-12T05:59:47.1156600Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-12T05:59:47.1156876Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:14:1
2019-10-12T05:59:47.1156983Z LL | #[plugin_registrar]
2019-10-12T05:59:47.1157027Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-12T05:59:47.1157070Z    |
2019-10-12T05:59:47.1157130Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-12T05:59:47.1158067Z ---- [ui] ui-fulldeps/pprust-expr-roundtrip.rs stdout ----
2019-10-12T05:59:47.1158101Z 
2019-10-12T05:59:47.1158325Z error: test compilation failed although it shouldn't!
2019-10-12T05:59:47.1158373Z status: exit code: 1
2019-10-12T05:59:47.1159108Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/pprust-expr-roundtrip.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip/auxiliary"
2019-10-12T05:59:47.1159449Z ------------------------------------------
2019-10-12T05:59:47.1159484Z 
2019-10-12T05:59:47.1159701Z ------------------------------------------
2019-10-12T05:59:47.1159763Z stderr:
2019-10-12T05:59:47.1159763Z stderr:
2019-10-12T05:59:47.1159977Z ------------------------------------------
2019-10-12T05:59:47.1160029Z error[E0432]: unresolved imports `syntax::parse`, `syntax::parse`
2019-10-12T05:59:47.1160344Z    |
2019-10-12T05:59:47.1160344Z    |
2019-10-12T05:59:47.1160387Z LL | use syntax::parse::{self, ParseSess};
2019-10-12T05:59:47.1160451Z    |             ^^^^^   ^^^^ no `parse` in the root
2019-10-12T05:59:47.1160540Z    |             could not find `parse` in `syntax`
2019-10-12T05:59:47.1160568Z 
2019-10-12T05:59:47.1160626Z error: aborting due to previous error
2019-10-12T05:59:47.1160761Z 
2019-10-12T05:59:47.1160761Z 
2019-10-12T05:59:47.1161302Z For more information about this error, try `rustc --explain E0432`.
2019-10-12T05:59:47.1161344Z 
2019-10-12T05:59:47.1161599Z ------------------------------------------
2019-10-12T05:59:47.1161631Z 
2019-10-12T05:59:47.1161655Z 
2019-10-12T05:59:47.1161889Z ---- [ui] ui-fulldeps/roman-numerals-macro.rs stdout ----
2019-10-12T05:59:47.1161939Z 
2019-10-12T05:59:47.1162215Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs" failed to compile: 
2019-10-12T05:59:47.1162271Z status: exit code: 1
2019-10-12T05:59:47.1163172Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/roman-numerals-macro/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/roman-numerals-macro/auxiliary"
2019-10-12T05:59:47.1163559Z ------------------------------------------
2019-10-12T05:59:47.1163594Z 
2019-10-12T05:59:47.1163810Z ------------------------------------------
2019-10-12T05:59:47.1163875Z stderr:
2019-10-12T05:59:47.1163875Z stderr:
2019-10-12T05:59:47.1164090Z ------------------------------------------
2019-10-12T05:59:47.1164143Z error[E0433]: failed to resolve: could not find `parse` in `syntax`
2019-10-12T05:59:47.1164416Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:17:13
2019-10-12T05:59:47.1164469Z    |
2019-10-12T05:59:47.1164512Z LL | use syntax::parse::token::{self, Token};
2019-10-12T05:59:47.1164559Z    |             ^^^^^ could not find `parse` in `syntax`
2019-10-12T05:59:47.1164649Z error[E0432]: unresolved import `syntax::parse`
2019-10-12T05:59:47.1164915Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:17:13
2019-10-12T05:59:47.1164980Z    |
2019-10-12T05:59:47.1164980Z    |
2019-10-12T05:59:47.1165031Z LL | use syntax::parse::token::{self, Token};
2019-10-12T05:59:47.1165078Z    |             ^^^^^ could not find `parse` in `syntax`
2019-10-12T05:59:47.1165107Z 
2019-10-12T05:59:47.1165179Z error[E0432]: unresolved imports `syntax::ext::base::ExtCtxt`, `syntax::ext::base::MacResult`, `syntax::ext::base::DummyResult`, `syntax::ext::base::MacEager`
2019-10-12T05:59:47.1165444Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:19:25
2019-10-12T05:59:47.1165585Z    |
2019-10-12T05:59:47.1166891Z LL | use syntax::ext::base::{ExtCtxt, MacResult, DummyResult, MacEager};
2019-10-12T05:59:47.1166964Z    |                         ^^^^^^^  ^^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^ no `MacEager` in `ext::base`
2019-10-12T05:59:47.1167088Z    |                         |        |          no `DummyResult` in `ext::base`
2019-10-12T05:59:47.1167150Z    |                         |        no `MacResult` in `ext::base`
2019-10-12T05:59:47.1167223Z    |                         no `ExtCtxt` in `ext::base`
2019-10-12T05:59:47.1167253Z 
2019-10-12T05:59:47.1167253Z 
2019-10-12T05:59:47.1167299Z error[E0422]: cannot find struct, variant or union type `Token` in this scope
2019-10-12T05:59:47.1167664Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:40:26
2019-10-12T05:59:47.1167736Z    |
2019-10-12T05:59:47.1167783Z LL |         TokenTree::Token(Token { kind: token::Ident(s, _), .. }) => s.to_string(),
2019-10-12T05:59:47.1167906Z help: possible candidates are found in other modules, you can import them into scope
2019-10-12T05:59:47.1167951Z    |
2019-10-12T05:59:47.1167992Z LL | use syntax::token::Token;
2019-10-12T05:59:47.1168052Z    |
2019-10-12T05:59:47.1168052Z    |
2019-10-12T05:59:47.1168094Z LL | use syntax::tokenstream::TokenTree::Token;
2019-10-12T05:59:47.1168303Z    |
2019-10-12T05:59:47.1168328Z 
2019-10-12T05:59:47.1168761Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-12T05:59:47.1169042Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:65:1
2019-10-12T05:59:47.1169148Z LL | #[plugin_registrar]
2019-10-12T05:59:47.1169194Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-12T05:59:47.1169255Z    |
2019-10-12T05:59:47.1169299Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-12T05:59:47.1178161Z test result: FAILED. 58 passed; 11 failed; 0 ignored; 0 measured; 0 filtered out
2019-10-12T05:59:47.1178235Z 
2019-10-12T05:59:47.1178261Z 
2019-10-12T05:59:47.1178285Z 
2019-10-12T05:59:47.1179962Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-10-12T05:59:47.1180224Z 
2019-10-12T05:59:47.1180252Z 
2019-10-12T05:59:47.1180299Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-10-12T05:59:47.1180371Z Build completed unsuccessfully in 1:08:39
2019-10-12T05:59:47.1180371Z Build completed unsuccessfully in 1:08:39
2019-10-12T05:59:47.1180418Z == clock drift check ==
2019-10-12T05:59:47.1180722Z   local time: thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-10-12T05:59:47.1180803Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-10-12T05:59:47.1181331Z Sat Oct 12 05:59:47 UTC 2019
2019-10-12T05:59:47.2175501Z   network time: Sat, 12 Oct 2019 05:59:47 GMT
2019-10-12T05:59:47.2179556Z == end clock drift check ==
2019-10-12T05:59:48.1364629Z ##[error]Bash exited with code '1'.
2019-10-12T05:59:48.1420583Z ##[section]Starting: Checkout
2019-10-12T05:59:48.1422846Z ==============================================================================
2019-10-12T05:59:48.1422909Z Task         : Get sources
2019-10-12T05:59:48.1422961Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Oct 12, 2019

☔️ The latest upstream changes (presumably #65322) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Oct 12, 2019

👍 on the general direction.
Some comments from a quick review:

  • The PR is already too big, please try to wrap it up without adding extra changes, unless they are necessary for splitting the crates.
  • The previous point also applies to local changes (like "simplify maybe_stage_features"), which are not necessary for splitting the crates and can be done later in a separate PR.
  • Please avoid tiny modules (like libsyntax_ext/util.rs, libsyntax/util/classify.rs), their contents can be moved into their parent modules.
  • syntax_macros -> syntax_expand, the former looks like it contains macros used in libsyntax.
  • syntax::ext -> syntax::expand, merge its tiny nested modules like base.rs and proc_macro.rs into it.
  • Style: please no multiline imports, a use item should start and end on the same line.
  • Moving attribute validation from PostExpansionVisitor::visit_attr to AST validation is incorrect, because this validation is done for inert attributes that have to disappear during macro expansion, like attributes on macro calls. See how PostExpansionVisitor::visit_attr is used from feature_gate::check::check_attribute which is called from expand.rs.
  • Please try to replace the FFI hacks connecting crates A and B with traits defined by their common dependencies. I'm not sure that the necessary crates are always linked together.
@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Oct 12, 2019

Regarding use of cfg-expansion from parse_item_mod - see #64197.

@Centril

This comment has been minimized.

Copy link
Member Author

Centril commented Oct 12, 2019

Some comments from a quick review:

Thanks for that :)

The PR is already too big, please try to wrap it up without adding extra changes, unless they are necessary for splitting the crates.

Yeah my goal with this PR was to propose a general direction and then split out smaller individual commits to merge first, especially for some of the larger or drive-by changes (like the one you referenced).

Please avoid tiny modules (like libsyntax_ext/util.rs, libsyntax/util/classify.rs), their contents can be moved into their parent modules.

Hmm... Some of these small modules were pre-existing so if possible I'd like to avoid more drive-by changes in this PR. :)

syntax_macros -> syntax_expand, the former looks like it contains macros used in libsyntax.

Nice! I'll use that. Better than my naming. :)

Style: please no multiline imports, a use item should start and end on the same line.

Will do.

Moving attribute validation from PostExpansionVisitor::visit_attr to AST validation is incorrect, because this validation is done for inert attributes that have to disappear during macro expansion, like attributes on macro calls. See how PostExpansionVisitor::visit_attr is used from feature_gate::check::check_attribute which is called from expand.rs.

Hmm... I inserted a call to validate_attr::check_meta(...); in expand.rs specifically to deal with this. Shouldn't that be sufficient? It feels very wrong to do validation logic in feature gating rather than a validation pass, so if AST validation is not good then I think we should add another pass just after feature gating. This is also a good idea because it doesn't create a cyclic dependency between the parser and feature gating.

Please try to replace the FFI hacks connecting crates A and B with traits defined by their common dependencies. I'm not sure that the necessary crates are always linked together.

By connecting them via e.g. ParseSess (in the parser) or Session (in lowering)? Sure, my initial idea was to do that using just function pointers (dyn Fn(...) -> ...) is unnecessary because these do not require state) but @Mark-Simulacrum suggested that this FFI hack is commonly used in C++-land for ThinLTO purposes but I guess there's not going to be notable perf differences either way from one indirect call here?

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Oct 12, 2019

I only theorized about the FFI hack. I think traits are better, generally speaking, and using &dyn Trait -- maybe even &'static dyn Trait since we always go to a zero-sized struct implementing the trait or so makes a lot of sense.

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Oct 13, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-13T03:44:41.9888898Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-13T03:44:42.0009502Z ##[command]git config gc.auto 0
2019-10-13T03:44:42.0071846Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-13T03:44:42.0121139Z ##[command]git config --get-all http.proxy
2019-10-13T03:44:42.0299667Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65324/merge:refs/remotes/pull/65324/merge
---
2019-10-13T03:54:00.0353391Z    Compiling rustc_macros v0.1.0 (/checkout/src/librustc_macros)
2019-10-13T03:54:08.9628167Z    Compiling syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
2019-10-13T03:54:10.4277046Z    Compiling rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-10-13T03:54:27.6678368Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2019-10-13T03:55:14.9077539Z    Compiling syntax_parse v0.0.0 (/checkout/src/libsyntax_parse)
2019-10-13T03:56:00.3154272Z    Compiling syntax_macros v0.0.0 (/checkout/src/libsyntax_macros)
2019-10-13T04:01:11.2795306Z    Compiling rustc_passes v0.0.0 (/checkout/src/librustc_passes)
2019-10-13T04:02:00.0266858Z    Compiling rustc_lint v0.0.0 (/checkout/src/librustc_lint)
2019-10-13T04:02:42.3988761Z    Compiling rustc_mir v0.0.0 (/checkout/src/librustc_mir)
2019-10-13T04:05:55.4319520Z    Compiling rustc_traits v0.0.0 (/checkout/src/librustc_traits)
---
2019-10-13T04:18:13.4572963Z    Compiling rustc_macros v0.1.0 (/checkout/src/librustc_macros)
2019-10-13T04:18:24.5794870Z    Compiling syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
2019-10-13T04:18:32.8430243Z    Compiling rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-10-13T04:18:54.8725437Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2019-10-13T04:19:51.5115552Z    Compiling syntax_parse v0.0.0 (/checkout/src/libsyntax_parse)
2019-10-13T04:20:48.2342381Z    Compiling syntax_macros v0.0.0 (/checkout/src/libsyntax_macros)
2019-10-13T04:27:07.7078052Z    Compiling rustc_lint v0.0.0 (/checkout/src/librustc_lint)
2019-10-13T04:27:59.2125757Z    Compiling rustc_passes v0.0.0 (/checkout/src/librustc_passes)
2019-10-13T04:28:56.4818351Z    Compiling rustc_traits v0.0.0 (/checkout/src/librustc_traits)
2019-10-13T04:30:24.4597142Z    Compiling rustc_mir v0.0.0 (/checkout/src/librustc_mir)
---
2019-10-13T04:47:07.8803962Z .................................................................................................... 1600/9171
2019-10-13T04:47:14.5529500Z .................................................................................................... 1700/9171
2019-10-13T04:47:27.0893742Z ......................i...............i............................................................. 1800/9171
2019-10-13T04:47:34.5539813Z .................................................................................................... 1900/9171
2019-10-13T04:47:49.4614209Z .............iiiii.................................................................................. 2000/9171
2019-10-13T04:48:00.2106907Z .................................................................................................... 2200/9171
2019-10-13T04:48:02.9331197Z .................................................................................................... 2300/9171
2019-10-13T04:48:08.7185582Z .................................................................................................... 2400/9171
2019-10-13T04:48:31.2599396Z .................................................................................................... 2500/9171
---
2019-10-13T04:51:34.4753580Z ....................i...............i............................................................... 4800/9171
2019-10-13T04:51:46.4528693Z .................................................................................................... 4900/9171
2019-10-13T04:51:52.9853231Z .................................................................................................... 5000/9171
2019-10-13T04:52:03.9208881Z .................................................................................................... 5100/9171
2019-10-13T04:52:10.3504546Z ....................ii.ii........................................................................... 5200/9171
2019-10-13T04:52:21.3666620Z .................................................................................................... 5400/9171
2019-10-13T04:52:31.8159240Z ......................................................................................i............. 5500/9171
2019-10-13T04:52:40.2053487Z .................................................................................................... 5600/9171
2019-10-13T04:52:45.9014636Z .................................................................................................... 5700/9171
2019-10-13T04:52:45.9014636Z .................................................................................................... 5700/9171
2019-10-13T04:52:56.8048600Z ...................................................................................ii...i..ii....... 5800/9171
2019-10-13T04:53:22.9450455Z .................................................................................................... 6000/9171
2019-10-13T04:53:33.2564122Z .................................................................................................... 6100/9171
2019-10-13T04:53:33.2564122Z .................................................................................................... 6100/9171
2019-10-13T04:53:41.3530181Z .........................................................................................i..ii...... 6200/9171
2019-10-13T04:54:10.7984248Z .................................................................................................... 6400/9171
2019-10-13T04:54:15.2099334Z .................................................i.................................................. 6500/9171
2019-10-13T04:54:17.5475035Z .................................................................................................... 6600/9171
2019-10-13T04:54:20.1256891Z ......................i............................................................................. 6700/9171
---
2019-10-13T04:59:05.6908162Z  finished in 5.837
2019-10-13T04:59:05.7100825Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-13T04:59:05.8685491Z 
2019-10-13T04:59:05.8685886Z running 153 tests
2019-10-13T04:59:09.2511347Z i....iii......iii..iiii....i.............................i..i..................i....i............ii. 100/153
2019-10-13T04:59:11.3173555Z i.i..iiii..............i.........iii.i.......ii......
2019-10-13T04:59:11.3174180Z 
2019-10-13T04:59:11.3178055Z  finished in 5.607
2019-10-13T04:59:11.3376564Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-13T04:59:11.5036840Z 
---
2019-10-13T04:59:13.6377229Z  finished in 2.300
2019-10-13T04:59:13.6586298Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-13T04:59:13.8358271Z 
2019-10-13T04:59:13.8359294Z running 9 tests
2019-10-13T04:59:13.8360357Z iiiiiiiii
2019-10-13T04:59:13.8361140Z 
2019-10-13T04:59:13.8361189Z  finished in 0.177
2019-10-13T04:59:13.8565252Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-13T04:59:14.0404921Z 
---
2019-10-13T04:59:32.9040946Z  finished in 19.047
2019-10-13T04:59:32.9239388Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-13T04:59:33.0843004Z 
2019-10-13T04:59:33.0844242Z running 123 tests
2019-10-13T04:59:58.5664452Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-13T05:00:03.5487463Z i.i.i......iii.i.....ii
2019-10-13T05:00:03.5489360Z 
2019-10-13T05:00:03.5495413Z  finished in 30.625
2019-10-13T05:00:03.5507238Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-13T05:00:03.5509244Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2019-10-13T05:00:03.5509244Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2019-10-13T05:00:03.5766808Z Check compiletest suite=ui-fulldeps mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-13T05:00:03.7471904Z 
2019-10-13T05:00:03.7472747Z running 69 tests
2019-10-13T05:00:29.4528562Z F............F....................................F...FFFFFFF..F.....
2019-10-13T05:00:29.4563599Z 
2019-10-13T05:00:29.4564180Z ---- [ui] ui-fulldeps/ast_stmt_expr_attr.rs stdout ----
2019-10-13T05:00:29.4564279Z 
2019-10-13T05:00:29.4564550Z error: test compilation failed although it shouldn't!
2019-10-13T05:00:29.4564550Z error: test compilation failed although it shouldn't!
2019-10-13T05:00:29.4564629Z status: exit code: 1
2019-10-13T05:00:29.4565669Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/ast_stmt_expr_attr.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/ast_stmt_expr_attr/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/ast_stmt_expr_attr/auxiliary"
2019-10-13T05:00:29.4566139Z ------------------------------------------
2019-10-13T05:00:29.4566181Z 
2019-10-13T05:00:29.4566445Z ------------------------------------------
2019-10-13T05:00:29.4566497Z stderr:
---
2019-10-13T05:00:29.4567300Z 
2019-10-13T05:00:29.4567349Z error[E0432]: unresolved import `syntax::parse`
2019-10-13T05:00:29.4567644Z   --> /checkout/src/test/ui-fulldeps/ast_stmt_expr_attr.rs:15:13
2019-10-13T05:00:29.4567700Z    |
2019-10-13T05:00:29.4567748Z LL | use syntax::parse::{ParseSess, PResult};
2019-10-13T05:00:29.4567812Z    |             ^^^^^ could not find `parse` in `syntax`
2019-10-13T05:00:29.4567925Z error[E0433]: failed to resolve: could not find `parse` in `syntax`
2019-10-13T05:00:29.4568204Z   --> /checkout/src/test/ui-fulldeps/ast_stmt_expr_attr.rs:17:13
2019-10-13T05:00:29.4568276Z    |
2019-10-13T05:00:29.4568325Z LL | use syntax::parse::parser::Parser;
---
2019-10-13T05:00:29.4570694Z 
2019-10-13T05:00:29.4570743Z error[E0412]: cannot find type `Parser` in this scope
2019-10-13T05:00:29.4571023Z   --> /checkout/src/test/ui-fulldeps/ast_stmt_expr_attr.rs:26:71
2019-10-13T05:00:29.4571095Z    |
2019-10-13T05:00:29.4571387Z LL | pub fn string_to_parser<'a>(ps: &'a ParseSess, source_str: String) -> Parser<'a> {
2019-10-13T05:00:29.4571530Z 
2019-10-13T05:00:29.4571611Z error[E0412]: cannot find type `Parser` in this scope
2019-10-13T05:00:29.4571953Z   --> /checkout/src/test/ui-fulldeps/ast_stmt_expr_attr.rs:31:20
2019-10-13T05:00:29.4572008Z    |
2019-10-13T05:00:29.4572008Z    |
2019-10-13T05:00:29.4572284Z LL |     F: FnOnce(&mut Parser<'a>) -> PResult<'a, T>,
2019-10-13T05:00:29.4572378Z 
2019-10-13T05:00:29.4572425Z error: aborting due to 8 previous errors
2019-10-13T05:00:29.4572475Z 
2019-10-13T05:00:29.4572525Z Some errors have detailed explanations: E0412, E0432, E0433.
2019-10-13T05:00:29.4572525Z Some errors have detailed explanations: E0412, E0432, E0433.
2019-10-13T05:00:29.4573402Z For more information about an error, try `rustc --explain E0412`.
2019-10-13T05:00:29.4573450Z 
2019-10-13T05:00:29.4573734Z ------------------------------------------
2019-10-13T05:00:29.4573771Z 
2019-10-13T05:00:29.4573800Z 
2019-10-13T05:00:29.4574211Z ---- [ui] ui-fulldeps/gated-plugin.rs stdout ----
2019-10-13T05:00:29.4574293Z 
2019-10-13T05:00:29.4574661Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-13T05:00:29.4574721Z status: exit code: 1
2019-10-13T05:00:29.4575613Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/gated-plugin/auxiliary"
2019-10-13T05:00:29.4576071Z ------------------------------------------
2019-10-13T05:00:29.4576121Z 
2019-10-13T05:00:29.4576371Z ------------------------------------------
2019-10-13T05:00:29.4576431Z stderr:
2019-10-13T05:00:29.4576431Z stderr:
2019-10-13T05:00:29.4576692Z ------------------------------------------
2019-10-13T05:00:29.4576751Z error[E0432]: unresolved import `syntax::ext::base::SyntaxExtension`
2019-10-13T05:00:29.4577034Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:10:5
2019-10-13T05:00:29.4577108Z    |
2019-10-13T05:00:29.4577158Z LL | use syntax::ext::base::SyntaxExtension;
2019-10-13T05:00:29.4577216Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `SyntaxExtension` in `ext::base`
2019-10-13T05:00:29.4577268Z 
2019-10-13T05:00:29.4577778Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-13T05:00:29.4578135Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:14:1
2019-10-13T05:00:29.4578265Z LL | #[plugin_registrar]
2019-10-13T05:00:29.4578330Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-13T05:00:29.4578542Z    |
2019-10-13T05:00:29.4578596Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-13T05:00:29.4579765Z ---- [ui] ui-fulldeps/mod_dir_path_canonicalized.rs stdout ----
2019-10-13T05:00:29.4582125Z 
2019-10-13T05:00:29.4582539Z error: test compilation failed although it shouldn't!
2019-10-13T05:00:29.4582595Z status: exit code: 1
2019-10-13T05:00:29.4588010Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/mod_dir_path_canonicalized.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/mod_dir_path_canonicalized/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/mod_dir_path_canonicalized/auxiliary"
2019-10-13T05:00:29.4588559Z ------------------------------------------
2019-10-13T05:00:29.4588621Z 
2019-10-13T05:00:29.4588878Z ------------------------------------------
2019-10-13T05:00:29.4588928Z stderr:
2019-10-13T05:00:29.4588928Z stderr:
2019-10-13T05:00:29.4589183Z ------------------------------------------
2019-10-13T05:00:29.4589243Z error[E0432]: unresolved imports `syntax::parse`, `syntax::parse`
2019-10-13T05:00:29.4590577Z    |
2019-10-13T05:00:29.4590577Z    |
2019-10-13T05:00:29.4590627Z LL | use syntax::parse::{self, ParseSess};
2019-10-13T05:00:29.4590877Z    |             ^^^^^   ^^^^ no `parse` in the root
2019-10-13T05:00:29.4591024Z    |             could not find `parse` in `syntax`
2019-10-13T05:00:29.4591061Z 
2019-10-13T05:00:29.4591109Z error: aborting due to previous error
2019-10-13T05:00:29.4591141Z 
2019-10-13T05:00:29.4591141Z 
2019-10-13T05:00:29.4591815Z For more information about this error, try `rustc --explain E0432`.
2019-10-13T05:00:29.4591873Z 
2019-10-13T05:00:29.4592123Z ------------------------------------------
2019-10-13T05:00:29.4643326Z 
2019-10-13T05:00:29.4643372Z 
2019-10-13T05:00:29.4643841Z ---- [ui] ui-fulldeps/plugin-args-1.rs stdout ----
2019-10-13T05:00:29.4643877Z 
2019-10-13T05:00:29.4644258Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-10-13T05:00:29.4644319Z status: exit code: 1
2019-10-13T05:00:29.4645059Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-1/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-1/auxiliary"
2019-10-13T05:00:29.4645390Z ------------------------------------------
2019-10-13T05:00:29.4645435Z 
2019-10-13T05:00:29.4645646Z ------------------------------------------
2019-10-13T05:00:29.4645809Z stderr:
2019-10-13T05:00:29.4645809Z stderr:
2019-10-13T05:00:29.4646036Z ------------------------------------------
2019-10-13T05:00:29.4646095Z error[E0432]: unresolved imports `syntax::ext::base::SyntaxExtension`, `syntax::ext::base::SyntaxExtensionKind`
2019-10-13T05:00:29.4646348Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:13:25
2019-10-13T05:00:29.4646423Z    |
2019-10-13T05:00:29.4646691Z LL | use syntax::ext::base::{SyntaxExtension, SyntaxExtensionKind};
2019-10-13T05:00:29.4646747Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^ no `SyntaxExtensionKind` in `ext::base`
2019-10-13T05:00:29.4646810Z    |                         |
2019-10-13T05:00:29.4646859Z    |                         no `SyntaxExtension` in `ext::base`
2019-10-13T05:00:29.4646890Z 
2019-10-13T05:00:29.4646946Z error[E0432]: unresolved imports `syntax::ext::base::TTMacroExpander`, `syntax::ext::base::ExtCtxt`, `syntax::ext::base::MacResult`, `syntax::ext::base::MacEager`
2019-10-13T05:00:29.4647379Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:14:25
2019-10-13T05:00:29.4647430Z    |
2019-10-13T05:00:29.4647611Z LL | use syntax::ext::base::{TTMacroExpander, ExtCtxt, MacResult, MacEager};
2019-10-13T05:00:29.4647664Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^  ^^^^^^^^ no `MacEager` in `ext::base`
2019-10-13T05:00:29.4647791Z    |                         |                |        no `MacResult` in `ext::base`
2019-10-13T05:00:29.4647841Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-13T05:00:29.4647841Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-13T05:00:29.4647887Z    |                         no `TTMacroExpander` in `ext::base`
2019-10-13T05:00:29.4647916Z 
2019-10-13T05:00:29.4648292Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-13T05:00:29.4648544Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:36:1
2019-10-13T05:00:29.4648643Z LL | #[plugin_registrar]
2019-10-13T05:00:29.4648685Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-13T05:00:29.4648839Z    |
2019-10-13T05:00:29.4648878Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-13T05:00:29.4649588Z 
2019-10-13T05:00:29.4649627Z 
2019-10-13T05:00:29.4650277Z ---- [ui] ui-fulldeps/plugin-args-2.rs stdout ----
2019-10-13T05:00:29.4650317Z 
2019-10-13T05:00:29.4650650Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-10-13T05:00:29.4650720Z status: exit code: 1
2019-10-13T05:00:29.4651462Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-2/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-2/auxiliary"
2019-10-13T05:00:29.4651805Z ------------------------------------------
2019-10-13T05:00:29.4651838Z 
2019-10-13T05:00:29.4652069Z ------------------------------------------
2019-10-13T05:00:29.4652112Z stderr:
2019-10-13T05:00:29.4652112Z stderr:
2019-10-13T05:00:29.4652324Z ------------------------------------------
2019-10-13T05:00:29.4652391Z error[E0432]: unresolved imports `syntax::ext::base::SyntaxExtension`, `syntax::ext::base::SyntaxExtensionKind`
2019-10-13T05:00:29.4652641Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:13:25
2019-10-13T05:00:29.4652690Z    |
2019-10-13T05:00:29.4652747Z LL | use syntax::ext::base::{SyntaxExtension, SyntaxExtensionKind};
2019-10-13T05:00:29.4652801Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^ no `SyntaxExtensionKind` in `ext::base`
2019-10-13T05:00:29.4652858Z    |                         |
2019-10-13T05:00:29.4653053Z    |                         no `SyntaxExtension` in `ext::base`
2019-10-13T05:00:29.4653084Z 
2019-10-13T05:00:29.4653140Z error[E0432]: unresolved imports `syntax::ext::base::TTMacroExpander`, `syntax::ext::base::ExtCtxt`, `syntax::ext::base::MacResult`, `syntax::ext::base::MacEager`
2019-10-13T05:00:29.4653570Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:14:25
2019-10-13T05:00:29.4653617Z    |
2019-10-13T05:00:29.4653662Z LL | use syntax::ext::base::{TTMacroExpander, ExtCtxt, MacResult, MacEager};
2019-10-13T05:00:29.4653729Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^  ^^^^^^^^ no `MacEager` in `ext::base`
2019-10-13T05:00:29.4653827Z    |                         |                |        no `MacResult` in `ext::base`
2019-10-13T05:00:29.4653892Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-13T05:00:29.4653892Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-13T05:00:29.4653948Z    |                         no `TTMacroExpander` in `ext::base`
2019-10-13T05:00:29.4653983Z 
2019-10-13T05:00:29.4654336Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-13T05:00:29.4654616Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:36:1
2019-10-13T05:00:29.4654717Z LL | #[plugin_registrar]
2019-10-13T05:00:29.4654761Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-13T05:00:29.4654804Z    |
2019-10-13T05:00:29.4654860Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-13T05:00:29.4656084Z 
2019-10-13T05:00:29.4656116Z 
2019-10-13T05:00:29.4656598Z ---- [ui] ui-fulldeps/plugin-args-3.rs stdout ----
2019-10-13T05:00:29.4656651Z 
2019-10-13T05:00:29.4657331Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" failed to compile: 
2019-10-13T05:00:29.4657425Z status: exit code: 1
2019-10-13T05:00:29.4658223Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-3/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-args-3/auxiliary"
2019-10-13T05:00:29.4658534Z ------------------------------------------
2019-10-13T05:00:29.4658580Z 
2019-10-13T05:00:29.4658799Z ------------------------------------------
2019-10-13T05:00:29.4658855Z stderr:
2019-10-13T05:00:29.4658855Z stderr:
2019-10-13T05:00:29.4659060Z ------------------------------------------
2019-10-13T05:00:29.4659115Z error[E0432]: unresolved imports `syntax::ext::base::SyntaxExtension`, `syntax::ext::base::SyntaxExtensionKind`
2019-10-13T05:00:29.4659367Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:13:25
2019-10-13T05:00:29.4659414Z    |
2019-10-13T05:00:29.4659459Z LL | use syntax::ext::base::{SyntaxExtension, SyntaxExtensionKind};
2019-10-13T05:00:29.4659527Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^^^ no `SyntaxExtensionKind` in `ext::base`
2019-10-13T05:00:29.4659697Z    |                         |
2019-10-13T05:00:29.4659742Z    |                         no `SyntaxExtension` in `ext::base`
2019-10-13T05:00:29.4659787Z 
2019-10-13T05:00:29.4660373Z error[E0432]: unresolved imports `syntax::ext::base::TTMacroExpander`, `syntax::ext::base::ExtCtxt`, `syntax::ext::base::MacResult`, `syntax::ext::base::MacEager`
2019-10-13T05:00:29.4660898Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:14:25
2019-10-13T05:00:29.4660970Z    |
2019-10-13T05:00:29.4661018Z LL | use syntax::ext::base::{TTMacroExpander, ExtCtxt, MacResult, MacEager};
2019-10-13T05:00:29.4661074Z    |                         ^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^  ^^^^^^^^ no `MacEager` in `ext::base`
2019-10-13T05:00:29.4661189Z    |                         |                |        no `MacResult` in `ext::base`
2019-10-13T05:00:29.4661241Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-13T05:00:29.4661241Z    |                         |                no `ExtCtxt` in `ext::base`
2019-10-13T05:00:29.4661302Z    |                         no `TTMacroExpander` in `ext::base`
2019-10-13T05:00:29.4661333Z 
2019-10-13T05:00:29.4661703Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-13T05:00:29.4661992Z   --> /checkout/src/test/ui-fulldeps/auxiliary/plugin-args.rs:36:1
2019-10-13T05:00:29.4662089Z LL | #[plugin_registrar]
2019-10-13T05:00:29.4662149Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-13T05:00:29.4662192Z    |
2019-10-13T05:00:29.4662235Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-13T05:00:29.4662928Z 
2019-10-13T05:00:29.4662954Z 
2019-10-13T05:00:29.4663181Z ---- [ui] ui-fulldeps/plugin-as-extern-crate.rs stdout ----
2019-10-13T05:00:29.4663227Z 
2019-10-13T05:00:29.4663501Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-13T05:00:29.4663655Z status: exit code: 1
2019-10-13T05:00:29.4664697Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-as-extern-crate/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-as-extern-crate/auxiliary"
2019-10-13T05:00:29.4665028Z ------------------------------------------
2019-10-13T05:00:29.4665488Z 
2019-10-13T05:00:29.4665834Z ------------------------------------------
2019-10-13T05:00:29.4665896Z stderr:
2019-10-13T05:00:29.4665896Z stderr:
2019-10-13T05:00:29.4666113Z ------------------------------------------
2019-10-13T05:00:29.4666177Z error[E0432]: unresolved import `syntax::ext::base::SyntaxExtension`
2019-10-13T05:00:29.4666993Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:10:5
2019-10-13T05:00:29.4667055Z    |
2019-10-13T05:00:29.4667097Z LL | use syntax::ext::base::SyntaxExtension;
2019-10-13T05:00:29.4667157Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `SyntaxExtension` in `ext::base`
2019-10-13T05:00:29.4667189Z 
2019-10-13T05:00:29.4667545Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-13T05:00:29.4667819Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:14:1
2019-10-13T05:00:29.4667906Z LL | #[plugin_registrar]
2019-10-13T05:00:29.4667958Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-13T05:00:29.4668001Z    |
2019-10-13T05:00:29.4668043Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-13T05:00:29.4669122Z 
2019-10-13T05:00:29.4669146Z 
2019-10-13T05:00:29.4669367Z ---- [ui] ui-fulldeps/plugin-attr-register-deny.rs stdout ----
2019-10-13T05:00:29.4669413Z 
2019-10-13T05:00:29.4669676Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-13T05:00:29.4669727Z status: exit code: 1
2019-10-13T05:00:29.4671095Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny/auxiliary"
2019-10-13T05:00:29.4671452Z ------------------------------------------
2019-10-13T05:00:29.4671485Z 
2019-10-13T05:00:29.4671700Z ------------------------------------------
2019-10-13T05:00:29.4671745Z stderr:
2019-10-13T05:00:29.4671745Z stderr:
2019-10-13T05:00:29.4671967Z ------------------------------------------
2019-10-13T05:00:29.4672018Z error[E0432]: unresolved import `syntax::ext::base::SyntaxExtension`
2019-10-13T05:00:29.4672266Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:10:5
2019-10-13T05:00:29.4672330Z    |
2019-10-13T05:00:29.4672372Z LL | use syntax::ext::base::SyntaxExtension;
2019-10-13T05:00:29.4672422Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `SyntaxExtension` in `ext::base`
2019-10-13T05:00:29.4672463Z 
2019-10-13T05:00:29.4672944Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-13T05:00:29.4673289Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:14:1
2019-10-13T05:00:29.4673381Z LL | #[plugin_registrar]
2019-10-13T05:00:29.4673426Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-13T05:00:29.4673489Z    |
2019-10-13T05:00:29.4673532Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-13T05:00:29.4674179Z 
2019-10-13T05:00:29.4674204Z 
2019-10-13T05:00:29.4674425Z ---- [ui] ui-fulldeps/plugin-reexport.rs stdout ----
2019-10-13T05:00:29.4674456Z 
2019-10-13T05:00:29.4674750Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" failed to compile: 
2019-10-13T05:00:29.4674809Z status: exit code: 1
2019-10-13T05:00:29.4675541Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-reexport/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-reexport/auxiliary"
2019-10-13T05:00:29.4675870Z ------------------------------------------
2019-10-13T05:00:29.4675903Z 
2019-10-13T05:00:29.4676116Z ------------------------------------------
2019-10-13T05:00:29.4676276Z stderr:
2019-10-13T05:00:29.4676276Z stderr:
2019-10-13T05:00:29.4676494Z ------------------------------------------
2019-10-13T05:00:29.4676636Z error[E0432]: unresolved import `syntax::ext::base::SyntaxExtension`
2019-10-13T05:00:29.4677033Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:10:5
2019-10-13T05:00:29.4677097Z    |
2019-10-13T05:00:29.4677138Z LL | use syntax::ext::base::SyntaxExtension;
2019-10-13T05:00:29.4677184Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `SyntaxExtension` in `ext::base`
2019-10-13T05:00:29.4677214Z 
2019-10-13T05:00:29.4677652Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-13T05:00:29.4677913Z   --> /checkout/src/test/ui-fulldeps/auxiliary/attr-plugin-test.rs:14:1
2019-10-13T05:00:29.4678012Z LL | #[plugin_registrar]
2019-10-13T05:00:29.4678054Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-13T05:00:29.4678105Z    |
2019-10-13T05:00:29.4678156Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-13T05:00:29.4679564Z ---- [ui] ui-fulldeps/pprust-expr-roundtrip.rs stdout ----
2019-10-13T05:00:29.4679595Z 
2019-10-13T05:00:29.4680255Z error: test compilation failed although it shouldn't!
2019-10-13T05:00:29.4680321Z status: exit code: 1
2019-10-13T05:00:29.4681251Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/pprust-expr-roundtrip.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip/auxiliary"
2019-10-13T05:00:29.4681645Z ------------------------------------------
2019-10-13T05:00:29.4681679Z 
2019-10-13T05:00:29.4681909Z ------------------------------------------
2019-10-13T05:00:29.4681953Z stderr:
2019-10-13T05:00:29.4681953Z stderr:
2019-10-13T05:00:29.4682161Z ------------------------------------------
2019-10-13T05:00:29.4682225Z error[E0432]: unresolved imports `syntax::parse`, `syntax::parse`
2019-10-13T05:00:29.4682523Z    |
2019-10-13T05:00:29.4682523Z    |
2019-10-13T05:00:29.4682582Z LL | use syntax::parse::{self, ParseSess};
2019-10-13T05:00:29.4682629Z    |             ^^^^^   ^^^^ no `parse` in the root
2019-10-13T05:00:29.4682742Z    |             could not find `parse` in `syntax`
2019-10-13T05:00:29.4682779Z 
2019-10-13T05:00:29.4682821Z error: aborting due to previous error
2019-10-13T05:00:29.4682850Z 
2019-10-13T05:00:29.4682850Z 
2019-10-13T05:00:29.4683111Z For more information about this error, try `rustc --explain E0432`.
2019-10-13T05:00:29.4683145Z 
2019-10-13T05:00:29.4683470Z ------------------------------------------
2019-10-13T05:00:29.4683500Z 
2019-10-13T05:00:29.4683523Z 
2019-10-13T05:00:29.4683746Z ---- [ui] ui-fulldeps/roman-numerals-macro.rs stdout ----
2019-10-13T05:00:29.4683776Z 
2019-10-13T05:00:29.4684027Z error: auxiliary build of "/checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs" failed to compile: 
2019-10-13T05:00:29.4684092Z status: exit code: 1
2019-10-13T05:00:29.4685063Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/roman-numerals-macro/auxiliary" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/roman-numerals-macro/auxiliary"
2019-10-13T05:00:29.4685546Z ------------------------------------------
2019-10-13T05:00:29.4685580Z 
2019-10-13T05:00:29.4685812Z ------------------------------------------
2019-10-13T05:00:29.4685856Z stderr:
2019-10-13T05:00:29.4685856Z stderr:
2019-10-13T05:00:29.4686065Z ------------------------------------------
2019-10-13T05:00:29.4686131Z error[E0433]: failed to resolve: could not find `parse` in `syntax`
2019-10-13T05:00:29.4686380Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:17:13
2019-10-13T05:00:29.4686429Z    |
2019-10-13T05:00:29.4686483Z LL | use syntax::parse::token::{self, Token};
2019-10-13T05:00:29.4686542Z    |             ^^^^^ could not find `parse` in `syntax`
2019-10-13T05:00:29.4686623Z error[E0432]: unresolved import `syntax::parse`
2019-10-13T05:00:29.4686886Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:17:13
2019-10-13T05:00:29.4686933Z    |
2019-10-13T05:00:29.4686933Z    |
2019-10-13T05:00:29.4686976Z LL | use syntax::parse::token::{self, Token};
2019-10-13T05:00:29.4687036Z    |             ^^^^^ could not find `parse` in `syntax`
2019-10-13T05:00:29.4687065Z 
2019-10-13T05:00:29.4687122Z error[E0432]: unresolved imports `syntax::ext::base::ExtCtxt`, `syntax::ext::base::MacResult`, `syntax::ext::base::DummyResult`, `syntax::ext::base::MacEager`
2019-10-13T05:00:29.4687392Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:19:25
2019-10-13T05:00:29.4687441Z    |
2019-10-13T05:00:29.4687488Z LL | use syntax::ext::base::{ExtCtxt, MacResult, DummyResult, MacEager};
2019-10-13T05:00:29.4687558Z    |                         ^^^^^^^  ^^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^ no `MacEager` in `ext::base`
2019-10-13T05:00:29.4687884Z    |                         |        |          no `DummyResult` in `ext::base`
2019-10-13T05:00:29.4688052Z    |                         |        no `MacResult` in `ext::base`
2019-10-13T05:00:29.4688098Z    |                         no `ExtCtxt` in `ext::base`
2019-10-13T05:00:29.4688126Z 
2019-10-13T05:00:29.4688126Z 
2019-10-13T05:00:29.4688169Z error[E0422]: cannot find struct, variant or union type `Token` in this scope
2019-10-13T05:00:29.4688451Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:40:26
2019-10-13T05:00:29.4688494Z    |
2019-10-13T05:00:29.4688540Z LL |         TokenTree::Token(Token { kind: token::Ident(s, _), .. }) => s.to_string(),
2019-10-13T05:00:29.4688647Z help: possible candidates are found in other modules, you can import them into scope
2019-10-13T05:00:29.4688689Z    |
2019-10-13T05:00:29.4688747Z LL | use syntax::token::Token;
2019-10-13T05:00:29.4688791Z    |
2019-10-13T05:00:29.4688791Z    |
2019-10-13T05:00:29.4688832Z LL | use syntax::tokenstream::TokenTree::Token;
2019-10-13T05:00:29.4688881Z    |
2019-10-13T05:00:29.4688906Z 
2019-10-13T05:00:29.4689250Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/issues/29597
2019-10-13T05:00:29.4693074Z   --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:65:1
2019-10-13T05:00:29.4693190Z LL | #[plugin_registrar]
2019-10-13T05:00:29.4693235Z    | ^^^^^^^^^^^^^^^^^^^ help: remove this attribute
2019-10-13T05:00:29.4693418Z    |
2019-10-13T05:00:29.4693458Z    = note: `#[warn(deprecated)]` on by default
---
2019-10-13T05:00:29.4700350Z test result: FAILED. 58 passed; 11 failed; 0 ignored; 0 measured; 0 filtered out
2019-10-13T05:00:29.4700412Z 
2019-10-13T05:00:29.4700438Z 
2019-10-13T05:00:29.4700462Z 
2019-10-13T05:00:29.4702141Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-10-13T05:00:29.4702405Z 
2019-10-13T05:00:29.4702433Z 
2019-10-13T05:00:29.4702827Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-10-13T05:00:29.4702889Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-10-13T05:00:29.4702889Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-10-13T05:00:29.4702943Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-10-13T05:00:29.4703015Z Build completed unsuccessfully in 1:09:37
2019-10-13T05:00:29.4703067Z == clock drift check ==
2019-10-13T05:00:29.4703112Z   local time: Sun Oct 13 05:00:29 UTC 2019
2019-10-13T05:00:29.5007906Z   network time: Sun, 13 Oct 2019 05:00:29 GMT
2019-10-13T05:00:29.5014294Z == end clock drift check ==
2019-10-13T05:00:30.4048455Z ##[error]Bash exited with code '1'.
2019-10-13T05:00:30.4107595Z ##[section]Starting: Checkout
2019-10-13T05:00:30.4109706Z ==============================================================================
2019-10-13T05:00:30.4109768Z Task         : Get sources
2019-10-13T05:00:30.4109821Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril added a commit to Centril/rust that referenced this pull request Oct 13, 2019
…h-ascription, r=davidtwco

syntax: simplify maybe_annotate_with_ascription

Split out from rust-lang#65324.

r? @estebank
Centril added a commit to Centril/rust that referenced this pull request Oct 13, 2019
simplify maybe_stage_features

Extracted from rust-lang#65324.

r? @estebank
Centril added a commit to Centril/rust that referenced this pull request Oct 13, 2019
simplify integer_lit

Extracted from rust-lang#65324.

r? @davidtwco
Centril added a commit to Centril/rust that referenced this pull request Oct 13, 2019
mbe: reduce panictry! uses.

Extracted from rust-lang#65324.

r? @petrochenkov
Centril added a commit to Centril/rust that referenced this pull request Oct 13, 2019
syntax: consolidate function parsing in item.rs

Extracted from rust-lang#65324.

r? @estebank
@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Oct 13, 2019

☔️ The latest upstream changes (presumably #65368) made this pull request unmergeable. Please resolve the merge conflicts.

@Centril Centril force-pushed the Centril:organize-syntax branch from a7b70d2 to cd2c610 Oct 13, 2019
@Centril Centril force-pushed the Centril:organize-syntax branch from 777e5bc to aea1fad Nov 10, 2019
also move MACRO_ARGUMENTS -> librustc_parse
@Centril Centril force-pushed the Centril:organize-syntax branch from aea1fad to 4ae2728 Nov 10, 2019
@Centril

This comment has been minimized.

Copy link
Member Author

Centril commented Nov 10, 2019

Since this PR introduces syntax_parse, it probably makes sense to immediately introduce it as rustc_parse, crates introduced in the previous PRs can be renamed later (syntax_expand -> rustc_expand, syntax_ext -> rustc_builtin_macros, syntax/syntax_pos - ???).

Done. I would propose syntax -> rustc_ast and syntax_pos -> rustc_pos

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Nov 10, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 10, 2019

📌 Commit 4ae2728 has been approved by petrochenkov

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Nov 10, 2019

@Centril

I would propose syntax -> rustc_ast and syntax_pos -> rustc_pos

rustc_pos -> rustc_span perhaps?

The crate consists of:

  • source map - kind of position, kind of span, spans and positions point into the source map
  • span - kind of position, literally span
  • hygiene - not a position, part of a span
  • edition - part of hygiene - not a position, part of a span
  • symbol/ident - neither position, nor span (ident has a span though)
@Centril

This comment has been minimized.

Copy link
Member Author

Centril commented Nov 10, 2019

rustc_pos -> rustc_span perhaps?

👍

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 10, 2019

⌛️ Testing commit 4ae2728 with merge a3b6e57...

bors added a commit that referenced this pull request Nov 10, 2019
Split libsyntax apart

In this PR the general idea is to separate the AST, parser, and friends by a more data / logic structure (tho not fully realized!) by separating out the parser and macro expansion code from libsyntax. Specifically have now three crates instead of one (libsyntax):

- libsyntax:

   - concrete syntax tree (`syntax::ast`)

   - definition of tokens and token-streams (`syntax::{token, tokenstream}`) -- used by `syntax::ast`

   - visitors (`syntax::visit`, `syntax::mut_visit`)

   - shared definitions between `libsyntax_expand`

   - feature gating (`syntax::feature_gate`) -- we could possibly move this out to its own crater later.

   - attribute and meta item utilities, including used-marking (`syntax::attr`)

   - pretty printer (`syntax::print`) -- this should possibly be moved out later. For now I've reduced down the dependencies to a single essential one which could be broken via `ParseSess`. This entails that e.g. `Debug` impls for `Path` cannot reference the pretty printer.

   - definition of `ParseSess` (`syntax::sess`) -- this is used by `syntax::{attr, print, feature_gate}` and is a common definition used by the parser and other things like librustc.

   - the `syntax::source_map` -- this includes definitions used by `syntax::ast` and other things but could ostensibly be moved `syntax_pos` since that is more related to this module.

   - a smattering of misc utilities not sufficiently important to itemize -- some of these could be moved to where they are used (often a single place) but I wanted to limit the scope of this PR.

- librustc_parse:

   - parser (`rustc_parse::parser`) -- reading a file and such are defined in the crate root tho.

   - lexer (`rustc_parse::lexer`)

   - validation of meta grammar (post-expansion) in (`rustc_parse::validate_attr`)

- libsyntax_expand -- this defines the infra for macro expansion and conditional compilation but this is not libsyntax_ext; we might want to merge them later but currently libsyntax_expand is depended on by librustc_metadata which libsyntax_ext is not.

   - conditional compilation (`syntax_expand::config`) -- moved from `syntax::config` to here

   - the bulk of this crate is made up of the old `syntax::ext`

r? @estebank
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 10, 2019

☀️ Test successful - checks-azure
Approved by: petrochenkov
Pushing a3b6e57 to master...

@bors bors added the merged-by-bors label Nov 10, 2019
@bors bors merged commit 4ae2728 into rust-lang:master Nov 10, 2019
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20191110.5 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@Centril Centril deleted the Centril:organize-syntax branch Nov 10, 2019
mikerite added a commit to mikerite/rust-clippy that referenced this pull request Nov 11, 2019
bors added a commit to rust-lang/rust-clippy that referenced this pull request Nov 11, 2019
Fix breakage due to rust-lang/rust#65324

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.