syntax: misc extractions #65376
Merged
syntax: misc extractions #65376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
syntax-extractions-1
branch
from
cdf6652
to
9262b02
Compare
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
syntax-extractions-1
branch
from
6ed37c2
to
aaeb137
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/libsyntax/parse/sess.rs
Outdated
|
|
||
| /// Extend an error with a suggestion to wrap an expression with parentheses to allow the | ||
| /// parser to continue parsing the following operation as part of the same expression. | ||
| pub fn expr_parentheses_needed( |
There was a problem hiding this comment.
I'm pretty sure this doesn't belong to sess.rs even if it was there previously.
There was a problem hiding this comment.
Yeah I agree, but I'm not quite sure where to put it tho and we can always move it later. =)
|
r=me after rebase and fixing tests |
petrochenkov
added
S-waiting-on-author
Centril
force-pushed
the
syntax-extractions-1
branch
from
aaeb137
to
ae156a5
Compare
|
@bors r=petrochenkov |
|
📌 Commit ae156a5 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 15, 2019
…rochenkov syntax: misc extractions Part of rust-lang#65324. r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 15, 2019
…rochenkov syntax: misc extractions Part of rust-lang#65324. r? @petrochenkov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65324.
r? @petrochenkov