Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #65596

Closed
wants to merge 27 commits into from
Closed

Commits on Oct 15, 2019

  1. Use structured suggestion for restricting bounds

    When a trait bound is not met and restricting a type parameter would
    make the restriction hold, use a structured suggestion pointing at an
    appropriate place (type param in param list or `where` clause).
    
    Account for opaque parameters where instead of suggesting extending
    the `where` clause, we suggest appending the new restriction:
    `fn foo(impl Trait + UnmetTrait)`.
    estebank committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    190589f View commit details
    Browse the repository at this point in the history
  2. Handle more cases

    estebank committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    5b7ffd9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dbd75c8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    99ab45b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ca1885d View commit details
    Browse the repository at this point in the history
  6. Consider trait aliases

    estebank committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    b81df6b View commit details
    Browse the repository at this point in the history
  7. Update NLL tests

    estebank committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    daa8491 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5cc99ee View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    bc744bc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ab7d8f0 View commit details
    Browse the repository at this point in the history
  11. Remove useless help

    estebank committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    39a9e2e View commit details
    Browse the repository at this point in the history
  12. Remove trailing whitespace

    estebank committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    8cabb42 View commit details
    Browse the repository at this point in the history
  13. review comments

    estebank committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    9c525ee View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9ed463a View commit details
    Browse the repository at this point in the history
  15. Simplify code

    estebank committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    9ecd1d2 View commit details
    Browse the repository at this point in the history
  16. Fix comparison after rebase

    estebank committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    c6dce78 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Rc: value -> allocation

    RalfJung committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    470e9d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    868a772 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5697432 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2019

  1. Configuration menu
    Copy the full SHA
    696cba6 View commit details
    Browse the repository at this point in the history
  2. bump miri

    RalfJung committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    fac34eb View commit details
    Browse the repository at this point in the history
  3. some more Rc tweaks

    RalfJung committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    52a31f7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1b38463 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#65192 - estebank:restrict-bound, r=matthewj…

    …asper
    
    Use structured suggestion for restricting bounds
    
    When a trait bound is not met and restricting a type parameter would
    make the restriction hold, use a structured suggestion pointing at an
    appropriate place (type param in param list or `where` clause).
    
    Account for opaque parameters where instead of suggesting extending
    the `where` clause, we suggest appending the new restriction:
    `fn foo(impl Trait + UnmetTrait)`. Fix rust-lang#64565, fix rust-lang#41817, fix rust-lang#24354,
    cc rust-lang#26026, cc rust-lang#37808, cc rust-lang#24159, fix rust-lang#37138, fix rust-lang#24354, cc rust-lang#20671.
    Centril committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    ef8ac78 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#65226 - ssomers:master, r=bluss

    BTreeSet symmetric_difference & union optimized
    
    No scalability changes, but:
    - Grew the cmp_opt function (shared by symmetric_difference & union) into a MergeIter, with less memory overhead than the pairs of Peekable iterators now, speeding up ~20% on my machine (not so clear on Travis though, I actually switched it off there because it wasn't consistent about identical code). Mainly meant to improve readability by sharing code, though it does end up using more lines of code. Extending and reusing the MergeIter in btree_map might be better, but I'm not sure that's possible or desirable. This MergeIter probably pretends to be more generic than it is, yet doesn't declare to be an iterator because there's no need to, it's only there to help construct genuine iterators SymmetricDifference & Union.
    - Compact the code of rust-lang#64820 by moving if/else into match guards.
    
    r? @bluss
    Centril committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    7c0186a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#65505 - RalfJung:rc, r=Centril

    Rc: value -> allocation
    
    See rust-lang#64484. This does not yet edit `Arc` as I first wanted to be sure we agree on the terminology the way it actually ends up. "value" as a term appears a lot in this file, and sometimes it refers to the value stored inside the `RcBox` while sometimes it refers to the `RcBox` itself. I tried to properly tease these apart but may have made some mistakes. The former should now always be called "inner value" and the latter "allocation".
    
    One area where I was very unsure of which terminology is dropping: the `value` field of the `RcBox` will get dropped *earlier* than the `RcBox` itself if there are weak references. I decided that "dropping the value stored in the allocation" refers to dropping the value field, while "destroying the allocation" refers to actually freeing its backing memory.
    
    r? @Centril
    Centril committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    df2c324 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a9d40b4 View commit details
    Browse the repository at this point in the history