Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for issue 63116 #66471

Merged
merged 1 commit into from Nov 17, 2019
Merged

Add test for issue 63116 #66471

merged 1 commit into from Nov 17, 2019

Conversation

Alexendoo
Copy link
Member

Closes #63116

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2019
@Centril
Copy link
Contributor

Centril commented Nov 16, 2019

r? @Centril

Can you please add a reference to #66361 in the text? I'm sure it got fixed by that PR since it's the same unreachable!() which was replaced.

@Alexendoo
Copy link
Member Author

Will do, does the text mean a comment in the test file or the commit message?

@Centril
Copy link
Contributor

Centril commented Nov 16, 2019

A comment in the test file would be great :)

@Alexendoo
Copy link
Member Author

Thanks, added it

@Centril
Copy link
Contributor

Centril commented Nov 16, 2019

👍 @bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 16, 2019

📌 Commit cfe94b4 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 17, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 17, 2019
bors added a commit that referenced this pull request Nov 17, 2019
Rollup of 11 pull requests

Successful merges:

 - #65739 (Improve documentation of `Vec::split_off(...)`)
 - #66271 (syntax: Keep string literals in ABIs and `asm!` more precisely)
 - #66344 (rustc_plugin: Remove `Registry::register_attribute`)
 - #66381 (find_deprecation: deprecation attr may be ill-formed meta.)
 - #66395 (Centralize panic macro documentation)
 - #66456 (Move `DIAGNOSTICS` usage to `rustc_driver`)
 - #66465 (add missing 'static lifetime in docs)
 - #66466 (miri panic_unwind: fix hack for SEH platforms)
 - #66469 (Use "field is never read" instead of "field is never used")
 - #66471 (Add test for issue 63116)
 - #66477 (Clarify transmute_copy documentation example)

Failed merges:

r? @ghost
@bors bors merged commit cfe94b4 into rust-lang:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE on "internal error: entered unreachable code"
5 participants