Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay an `is_local_ever_initialized` call. #66537

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@nnethercote
Copy link
Contributor

nnethercote commented Nov 19, 2019

This commit moves the call after a return that almost always runs. It
speeds up the unicode_normalization benchmark by about 2%.

r? @spastorino

This commit moves the call after a `return` that almost always runs. It
speeds up the `unicode_normalization` benchmark by about 2%.
@nnethercote

This comment has been minimized.

Copy link
Contributor Author

nnethercote commented Nov 19, 2019

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Nov 19, 2019

Awaiting bors try build completion

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 19, 2019

⌛️ Trying commit 9651617 with merge b0ffe53...

bors added a commit that referenced this pull request Nov 19, 2019
…=<try>

Delay an `is_local_ever_initialized` call.

This commit moves the call after a `return` that almost always runs. It
speeds up the `unicode_normalization` benchmark by about 2%.

r? @spastorino
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 19, 2019

☀️ Try build successful - checks-azure
Build commit: b0ffe53 (b0ffe539b10a02cdb3ff9a220ea27b0b27154e2d)

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Nov 19, 2019

Queued b0ffe53 with parent 0ccee30, future comparison URL.

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Nov 19, 2019

Finished benchmarking try commit b0ffe53, comparison URL.

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Nov 19, 2019

@rust-highfive rust-highfive assigned pnkfelix and unassigned spastorino Nov 19, 2019
@nnethercote

This comment has been minimized.

Copy link
Contributor Author

nnethercote commented Nov 19, 2019

The CI perf results match the local ones: unicode_normalization instructions counts are reduced by up to 2.4%. Other benchmarks are unaffected.

@spastorino

This comment has been minimized.

Copy link
Member

spastorino commented Nov 19, 2019

Just talked to @Centril about this PR and we can continue with his comments in a follow up PR or issue.
@pnkfelix || @tmandry can you check that?.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 19, 2019

📌 Commit 9651617 has been approved by spastorino

@spastorino

This comment has been minimized.

Copy link
Member

spastorino commented Nov 19, 2019

@bors rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 19, 2019

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #66545
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 19, 2019

📌 Commit 9651617 has been approved by spastorino

@spastorino

This comment has been minimized.

Copy link
Member

spastorino commented Nov 19, 2019

@bors rollup=never

This is a performance improvement that may mask perf regressions if rolled up.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 22, 2019

⌛️ Testing commit 9651617 with merge 564f2d3...

bors added a commit that referenced this pull request Nov 22, 2019
…=spastorino

Delay an `is_local_ever_initialized` call.

This commit moves the call after a `return` that almost always runs. It
speeds up the `unicode_normalization` benchmark by about 2%.

r? @spastorino
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 22, 2019

☀️ Test successful - checks-azure
Approved by: spastorino
Pushing 564f2d3 to master...

@bors bors added the merged-by-bors label Nov 22, 2019
@bors bors merged commit 9651617 into rust-lang:master Nov 22, 2019
5 checks passed
5 checks passed
homu Test successful
Details
pr #20191119.4 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@nnethercote nnethercote deleted the nnethercote:delay-is_local_ever_initialized branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.