Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ast address-of #66671

Merged
merged 3 commits into from
Nov 25, 2019
Merged

Ast address-of #66671

merged 3 commits into from
Nov 25, 2019

Conversation

matthewjasper
Copy link
Contributor

This is the parts of #64588 that don't affect MIR. If an address-of expression makes it to MIR lowering we error and lower to the best currently expressible approximation to limit further errors.

r? @Centril

@matthewjasper matthewjasper added the F-raw_ref_op `#![feature(raw_ref_op)]` label Nov 23, 2019
@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2019
@matthewjasper matthewjasper mentioned this pull request Nov 23, 2019
Merged
@rust-highfive

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Nov 23, 2019
View reviewed changes
src/libsyntax/mut_visit.rs Outdated Show resolved Hide resolved
src/librustc_parse/parser/expr.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/expr.rs Outdated Show resolved Hide resolved
src/librustc_error_codes/error_codes/E0745.md Outdated Show resolved Hide resolved
src/librustc_typeck/check/regionck.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/expr.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/expr.rs Outdated Show resolved Hide resolved
src/test/ui/raw-ref-op/raw-ref-temp-deref.rs Outdated Show resolved Hide resolved
src/test/ui/raw-ref-op/raw-ref-temp-deref.rs Outdated Show resolved Hide resolved
src/test/ui/raw-ref-op/raw-ref-temp.rs Outdated Show resolved Hide resolved
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2019
RalfJung
RalfJung reviewed Nov 24, 2019
View reviewed changes
src/librustc/hir/mod.rs Outdated Show resolved Hide resolved
@matthewjasper matthewjasper mentioned this pull request Nov 24, 2019
Open
@Centril Centril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2019
Centril
Centril approved these changes Nov 24, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when green

@matthewjasper
Copy link
Contributor Author

@bors r=Centril

@bors
Copy link
Contributor

bors commented Nov 24, 2019

📌 Commit f4efc5d has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2019
@bors
Copy link
Contributor

bors commented Nov 25, 2019

⌛ Testing commit f4efc5d with merge c9bacb7...

bors added a commit that referenced this pull request Nov 25, 2019
@bors
Auto merge of #66671 - matthewjasper:ast-address-of, r=Centril
c9bacb7 
Ast address-of

This is the parts of #64588 that don't affect MIR. If an address-of expression makes it to MIR lowering we error and lower to the best currently expressible approximation to limit further errors.

r? @Centril
@bors
Copy link
Contributor

bors commented Nov 25, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing c9bacb7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 25, 2019
@bors bors merged commit f4efc5d into rust-lang:master Nov 25, 2019
@rust-highfive rust-highfive mentioned this pull request Nov 25, 2019
Closed
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #66671!

Tested on commit c9bacb7.
Direct link to PR: #66671

💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Nov 25, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#66671!
5ea12a1 
Tested on commit rust-lang/rust@c9bacb7.
Direct link to PR: <rust-lang/rust#66671>

💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
@bors bors mentioned this pull request Nov 25, 2019
Merged
@matthewjasper matthewjasper deleted the ast-address-of branch November 25, 2019 06:47
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Nov 25, 2019
@flip1995
Rustup to rust-lang/rust#66671
d43c424
@flip1995 flip1995 mentioned this pull request Nov 25, 2019
Merged
bors added a commit to rust-lang/rust-clippy that referenced this pull request Nov 27, 2019
@bors
Auto merge of #4846 - flip1995:rustup, r=Manishearth
ff930d3 
Rustup

Rustups:

- rust-lang/rust#66671 (Ast address-of)
- rust-lang/rust#64856 (Scope format! temporaries)

changelog: none
bors added a commit to rust-lang/rust-clippy that referenced this pull request Nov 27, 2019
@bors
Auto merge of #4846 - flip1995:rustup, r=Manishearth
a3da0fb 
Rustup to rustc 1.41.0-nightly (e87a205 2019-11-27)

Rustups:

- rust-lang/rust#66671 (Ast address-of)
- rust-lang/rust#64856 (Scope format! temporaries)
 - http://github.com/rust-lang/rust/pull/66719

changelog: none
bors added a commit to rust-lang/rust-clippy that referenced this pull request Nov 27, 2019
@bors
Auto merge of #4846 - flip1995:rustup, r=Manishearth
7b8e829 
Rustup to rustc 1.41.0-nightly (e87a205 2019-11-27)

Rustups:

- rust-lang/rust#66671 (Ast address-of)
- rust-lang/rust#64856 (Scope format! temporaries)
 - http://github.com/rust-lang/rust/pull/66719

changelog: none
@matthewjasper matthewjasper mentioned this pull request Dec 20, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez requested changes

@Centril Centril Centril approved these changes

Assignees

@Centril Centril

Labels
F-raw_ref_op `#![feature(raw_ref_op)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matthewjasper @rust-highfive @bors @RalfJung @Centril @GuillaumeGomez