is_binding_pat: use explicit match & include or-pats in grammar
#67428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
commented
Dec 19, 2019
| @@ -1221,7 +1223,13 @@ fn resolve_local<'tcx>( | |||
| is_binding_pat(&subpat) | |||
| } | |||
|
|
|||
| _ => false, | |||
| PatKind::Ref(_, _) | | |||
There was a problem hiding this comment.
So it never applies to let & mut? ref mut? x atm -- why is that?
There was a problem hiding this comment.
Because it generally wouldn't be helpful. Extending the storage lifetime of a reference doesn't extend the lifetime of what it points to.
|
@bors r+ |
|
📌 Commit 4414f0d has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 20, 2019
…ewjasper `is_binding_pat`: use explicit match & include or-pats in grammar r? @matthewjasper @nikomatsakis
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 20, 2019
…ewjasper `is_binding_pat`: use explicit match & include or-pats in grammar r? @matthewjasper @nikomatsakis
bors
added a commit
that referenced
this pull request
Dec 21, 2019
Rollup of 6 pull requests Successful merges: - #67130 (Const prop should finish propagation into user defined variables) - #67163 (Split up ptr/mod.rs in libcore...) - #67314 (Don't suppress move errors for union fields) - #67392 (Fix unresolved type span inside async object) - #67404 (Separate region inference logic from error handling better) - #67428 (`is_binding_pat`: use explicit match & include or-pats in grammar) Failed merges: r? @ghost
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #54883
r? @matthewjasper @nikomatsakis