Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #67555

Closed
wants to merge 23 commits into from
Closed

Rollup of 5 pull requests #67555

wants to merge 23 commits into from

Commits on Dec 10, 2019

  1. Suggest calling method when first argument is self

    @VirrageS
    VirrageS committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    f13b8fb View commit details
    Browse the repository at this point in the history

  2. Add more detailed suggestion

    @VirrageS
    VirrageS committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    4b6305c View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2019

  1. Add arguments to suggestion method call

    @VirrageS
    VirrageS committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    e047368 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2019

  1. add partialeq and eq to cursor

    @Luro02
    Luro02 committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    89986a3 View commit details
    Browse the repository at this point in the history

  2. Improve JS code a bit by avoid erasing all event handlers

    @GuillaumeGomez
    GuillaumeGomez committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    4ce2384 View commit details
    Browse the repository at this point in the history

  3. Improve code readability

    @GuillaumeGomez
    GuillaumeGomez committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    b677013 View commit details
    Browse the repository at this point in the history

  4. Fix invalid results showing back

    @GuillaumeGomez
    GuillaumeGomez committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    71ff18f View commit details
    Browse the repository at this point in the history

  5. Extend suggestion span to whole method call

    @VirrageS
    VirrageS committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    9273f59 View commit details
    Browse the repository at this point in the history

  6. Use is_none instead of if let

    @JohnTitor
    JohnTitor committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    101dd7b View commit details
    Browse the repository at this point in the history

  7. Add test for issue-61747

    @JohnTitor
    JohnTitor committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    7c485cc View commit details
    Browse the repository at this point in the history

  8. Add test for issue-66205

    @JohnTitor
    JohnTitor committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    96253c2 View commit details
    Browse the repository at this point in the history

  9. Add test for issue-66270

    @JohnTitor
    JohnTitor committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    6ec3a63 View commit details
    Browse the repository at this point in the history

  10. Add test for issue-66868

    @JohnTitor
    JohnTitor committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    3265dc7 View commit details
    Browse the repository at this point in the history

  11. Add test for issue-67424

    @JohnTitor
    JohnTitor committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    40bec99 View commit details
    Browse the repository at this point in the history

  12. Apply suggestion from Centril 

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    @JohnTitor @Centril
    JohnTitor and Centril committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    e55ed79 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. Fix ICE in mir interpretation

    @oli-obk
    oli-obk committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    056dff5 View commit details
    Browse the repository at this point in the history

  2. Bless test

    @JohnTitor
    JohnTitor committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    ac05c84 View commit details
    Browse the repository at this point in the history

  3. Update src/librustc_mir/interpret/place.rs 

    Co-Authored-By: Ralf Jung <post@ralfj.de>
    @oli-obk @RalfJung
    oli-obk and RalfJung committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    5b8df34 View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#66913 - VirrageS:help-self, r=varkor 

    Suggest calling method when first argument is `self`

Closes: rust-lang#66782

I've explored different approaches for this MR but I think the most straightforward is the best one.

I've tried to find out if the methods for given type exist (to maybe have a better suggestion), but we don't collect them anywhere and collecting them is quite problematic. Moreover, collecting all the methods would require rewriting big part of the code and also could potentially include performance degradation, which I don't think is necessary for this simple case.
    @Centril
    Centril committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    bc2213e View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#67233 - Luro02:cursor_traits, r=sfackler 

    Add PartialEq and Eq to Cursor

closes rust-lang#67226
    @Centril
    Centril committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    58423a0 View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#67527 - GuillaumeGomez:results-show-too-muc… 

    …h, r=kinnison

Results show too much

Fixes rust-lang#67461.

To reproduce the current issue: search anything, then once the results appears, press escape. They should disappear then re-appear right away. This is because blurring an element triggers the "change" event.

r? @kinnison
    @Centril
    Centril committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    05c3295 View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#67543 - JohnTitor:regression-tests, r=Dylan… 

    …-DPC

Add regression tests for fixed ICEs

Closes rust-lang#61747 (fixed from 1.41.0-nightly (4007d4e 2019-12-01))
Closes rust-lang#66205 (fixed from 1.41.0-nightly (4007d4e 2019-12-01))
Closes rust-lang#66270 (fixed by rust-lang#66246)
Closes rust-lang#66868 (fixed by rust-lang#67071)
Closes rust-lang#67424 (fixed by rust-lang#67160)

Also picking a minor nit up from rust-lang#67071 with 101dd7b

r? @Centril
    @Centril
    Centril committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    286cb14 View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#67546 - oli-obk:slice_pattern_ice, r=varkor 

    Fix ICE in mir interpretation

Indices from the end start at 1 so you can immediately subtract them from the length to get the index instead of having to do an additional `-1`. Kinda documented in https://doc.rust-lang.org/nightly/nightly-rustc/rustc/mir/enum.ProjectionElem.html#variant.ConstantIndex
    @Centril
    Centril committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    4a551ff View commit details
    Browse the repository at this point in the history