Update Clippy and cargo #67661

JohnTitor · 2019-12-27T14:51:33Z

includes latest rustup and resolves dependency conflicts with cargo
Closes #67541

r? @oli-obk @Manishearth

rust-highfive · 2019-12-27T14:51:44Z

⚠️ Warning ⚠️

These commits modify submodules.

oli-obk · 2019-12-27T14:52:48Z

@bors r+ p=1

bors · 2019-12-27T14:52:50Z

📌 Commit cc454f841f1d76324ab37c7e40fec9c2eb358fe8 has been approved by oli-obk

bors · 2019-12-27T16:37:02Z

⌛ Testing commit cc454f841f1d76324ab37c7e40fec9c2eb358fe8 with merge f473bfc689dbd35766ab9394a5a71b03e72003c5...

rust-highfive · 2019-12-27T16:55:09Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-27T14:52:13.1598141Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-27T14:52:13.1618077Z ##[command]git config gc.auto 0
2019-12-27T14:52:13.1621357Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-27T14:52:13.1624929Z ##[command]git config --get-all http.proxy
2019-12-27T14:52:13.1630226Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67661/merge:refs/remotes/pull/67661/merge
---
2019-12-27T16:21:08.6292456Z  53 │ variables. [`UniversalRegions`] contains indices for all the free regions in
2019-12-27T16:21:08.6292668Z     │            ^ Server responded with 404 Not Found
2019-12-27T16:21:08.6292996Z     │
2019-12-27T16:21:08.6293038Z 
2019-12-27T16:21:08.6293592Z error: The server responded with 404 Not Found for "***/tree/master/src/librustc_mir/borrow_check/nll/region_infer/"
2019-12-27T16:21:08.6293853Z     ┌── borrow_check/region_inference.md:81:34 ───
2019-12-27T16:21:08.6294004Z     │
2019-12-27T16:21:08.6294201Z  81 │ for all regions is maintained in [the
2019-12-27T16:21:08.6294592Z     │                                  ^ Server responded with 404 Not Found
---
2019-12-27T16:21:08.6375897Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/const_eval/fn.op_to_const.html"
2019-12-27T16:21:08.6375936Z 
2019-12-27T16:21:08.6376149Z     ┌── miri.md:83:19 ───
2019-12-27T16:21:08.6376348Z     │
2019-12-27T16:21:08.6376601Z  83 │ [`ConstValue`] by [`op_to_const`]: the former representation is geared towards
2019-12-27T16:21:08.6377013Z     │
2019-12-27T16:21:08.6377059Z 
2019-12-27T16:21:08.6377101Z Error: One or more incorrect links
2019-12-27T16:21:08.6377183Z 
---
2019-12-27T16:31:43.1004952Z test [ui] ui/crashes/ice-2594.rs ... ok
2019-12-27T16:31:43.1658163Z test [ui] ui/crashes/ice-2727.rs ... ok
2019-12-27T16:31:43.6281154Z test [ui] ui/crashes/ice-2760.rs ... ok
2019-12-27T16:31:43.6681507Z normalized stderr:
2019-12-27T16:31:43.6682479Z thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()', src/librustc/ty/sty.rs:924:9
2019-12-27T16:31:43.6682648Z 
2019-12-27T16:31:43.6682704Z error: internal compiler error: unexpected panic
2019-12-27T16:31:43.6682730Z 
2019-12-27T16:31:43.6682795Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T16:31:43.6682795Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T16:31:43.6682819Z 
2019-12-27T16:31:43.6683249Z note: we would appreciate a bug report: ***-clippy/issues/new
2019-12-27T16:31:43.6683279Z 
2019-12-27T16:31:43.6683651Z note: Clippy version: clippy 0.0.212 (0fcb530 2019-12-27)
2019-12-27T16:31:43.6683729Z 
2019-12-27T16:31:43.6683749Z 
2019-12-27T16:31:43.6683783Z expected stderr:
2019-12-27T16:31:43.6683804Z 
2019-12-27T16:31:43.6683804Z 
2019-12-27T16:31:43.6683823Z 
2019-12-27T16:31:43.6683873Z diff of stderr:
2019-12-27T16:31:43.6683894Z 
2019-12-27T16:31:43.6684163Z +thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()', src/librustc/ty/sty.rs:924:9
2019-12-27T16:31:43.6684267Z +
2019-12-27T16:31:43.6684303Z +error: internal compiler error: unexpected panic
2019-12-27T16:31:43.6684335Z +
2019-12-27T16:31:43.6684391Z +note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T16:31:43.6684391Z +note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T16:31:43.6684548Z +
2019-12-27T16:31:43.6684839Z +note: we would appreciate a bug report: ***-clippy/issues/new
2019-12-27T16:31:43.6684878Z +
2019-12-27T16:31:43.6685071Z +note: Clippy version: clippy 0.0.212 (0fcb530 2019-12-27)
2019-12-27T16:31:43.6685162Z +
2019-12-27T16:31:43.6685182Z 
2019-12-27T16:31:43.6685217Z The actual stderr differed from the expected stderr.
2019-12-27T16:31:43.6685534Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-f1e112bfe6e65d12/out/test_build_base/crashes/ice-2774.stderr
---
2019-12-27T16:31:43.6687892Z 
2019-12-27T16:31:43.6688061Z ------------------------------------------
2019-12-27T16:31:43.6688097Z stderr:
2019-12-27T16:31:43.6688286Z ------------------------------------------
2019-12-27T16:31:43.6688510Z thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()', src/librustc/ty/sty.rs:924:9
2019-12-27T16:31:43.6688609Z 
2019-12-27T16:31:43.6688720Z error: internal compiler error: unexpected panic
2019-12-27T16:31:43.6688749Z 
2019-12-27T16:31:43.6688784Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T16:31:43.6688784Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T16:31:43.6688825Z 
2019-12-27T16:31:43.6689089Z note: we would appreciate a bug report: ***-clippy/issues/new
2019-12-27T16:31:43.6689116Z 
2019-12-27T16:31:43.6689325Z note: Clippy version: clippy 0.0.212 (0fcb530 2019-12-27)
2019-12-27T16:31:43.6689371Z 
2019-12-27T16:31:43.6689539Z ------------------------------------------
2019-12-27T16:31:43.6689563Z 
2019-12-27T16:31:43.6689750Z test [ui] ui/crashes/ice-2774.rs ... FAILED
---
2019-12-27T16:46:19.3333581Z    Compiling cargo v0.43.0 (/checkout/src/tools/cargo)
2019-12-27T16:46:43.0778847Z error[E0308]: mismatched types
2019-12-27T16:46:43.0796685Z    --> src/tools/rls/rls/src/build/cargo.rs:667:67
2019-12-27T16:46:43.0798740Z     |
2019-12-27T16:46:43.0799065Z 667 |             .or_insert_with(|| ConfigValue::Table(HashMap::new(), config_path.clone()));
2019-12-27T16:46:43.0802737Z     |                                                                   |
2019-12-27T16:46:43.0802737Z     |                                                                   |
2019-12-27T16:46:43.0803162Z     |                                                                   expected enum `cargo::util::config::value::Definition`, found struct `std::path::PathBuf`
2019-12-27T16:46:43.0803575Z     |                                                                   help: try using a variant of the expected enum: `cargo::util::config::value::Definition::Path(config_path.clone())`
2019-12-27T16:46:43.5261389Z error[E0308]: mismatched types
2019-12-27T16:46:43.5261941Z    --> src/tools/rls/rls/src/build/cargo.rs:689:56
2019-12-27T16:46:43.5262146Z     |
2019-12-27T16:46:43.5262146Z     |
2019-12-27T16:46:43.5262422Z 689 |         let td_value = ConfigValue::String(target_dir, config_path);
2019-12-27T16:46:43.5263041Z     |                                                        |
2019-12-27T16:46:43.5263041Z     |                                                        |
2019-12-27T16:46:43.5263407Z     |                                                        expected enum `cargo::util::config::value::Definition`, found struct `std::path::PathBuf`
2019-12-27T16:46:43.5263768Z     |                                                        help: try using a variant of the expected enum: `cargo::util::config::value::Definition::Path(config_path)`
2019-12-27T16:46:44.1949511Z error[E0061]: this function takes 9 parameters but 8 parameters were supplied
2019-12-27T16:46:44.1949827Z   --> src/tools/rls/rls/src/project_model.rs:51:16
2019-12-27T16:46:44.1950112Z    |
2019-12-27T16:46:44.1950112Z    |
2019-12-27T16:46:44.1950537Z 51 |         config.configure(0, Some(true), &None, false, false, false, &None, &[])?;
2019-12-27T16:46:44.1950911Z 
2019-12-27T16:46:44.5482506Z error: aborting due to 3 previous errors
2019-12-27T16:46:44.5482594Z 
2019-12-27T16:46:44.5487737Z Some errors have detailed explanations: E0061, E0308.
---
2019-12-27T16:55:02.1459477Z Verifying status of rustfmt...
2019-12-27T16:55:02.1459695Z Verifying status of clippy-driver...
2019-12-27T16:55:02.1459961Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-12-27T16:55:02.1459994Z 
2019-12-27T16:55:02.1460411Z We detected that this PR updated 'clippy-driver', but its tests failed.
2019-12-27T16:55:02.1460441Z 
2019-12-27T16:55:02.1461025Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-12-27T16:55:02.1461120Z commit another update.
2019-12-27T16:55:02.1461166Z 
2019-12-27T16:55:02.1461480Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-12-27T16:55:02.1461710Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-12-27T16:55:02.1461771Z proper steps.
2019-12-27T16:55:02.1467625Z Build completed unsuccessfully in 0:00:01
2019-12-27T16:55:02.1519595Z == clock drift check ==
2019-12-27T16:55:02.1536350Z   local time: Fri Dec 27 16:55:02 UTC 2019
2019-12-27T16:55:02.6797295Z   network time: Fri, 27 Dec 2019 16:55:02 GMT
2019-12-27T16:55:02.6797295Z   network time: Fri, 27 Dec 2019 16:55:02 GMT
2019-12-27T16:55:02.6797915Z == end clock drift check ==
2019-12-27T16:55:03.9314538Z 
2019-12-27T16:55:03.9380597Z ##[error]Bash exited with code '1'.
2019-12-27T16:55:03.9416845Z ##[section]Starting: Checkout
2019-12-27T16:55:03.9418402Z ==============================================================================
2019-12-27T16:55:03.9418468Z Task         : Get sources
2019-12-27T16:55:03.9418504Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-12-27T18:40:32Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-27T18:05:32.5977228Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/const_eval/fn.op_to_const.html"
2019-12-27T18:05:32.5977299Z 
2019-12-27T18:05:32.5977528Z     ┌── miri.md:83:19 ───
2019-12-27T18:05:32.5977890Z     │
2019-12-27T18:05:32.5978640Z  83 │ [`ConstValue`] by [`op_to_const`]: the former representation is geared towards
2019-12-27T18:05:32.5979460Z     │
2019-12-27T18:05:32.5979502Z 
2019-12-27T18:05:32.5979582Z Error: One or more incorrect links
2019-12-27T18:05:32.6030304Z Building stage2 tool clippy-driver (x86_64-unknown-linux-gnu)
---
2019-12-27T18:16:17.9474681Z test [ui] ui/crashes/ice-2594.rs ... ok
2019-12-27T18:16:18.1756051Z test [ui] ui/crashes/ice-2727.rs ... ok
2019-12-27T18:16:18.4277829Z test [ui] ui/crashes/ice-2760.rs ... ok
2019-12-27T18:16:18.6233442Z normalized stderr:
2019-12-27T18:16:18.6240959Z thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()', src/librustc/ty/sty.rs:924:9
2019-12-27T18:16:18.6241196Z 
2019-12-27T18:16:18.6241266Z error: internal compiler error: unexpected panic
2019-12-27T18:16:18.6241303Z 
2019-12-27T18:16:18.6241371Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T18:16:18.6241371Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T18:16:18.6241408Z 
2019-12-27T18:16:18.6241692Z note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new
2019-12-27T18:16:18.6241762Z 
2019-12-27T18:16:18.6241990Z note: Clippy version: clippy 0.0.212 (0fcb530 2019-12-27)
2019-12-27T18:16:18.6249182Z 
2019-12-27T18:16:18.6250575Z 
2019-12-27T18:16:18.6252565Z expected stderr:
2019-12-27T18:16:18.6254022Z 
2019-12-27T18:16:18.6254022Z 
2019-12-27T18:16:18.6258962Z 
2019-12-27T18:16:18.6261979Z diff of stderr:
2019-12-27T18:16:18.6263685Z 
2019-12-27T18:16:18.6267701Z +thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()', src/librustc/ty/sty.rs:924:9
2019-12-27T18:16:18.6305095Z +
2019-12-27T18:16:18.6305448Z +error: internal compiler error: unexpected panic
2019-12-27T18:16:18.6305688Z +
2019-12-27T18:16:18.6305787Z +note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T18:16:18.6305787Z +note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T18:16:18.6305864Z +
2019-12-27T18:16:18.6306453Z +note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new
2019-12-27T18:16:18.6306550Z +
2019-12-27T18:16:18.6306893Z +note: Clippy version: clippy 0.0.212 (0fcb530 2019-12-27)
2019-12-27T18:16:18.6307050Z +
2019-12-27T18:16:18.6307088Z 
2019-12-27T18:16:18.6307177Z The actual stderr differed from the expected stderr.
2019-12-27T18:16:18.6307668Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-2d9b2f14cb2e358b/out/test_build_base/crashes/ice-2774.stderr
2019-12-27T18:16:18.6307668Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-2d9b2f14cb2e358b/out/test_build_base/crashes/ice-2774.stderr
2019-12-27T18:16:18.6307826Z To update references, run this command from build directory:
2019-12-27T18:16:18.6308574Z tests/ui/update-references.sh '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-2d9b2f14cb2e358b/out/test_build_base' 'crashes/ice-2774.rs'
2019-12-27T18:16:18.6308852Z 
2019-12-27T18:16:18.6309112Z error: 1 errors occurred comparing output.
2019-12-27T18:16:18.6309166Z status: exit code: 101
2019-12-27T18:16:18.6310927Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/clippy-driver" "tests/ui/crashes/ice-2774.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-2d9b2f14cb2e358b/out/test_build_base" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-2d9b2f14cb2e358b/out/test_build_base/crashes/ice-2774.stage-id" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-Dwarnings" "-Zui-testing" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-87059d2b2cc41bb9.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-a05b3223ced77470.rlib" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-492e94bb4f14fcd4.rlib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-2d9b2f14cb2e358b/out/test_build_base/crashes/ice-2774.stage-id.aux" "-A" "unused"
2019-12-27T18:16:18.6311809Z ------------------------------------------
2019-12-27T18:16:18.6311883Z 
2019-12-27T18:16:18.6312094Z ------------------------------------------
2019-12-27T18:16:18.6312167Z stderr:
2019-12-27T18:16:18.6312167Z stderr:
2019-12-27T18:16:18.6312558Z ------------------------------------------
2019-12-27T18:16:18.6312859Z thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()', src/librustc/ty/sty.rs:924:9
2019-12-27T18:16:18.6313439Z 
2019-12-27T18:16:18.6313496Z error: internal compiler error: unexpected panic
2019-12-27T18:16:18.6313553Z 
2019-12-27T18:16:18.6313610Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T18:16:18.6313610Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-27T18:16:18.6313650Z 
2019-12-27T18:16:18.6313947Z note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new
2019-12-27T18:16:18.6314004Z 
2019-12-27T18:16:18.6314270Z note: Clippy version: clippy 0.0.212 (0fcb530 2019-12-27)
2019-12-27T18:16:18.6314359Z 
2019-12-27T18:16:18.6314643Z ------------------------------------------
2019-12-27T18:16:18.6314689Z 
2019-12-27T18:16:18.6315391Z test [ui] ui/crashes/ice-2774.rs ... FAILED
---
2019-12-27T18:31:07.9362045Z [RUSTC-TIMING] git2 test:false 24.673
2019-12-27T18:31:14.1440926Z error[E0308]: mismatched types
2019-12-27T18:31:14.1442095Z    --> src/tools/rls/rls/src/build/cargo.rs:667:67
2019-12-27T18:31:14.1443160Z     |
2019-12-27T18:31:14.1443769Z 667 |             .or_insert_with(|| ConfigValue::Table(HashMap::new(), config_path.clone()));
2019-12-27T18:31:14.1445141Z     |                                                                   |
2019-12-27T18:31:14.1445141Z     |                                                                   |
2019-12-27T18:31:14.1446021Z     |                                                                   expected enum `cargo::util::config::value::Definition`, found struct `std::path::PathBuf`
2019-12-27T18:31:14.1447091Z     |                                                                   help: try using a variant of the expected enum: `cargo::util::config::value::Definition::Path(config_path.clone())`
2019-12-27T18:31:14.6164825Z error[E0308]: mismatched types
2019-12-27T18:31:14.6165243Z    --> src/tools/rls/rls/src/build/cargo.rs:689:56
2019-12-27T18:31:14.6165483Z     |
2019-12-27T18:31:14.6165483Z     |
2019-12-27T18:31:14.6165811Z 689 |         let td_value = ConfigValue::String(target_dir, config_path);
2019-12-27T18:31:14.6166468Z     |                                                        |
2019-12-27T18:31:14.6166468Z     |                                                        |
2019-12-27T18:31:14.6166900Z     |                                                        expected enum `cargo::util::config::value::Definition`, found struct `std::path::PathBuf`
2019-12-27T18:31:14.6167528Z     |                                                        help: try using a variant of the expected enum: `cargo::util::config::value::Definition::Path(config_path)`
2019-12-27T18:31:15.3389055Z error[E0061]: this function takes 9 parameters but 8 parameters were supplied
2019-12-27T18:31:15.3389509Z   --> src/tools/rls/rls/src/project_model.rs:51:16
2019-12-27T18:31:15.3389845Z    |
2019-12-27T18:31:15.3389845Z    |
2019-12-27T18:31:15.3390261Z 51 |         config.configure(0, Some(true), &None, false, false, false, &None, &[])?;
2019-12-27T18:31:15.3394908Z 
2019-12-27T18:31:15.7018704Z error: aborting due to 3 previous errors
2019-12-27T18:31:15.7022798Z 
2019-12-27T18:31:15.7032857Z Some errors have detailed explanations: E0061, E0308.
---
2019-12-27T18:39:33.7746536Z Verifying status of rustfmt...
2019-12-27T18:39:33.7746784Z Verifying status of clippy-driver...
2019-12-27T18:39:33.7747052Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-12-27T18:39:33.7747489Z 
2019-12-27T18:39:33.7747782Z We detected that this PR updated 'clippy-driver', but its tests failed.
2019-12-27T18:39:33.7748032Z 
2019-12-27T18:39:33.7748491Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-12-27T18:39:33.7748594Z commit another update.
2019-12-27T18:39:33.7748635Z 
2019-12-27T18:39:33.7748925Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-12-27T18:39:33.7749245Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-12-27T18:39:33.7749343Z proper steps.
2019-12-27T18:39:33.7753983Z Build completed unsuccessfully in 0:00:01
2019-12-27T18:39:33.7843829Z == clock drift check ==
2019-12-27T18:39:33.7856778Z   local time: Fri Dec 27 18:39:33 UTC 2019
2019-12-27T18:39:34.0864075Z   network time: Fri, 27 Dec 2019 18:39:34 GMT
2019-12-27T18:39:34.0864075Z   network time: Fri, 27 Dec 2019 18:39:34 GMT
2019-12-27T18:39:34.0866141Z == end clock drift check ==
2019-12-27T18:39:35.2713415Z 
2019-12-27T18:39:35.2806230Z ##[error]Bash exited with code '1'.
2019-12-27T18:39:35.2842181Z ##[section]Starting: Checkout
2019-12-27T18:39:35.2844833Z ==============================================================================
2019-12-27T18:39:35.2844977Z Task         : Get sources
2019-12-27T18:39:35.2845041Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-12-27T18:40:45Z

💔 Test failed - checks-azure

rust-highfive · 2019-12-28T03:56:43Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-28T01:54:55.1464353Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-28T01:54:56.1638019Z ##[command]git config gc.auto 0
2019-12-28T01:54:56.1640201Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-28T01:54:56.1641961Z ##[command]git config --get-all http.proxy
2019-12-28T01:54:56.1644372Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67661/merge:refs/remotes/pull/67661/merge
---
2019-12-28T03:22:56.2427393Z  53 │ variables. [`UniversalRegions`] contains indices for all the free regions in
2019-12-28T03:22:56.2427644Z     │            ^ Server responded with 404 Not Found
2019-12-28T03:22:56.2428007Z     │
2019-12-28T03:22:56.2428040Z 
2019-12-28T03:22:56.2428714Z error: The server responded with 404 Not Found for "***/tree/master/src/librustc_mir/borrow_check/nll/region_infer/"
2019-12-28T03:22:56.2429012Z     ┌── borrow_check/region_inference.md:81:34 ───
2019-12-28T03:22:56.2429224Z     │
2019-12-28T03:22:56.2429447Z  81 │ for all regions is maintained in [the
2019-12-28T03:22:56.2429704Z     │                                  ^ Server responded with 404 Not Found
---
2019-12-28T03:33:41.8239235Z test [ui] ui/crashes/ice-2594.rs ... ok
2019-12-28T03:33:42.0153684Z test [ui] ui/crashes/ice-2727.rs ... ok
2019-12-28T03:33:42.3958384Z test [ui] ui/crashes/ice-2760.rs ... ok
2019-12-28T03:33:42.5626344Z normalized stderr:
2019-12-28T03:33:42.5627311Z thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()', src/librustc/ty/sty.rs:924:9
2019-12-28T03:33:42.5627652Z 
2019-12-28T03:33:42.5627697Z error: internal compiler error: unexpected panic
2019-12-28T03:33:42.5627729Z 
2019-12-28T03:33:42.5627937Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-28T03:33:42.5627937Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-28T03:33:42.5627984Z 
2019-12-28T03:33:42.5628381Z note: we would appreciate a bug report: ***-clippy/issues/new
2019-12-28T03:33:42.5628438Z 
2019-12-28T03:33:42.5628725Z note: Clippy version: clippy 0.0.212 (0fec590 2019-12-27)
2019-12-28T03:33:42.5628782Z 
2019-12-28T03:33:42.5628806Z 
2019-12-28T03:33:42.5628845Z expected stderr:
2019-12-28T03:33:42.5628888Z 
2019-12-28T03:33:42.5628888Z 
2019-12-28T03:33:42.5628912Z 
2019-12-28T03:33:42.5628950Z diff of stderr:
2019-12-28T03:33:42.5628976Z 
2019-12-28T03:33:42.5629280Z +thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()', src/librustc/ty/sty.rs:924:9
2019-12-28T03:33:42.5629402Z +
2019-12-28T03:33:42.5629463Z +error: internal compiler error: unexpected panic
2019-12-28T03:33:42.5629502Z +
2019-12-28T03:33:42.5629544Z +note: the compiler unexpectedly panicked. this is a bug.
2019-12-28T03:33:42.5629544Z +note: the compiler unexpectedly panicked. this is a bug.
2019-12-28T03:33:42.5629585Z +
2019-12-28T03:33:42.5630068Z +note: we would appreciate a bug report: ***-clippy/issues/new
2019-12-28T03:33:42.5630119Z +
2019-12-28T03:33:42.5630400Z +note: Clippy version: clippy 0.0.212 (0fec590 2019-12-27)
2019-12-28T03:33:42.5630486Z +
2019-12-28T03:33:42.5630511Z 
2019-12-28T03:33:42.5630571Z The actual stderr differed from the expected stderr.
2019-12-28T03:33:42.5630957Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-473cade6e98745d4/out/test_build_base/crashes/ice-2774.stderr
---
2019-12-28T03:33:42.5634319Z 
2019-12-28T03:33:42.5634565Z ------------------------------------------
2019-12-28T03:33:42.5634612Z stderr:
2019-12-28T03:33:42.5635008Z ------------------------------------------
2019-12-28T03:33:42.5635647Z thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()', src/librustc/ty/sty.rs:924:9
2019-12-28T03:33:42.5635783Z 
2019-12-28T03:33:42.5635831Z error: internal compiler error: unexpected panic
2019-12-28T03:33:42.5635879Z 
2019-12-28T03:33:42.5635926Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-28T03:33:42.5635926Z note: the compiler unexpectedly panicked. this is a bug.
2019-12-28T03:33:42.5635957Z 
2019-12-28T03:33:42.5636294Z note: we would appreciate a bug report: ***-clippy/issues/new
2019-12-28T03:33:42.5636517Z 
2019-12-28T03:33:42.5636772Z note: Clippy version: clippy 0.0.212 (0fec590 2019-12-27)
2019-12-28T03:33:42.5636842Z 
2019-12-28T03:33:42.5637252Z ------------------------------------------
2019-12-28T03:33:42.5637289Z 
2019-12-28T03:33:42.5637514Z test [ui] ui/crashes/ice-2774.rs ... FAILED
---
2019-12-28T03:56:27.7479464Z Verifying status of rustfmt...
2019-12-28T03:56:27.7480214Z Verifying status of clippy-driver...
2019-12-28T03:56:27.7480523Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-12-28T03:56:27.7480556Z 
2019-12-28T03:56:27.7480775Z We detected that this PR updated 'clippy-driver', but its tests failed.
2019-12-28T03:56:27.7480806Z 
2019-12-28T03:56:27.7481042Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-12-28T03:56:27.7481086Z commit another update.
2019-12-28T03:56:27.7481109Z 
2019-12-28T03:56:27.7481317Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-12-28T03:56:27.7481544Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-12-28T03:56:27.7481593Z proper steps.
2019-12-28T03:56:27.7482973Z Build completed unsuccessfully in 0:00:01
2019-12-28T03:56:27.7537413Z == clock drift check ==
2019-12-28T03:56:27.7603815Z   local time: Sat Dec 28 03:56:27 UTC 2019
2019-12-28T03:56:28.0529191Z   network time: Sat, 28 Dec 2019 03:56:28 GMT
2019-12-28T03:56:28.0529191Z   network time: Sat, 28 Dec 2019 03:56:28 GMT
2019-12-28T03:56:28.0530641Z == end clock drift check ==
2019-12-28T03:56:29.3636516Z 
2019-12-28T03:56:29.3735359Z ##[error]Bash exited with code '1'.
2019-12-28T03:56:29.3800843Z ##[section]Starting: Checkout
2019-12-28T03:56:29.3802437Z ==============================================================================
2019-12-28T03:56:29.3802492Z Task         : Get sources
2019-12-28T03:56:29.3802532Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

JohnTitor · 2019-12-28T04:23:39Z

Ugh, might be related to latest rustup?

JohnTitor · 2019-12-28T08:04:42Z

The ICE on the test is only shown on rustc CI (the situation is same as #64963 (comment)).
@oli-obk could we remove this test for now?

JohnTitor · 2019-12-28T10:24:07Z

backtrace

thread 'rustc' panicked at 'assertion failed: !value.has_escaping_bound_vars()', src/librustc/ty/sty.rs:924:9
stack backtrace:
   0: backtrace::backtrace::trace_unsynchronized
   1: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   2: core::fmt::write
   3: std::io::Write::write_fmt
   4: std::panicking::take_hook
   5: std::panicking::take_hook
   6: clippy_driver::report_clippy_ice
   7: std::panicking::rust_panic_with_hook
   8: std::panicking::begin_panic
   9: rustc::traits::type_known_to_meet_bound_modulo_regions
  10: rustc::ty::context::GlobalCtxt::enter_local
  11: rustc::ty::util::is_freeze_raw
  12: rustc::ty::util::is_freeze_raw
  13: rustc::ty::query::__query_compute::is_freeze_raw
  14: <rustc::traits::Vtable<N> as core::clone::Clone>::clone
  15: rustc::dep_graph::graph::DepGraph::with_task_impl
  16: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::get_query
  17: rustc::ty::util::<impl rustc::ty::TyS>::is_freeze
  18: <clippy_lints::mut_key::MutableKeyType as rustc::lint::LateLintPass>::check_local
  19: <clippy_lints::mut_key::MutableKeyType as rustc::lint::LateLintPass>::check_local
  20: <rustc::lint::context::LateLintPassObjects as rustc::lint::LateLintPass>::check_item
  21: rustc::hir::intravisit::Visitor::visit_nested_item
  22: rustc::hir::intravisit::walk_crate
  23: rustc::lint::context::late_lint_pass_crate
  24: rustc::lint::context::late_lint_crate
  25: rustc::util::common::time
  26: rustc::util::common::time
  27: std::panicking::begin_panic
  28: _rust_maybe_catch_panic
  29: std::panicking::try::do_call
  30: _rust_maybe_catch_panic
  31: std::panic::catch_unwind
  32: rustc_interface::passes::analysis::{{closure}}
  33: rustc_interface::passes::create_global_ctxt
  34: rustc::ty::query::__query_compute::analysis
  35: rustc::dep_graph::graph::DepGraph::with_task_impl
  36: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::get_query
  37: rustc::ty::context::tls::enter_global
  38: rustc_interface::interface::run_compiler_in_existing_thread_pool
  39: std::thread::local::LocalKey<T>::with
  40: scoped_tls::ScopedKey<T>::set
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.0.212 (0fec5905 2019-12-27)

query stack during panic:
#0 [is_freeze_raw] computing whether `&'a Bar` is freeze
#1 [analysis] running analysis passes on this crate
end of query stack

oli-obk · 2019-12-28T11:44:39Z

You may be able fix it by erasing regions on key_type https://github.com/rust-lang/rust-clippy/blame/0fcb5304e27a747267276cdbac720f4bd2672172/clippy_lints/src/mut_key.rs#L106

The reason it fails on CI and not in clippy is probably because that is a debug_assertion and not an assert, so if you build clippy with a rustc built with debug assertions you'll see the same failure.

JohnTitor · 2019-12-28T12:36:17Z

Thanks! But the suggested fix didn't work well (I tested dirty-submodule with debug_assertions=yes).
I tested with as follows:

- let key_type = substs.type_at(0);
+ let key_type = cx.tcx.erase_regions(&substs.type_at(0));

any thoughts?

oli-obk · 2019-12-28T13:03:18Z

Well... as far as I can tell the clippy code is actually not really interested in the frozenness of the reference, but on the frozenness of the things behind it. Maybe if https://github.com/rust-lang/rust-clippy/blame/0fcb5304e27a747267276cdbac720f4bd2672172/clippy_lints/src/mut_key.rs#L114 returned an Option<Ty<'tcx>> and gave us the inner most type to check (so wherever it's true, just return the type), then that may work.

JohnTitor · 2019-12-28T13:38:40Z

yeah, it seems an ICE has been gone, at least on my local. I submitted a fix rust-lang/rust-clippy#4964

@oli-obk

Possibly fix an ICE on test Fix a potential ICE on test with debug assertion, caused on rust-lang/rust#67661. r? @oli-obk changelog: none

JohnTitor · 2019-12-28T21:15:18Z

It seems the test has been passed (checked on Linux x86_64-gnu-tools).
r? @oli-obk

oli-obk · 2019-12-29T00:19:16Z

@bors r+ p=1

bors · 2019-12-29T00:19:17Z

📌 Commit 107106a6a3febee0746597ee08b18346d9c46cc9 has been approved by oli-obk

bors · 2019-12-29T02:11:44Z

⌛ Testing commit 107106a6a3febee0746597ee08b18346d9c46cc9 with merge 9f05033d2755d9a938a74eb696e883c9caf83a52...

JohnTitor · 2019-12-29T02:20:34Z

It seems rustup for latest master is needed... (travis on clippy)
@bors retry r-

JohnTitor · 2019-12-29T08:09:08Z

feel free to r- if someone has a concern
@bors r=oli-obk

bors · 2019-12-29T08:09:09Z

📌 Commit f541e91 has been approved by oli-obk

bors · 2019-12-29T08:09:10Z

🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened

JohnTitor · 2019-12-29T08:13:03Z

Homu queue points a resolved comment so it's unintended?
@bors treeclosed-

bors · 2019-12-29T16:13:07Z

⌛ Testing commit f541e91 with merge 25434f8...

@oli-obk

Update Clippy and cargo includes latest rustup and resolves dependency conflicts with cargo Closes #67541 r? @oli-obk @Manishearth

bors · 2019-12-29T19:30:47Z

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 25434f8 to master...

rust-highfive · 2019-12-29T19:32:14Z

📣 Toolstate changed by #67661!

Tested on commit 25434f8.
Direct link to PR: #67661

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).

@mcarton

Tested on commit rust-lang/rust@25434f8. Direct link to PR: <rust-lang/rust#67661> 🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive assigned oli-obk Dec 27, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2019

JohnTitor force-pushed the clippy-cargo branch from cc454f8 to 14084c9 Compare December 28, 2019 01:54

flip1995 mentioned this pull request Dec 28, 2019

Update Clippy and cargo #67528

Closed

JohnTitor mentioned this pull request Dec 28, 2019

Possibly fix an ICE on test rust-lang/rust-clippy#4964

Merged

JohnTitor force-pushed the clippy-cargo branch from 14084c9 to 107106a Compare December 28, 2019 19:06

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 29, 2019

JohnTitor added 3 commits December 29, 2019 17:03

Update Clippy

a102e9b

Update cargo

6f1ebf8

Update Cargo.lock

f541e91

JohnTitor force-pushed the clippy-cargo branch from 107106a to f541e91 Compare December 29, 2019 08:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 29, 2019

bors added a commit that referenced this pull request Dec 29, 2019

Auto merge of #67661 - JohnTitor:clippy-cargo, r=oli-obk

25434f8

Update Clippy and cargo includes latest rustup and resolves dependency conflicts with cargo Closes #67541 r? @oli-obk @Manishearth

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 29, 2019

bors merged commit f541e91 into rust-lang:master Dec 29, 2019

rust-highfive mentioned this pull request Dec 29, 2019

rls no longer builds after rust-lang/rust#67661 #67708

Closed

JohnTitor deleted the clippy-cargo branch December 29, 2019 19:57

rossmacarthur mentioned this pull request Jan 7, 2020

Remove use of issue = "0" in submodules (stdarch, cargo, and rustfmt) #67496

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Clippy and cargo #67661

Update Clippy and cargo #67661

JohnTitor commented Dec 27, 2019 •

edited

rust-highfive commented Dec 27, 2019

oli-obk commented Dec 27, 2019

bors commented Dec 27, 2019

bors commented Dec 27, 2019

rust-highfive commented Dec 27, 2019

rust-highfive commented Dec 27, 2019

bors commented Dec 27, 2019

rust-highfive commented Dec 28, 2019

JohnTitor commented Dec 28, 2019

JohnTitor commented Dec 28, 2019 •

edited

JohnTitor commented Dec 28, 2019

oli-obk commented Dec 28, 2019

JohnTitor commented Dec 28, 2019

oli-obk commented Dec 28, 2019

JohnTitor commented Dec 28, 2019

JohnTitor commented Dec 28, 2019

oli-obk commented Dec 29, 2019

bors commented Dec 29, 2019

bors commented Dec 29, 2019

JohnTitor commented Dec 29, 2019 •

edited

JohnTitor commented Dec 29, 2019

bors commented Dec 29, 2019

bors commented Dec 29, 2019

JohnTitor commented Dec 29, 2019

bors commented Dec 29, 2019

bors commented Dec 29, 2019

rust-highfive commented Dec 29, 2019

Update Clippy and cargo #67661

Update Clippy and cargo #67661

Conversation

JohnTitor commented Dec 27, 2019 • edited

rust-highfive commented Dec 27, 2019

oli-obk commented Dec 27, 2019

bors commented Dec 27, 2019

bors commented Dec 27, 2019

rust-highfive commented Dec 27, 2019

rust-highfive commented Dec 27, 2019

bors commented Dec 27, 2019

rust-highfive commented Dec 28, 2019

JohnTitor commented Dec 28, 2019

JohnTitor commented Dec 28, 2019 • edited

JohnTitor commented Dec 28, 2019

oli-obk commented Dec 28, 2019

JohnTitor commented Dec 28, 2019

oli-obk commented Dec 28, 2019

JohnTitor commented Dec 28, 2019

JohnTitor commented Dec 28, 2019

oli-obk commented Dec 29, 2019

bors commented Dec 29, 2019

bors commented Dec 29, 2019

JohnTitor commented Dec 29, 2019 • edited

JohnTitor commented Dec 29, 2019

bors commented Dec 29, 2019

bors commented Dec 29, 2019

JohnTitor commented Dec 29, 2019

bors commented Dec 29, 2019

bors commented Dec 29, 2019

rust-highfive commented Dec 29, 2019

JohnTitor commented Dec 27, 2019 •

edited

JohnTitor commented Dec 28, 2019 •

edited

JohnTitor commented Dec 29, 2019 •

edited