Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we process projections during MIR inlining #67796

Merged
merged 1 commit into from Jan 3, 2020

Conversation

@Aaron1011
Copy link
Contributor

Aaron1011 commented Jan 2, 2020

Fixes #67710

Previously, we were not calling super_place, which resulted in us
failing to update any local references that occur in
ProjectionElem::Index. This caused the post-inlining MIR to contain a
reference to a local ID from the inlined callee, leading to an ICE
due to a type mismatch.

Fixes #67710

Previously, we were not calling `super_place`, which resulted in us
failing to update any local references that occur in
ProjectionElem::Index. This caused the post-inlining MIR to contain a
reference to a local ID from the inlined callee, leading to an ICE
due to a type mismatch.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 2, 2020

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@wesleywiser

This comment has been minimized.

Copy link
Member

wesleywiser commented Jan 2, 2020

@wesleywiser

This comment has been minimized.

Copy link
Member

wesleywiser commented Jan 2, 2020

Thanks!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2020

📌 Commit e8e53b5 has been approved by wesleywiser

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 3, 2020
…sleywiser

Ensure that we process projections during MIR inlining

Fixes rust-lang#67710

Previously, we were not calling `super_place`, which resulted in us
failing to update any local references that occur in
ProjectionElem::Index. This caused the post-inlining MIR to contain a
reference to a local ID from the inlined callee, leading to an ICE
due to a type mismatch.
bors added a commit that referenced this pull request Jan 3, 2020
Rollup of 10 pull requests

Successful merges:

 - #67450 (Allow for setting a ThinLTO import limit during bootstrap)
 - #67595 (Suggest adding a lifetime constraint for opaque type)
 - #67636 (allow rustfmt key in [build] section)
 - #67736 (Less-than is asymmetric, not antisymmetric)
 - #67762 (Add missing links for insecure_time)
 - #67783 (Warn for bindings named same as variants when matching against a borrow)
 - #67796 (Ensure that we process projections during MIR inlining)
 - #67807 (Use drop instead of the toilet closure `|_| ()`)
 - #67816 (Clean up err codes)
 - #67825 (Minor: change take() docs grammar to match other docs)

Failed merges:

r? @ghost
@bors bors merged commit e8e53b5 into rust-lang:master Jan 3, 2020
4 checks passed
4 checks passed
pr Build #20200102.5 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.