Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant clones, found by clippy #68252

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 15, 2020

r? @oli-obk
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 15, 2020

📌 Commit 312c3a0 has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb Jan 15, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 15, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 15, 2020
…i-obk

remove redundant clones, found by clippy
bors added a commit that referenced this pull request Jan 15, 2020
Rollup of 6 pull requests

Successful merges:

 - #68123 (Implement Cursor for linked lists. (RFC 2570).)
 - #68212 (Suggest to shorten temporary lifetime during method call inside generator)
 - #68232 (Optimize size/speed of Unicode datasets)
 - #68236 (Add some regression tests)
 - #68237 (Account for `Path`s in `is_suggestable_infer_ty`)
 - #68252 (remove redundant clones, found by clippy)

Failed merges:

r? @ghost
@bors bors merged commit 312c3a0 into rust-lang:master Jan 15, 2020
@eddyb
Copy link
Member

eddyb commented Jan 16, 2020

This reminds me, are we linting .clone() on Copy types yet?

@sinkuu
Copy link
Contributor

sinkuu commented Jan 16, 2020

There's clone_on_copy lint.

@eddyb
Copy link
Member

eddyb commented Jan 16, 2020

Yeah, but are we enabling it on rustc?

@matthiaskrgr
Copy link
Member Author

None of the clippy lints are run on rustc code by "default", but you can get clippy defaults run with ./x.py clippy

Meanwhile I've prepared a PR here: #68292

@matthiaskrgr matthiaskrgr deleted the redundant_clones branch February 29, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants