Make sure that all upstream generics get re-exported from Rust dylibs. #68277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
This also makes a few edge cases slower because we can't use the query cache anymore. Let's do a perf run to make sure that the common cases are not affected. @bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit d487e9ea97a00ab704035f11cf0aab1d9f79ef5c with merge 4031484a2f96426fe9d445592c85e21d90cb229c... |
|
|
|
Looks great to me, nice! My only worry would be the number of r=me if perf comes back clean, and basically r=me if this is updated and perf comes back clean too :) |
|
@rust-timer build 4031484a2f96426fe9d445592c85e21d90cb229c |
|
Queued 4031484a2f96426fe9d445592c85e21d90cb229c with parent 9fe05e9, future comparison URL. |
|
Finished benchmarking try commit 4031484a2f96426fe9d445592c85e21d90cb229c, comparison URL. |
|
@bors r=alexcrichton rollup=never |
|
📌 Commit 87ce8df4364d4f0e5c208ba67ab3ca835963a5ee has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 87ce8df4364d4f0e5c208ba67ab3ca835963a5ee with merge 11f1e2b4a192294745df71d3e11d0704146e6c6a... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
The regression test is originally from rust-lang#64324 but was removed again after the fix in there turned out to break other things.
michaelwoerister
force-pushed
the
re-export-dylib-instances
branch
from
87ce8df
to
0a9bcb0
Compare
|
Rebased and moved the test cases from |
|
@bors r=alexcrichton |
|
📌 Commit 0a9bcb0 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 20, 2020
…alexcrichton Make sure that all upstream generics get re-exported from Rust dylibs. This PR contains a fix for #67276. Rust dylibs would not re-export all generic instances when compiling with `-Zshare-generics=on` (=default for debug builds) which could lead to situations where the compiler expected certain generic instances to be available but then the linker would not find them. ### TODO - [x] Write a regression test based on the description [here](#67276 (comment)). - [x] Find out if this also fixes other issues related to #64319. r? @alexcrichton ~~(once the TODOs are done)~~ cc @pnkfelix @alexkornitzer
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for #67276. Rust dylibs would not re-export all generic instances when compiling with
-Zshare-generics=on(=default for debug builds) which could lead to situations where the compiler expected certain generic instances to be available but then the linker would not find them.TODO
r? @alexcrichton
(once the TODOs are done)cc @pnkfelix @alexkornitzer