Fix some tests failing in --pass check mode
#68290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @oli-obk |
|
These deny lints were made warnings specifically to test that we don't accidentally regress them to hard errors. We can't make them hard errors (I tried arguing for hard errors in RFC 1229, but now the RFC explicitly states that these are never to become hard errors) |
|
If we accidentally regress them the output will still change, the will disappear. |
|
Sure, I get that, but that's still very subtle and only true for the first lint trigger. The subsequent ones will only change from |
petrochenkov
force-pushed
the
passcheck
branch
from
0be7b0e
to
8172850
Compare
petrochenkov
force-pushed
the
passcheck
branch
from
8172850
to
8fa8b81
Compare
|
Ok, if you think these tests must use warnings, I'll have to add |
|
@bors r+ rollup |
|
📌 Commit 8fa8b81 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 20, 2020
Fix some tests failing in `--pass check` mode Warnings reported at codegen or linking time either have to be converted to errors (preferable), or the tests for them need to be marked with `// ignore-pass` (as a last resort). rust-lang@ecd5852 turned them from errors to warnings, but that shouldn't be necessary because it's still clear from the `.stderr` output that the errors are lints and not hard-coded.
bors
added a commit
that referenced
this pull request
Jan 20, 2020
Rollup of 8 pull requests Successful merges: - #67734 (Remove appendix from Apache license) - #67795 (Cleanup formatting code) - #68290 (Fix some tests failing in `--pass check` mode) - #68297 ( Filter and test predicates using `normalize_and_test_predicates` for const-prop) - #68302 (Fix #[track_caller] and function pointers) - #68339 (Add `riscv64gc-unknown-linux-gnu` into target list in build-manifest) - #68381 (Added minor clarification to specification of GlobalAlloc::realloc.) - #68397 (rustdoc: Correct order of `async` and `unsafe` in `async unsafe fn`s) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings reported at codegen or linking time either have to be converted to errors (preferable), or the tests for them need to be marked with
// ignore-pass(as a last resort).ecd5852 turned them from errors to warnings, but that shouldn't be necessary because it's still clear from the
.stderroutput that the errors are lints and not hard-coded.