Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document remaining undocumented From implementations for IPs #68640

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Document remaining undocumented From implementations for IPs #68640

merged 1 commit into from
Jan 30, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Some From implementations were missing documentation. I added examples, I tried to be as close to existing examples as possible.

Related to #51430 (cc @skade)

r? @steveklabnik

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 29, 2020
@steveklabnik
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jan 29, 2020

📌 Commit dac0c389a960fc5226f333c7e64f9435f2c111ad has been approved by steveklabnik

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2020
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-01-29T14:15:03.3631770Z ========================== Starting Command Output ===========================
2020-01-29T14:15:03.3633232Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/cfe5c523-cd82-45a7-b618-d8abd95e767e.sh
2020-01-29T14:15:03.3633265Z 
2020-01-29T14:15:03.3636049Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-29T14:15:03.3641735Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68640/merge to s
2020-01-29T14:15:03.3643357Z Task         : Get sources
2020-01-29T14:15:03.3643392Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-29T14:15:03.3643469Z Version      : 1.0.0
2020-01-29T14:15:03.3643505Z Author       : Microsoft
---
2020-01-29T14:15:04.1535715Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-29T14:15:04.1626523Z ##[command]git config gc.auto 0
2020-01-29T14:15:04.1698886Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-29T14:15:04.1754617Z ##[command]git config --get-all http.proxy
2020-01-29T14:15:04.1875943Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68640/merge:refs/remotes/pull/68640/merge
---
2020-01-29T15:06:56.9059488Z .................................................................................................... 1700/9558
2020-01-29T15:07:01.6459115Z .................................................................................................... 1800/9558
2020-01-29T15:07:13.6018736Z .........................i.......................................................................... 1900/9558
2020-01-29T15:07:20.1844675Z .................................................................................................... 2000/9558
2020-01-29T15:07:33.8177021Z ...............iiiii................................................................................ 2100/9558
2020-01-29T15:07:43.0916898Z .................................................................................................... 2300/9558
2020-01-29T15:07:45.4358725Z .................................................................................................... 2400/9558
2020-01-29T15:07:50.2278461Z .................................................................................................... 2500/9558
2020-01-29T15:08:09.7218800Z .................................................................................................... 2600/9558
---
2020-01-29T15:10:35.3187556Z .................................................................................................... 4800/9558
2020-01-29T15:10:40.1471215Z ...........................................................i...............i........................ 4900/9558
2020-01-29T15:10:47.6093859Z .................................................................................................... 5000/9558
2020-01-29T15:10:55.1313868Z .................................................................................................... 5100/9558
2020-01-29T15:10:59.6194389Z ..i................................................................................................. 5200/9558
2020-01-29T15:11:09.6007328Z ...........................................................................ii.ii........i...i....... 5300/9558
2020-01-29T15:11:17.5610239Z .............i...................................................................................... 5500/9558
2020-01-29T15:11:26.7760524Z .................................................................................................... 5600/9558
2020-01-29T15:11:32.7865434Z ..............................................................i..................................... 5700/9558
2020-01-29T15:11:39.5557459Z .................................................................................................... 5800/9558
2020-01-29T15:11:39.5557459Z .................................................................................................... 5800/9558
2020-01-29T15:11:46.9810744Z .................................................................................................... 5900/9558
2020-01-29T15:11:55.3616295Z .....................................................ii...i..ii...........i......................... 6000/9558
2020-01-29T15:12:15.6499358Z .................................................................................................... 6200/9558
2020-01-29T15:12:21.9356327Z .................................................................................................... 6300/9558
2020-01-29T15:12:21.9356327Z .................................................................................................... 6300/9558
2020-01-29T15:12:26.1807803Z .................................................................................i..ii.............. 6400/9558
2020-01-29T15:12:50.9131181Z .................................................................................................... 6600/9558
2020-01-29T15:12:55.8887826Z .........................................................i.......................................... 6700/9558
2020-01-29T15:12:57.8641907Z .................................................................................................... 6800/9558
2020-01-29T15:12:59.8805793Z ........................................................i........................................... 6900/9558
---
2020-01-29T15:14:32.5643090Z .................................................................................................... 7600/9558
2020-01-29T15:14:37.8613087Z .................................................................................................... 7700/9558
2020-01-29T15:14:44.3844860Z .................................................................................................... 7800/9558
2020-01-29T15:14:54.6100961Z .................................................................................................... 7900/9558
2020-01-29T15:15:00.3759747Z ............iiiiiii.i............................................................................... 8000/9558
2020-01-29T15:15:13.9556225Z .................................................................................................... 8200/9558
2020-01-29T15:15:24.2165199Z .................................................................................................... 8300/9558
2020-01-29T15:15:37.0124196Z .................................................................................................... 8400/9558
2020-01-29T15:15:43.4183877Z .................................................................................................... 8500/9558
---
2020-01-29T15:17:58.6245368Z  finished in 7.081
2020-01-29T15:17:58.6439587Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T15:17:58.8036532Z 
2020-01-29T15:17:58.8037436Z running 169 tests
2020-01-29T15:18:01.6977423Z iiii......i........ii..iiii...i....i...........i............i..i..................i....i............ 100/169
2020-01-29T15:18:03.8360879Z i.i.i...iii..iiiiiiiiii.......................iii............ii......
2020-01-29T15:18:03.8365846Z 
2020-01-29T15:18:03.8369377Z  finished in 5.193
2020-01-29T15:18:03.8589909Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T15:18:04.0094833Z 
---
2020-01-29T15:18:05.9103309Z  finished in 2.051
2020-01-29T15:18:05.9310287Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T15:18:06.0815084Z 
2020-01-29T15:18:06.0815825Z running 9 tests
2020-01-29T15:18:06.0816862Z iiiiiiiii
2020-01-29T15:18:06.0817362Z 
2020-01-29T15:18:06.0822220Z  finished in 0.151
2020-01-29T15:18:06.1078674Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T15:18:06.2649610Z 
---
2020-01-29T15:18:25.7688662Z  finished in 19.661
2020-01-29T15:18:25.7888046Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T15:18:25.9446737Z 
2020-01-29T15:18:25.9447004Z running 116 tests
2020-01-29T15:18:39.0018182Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-01-29T15:18:40.8164451Z ....iiii.....ii.
2020-01-29T15:18:40.8166428Z 
2020-01-29T15:18:40.8166634Z  finished in 15.028
2020-01-29T15:18:40.8172221Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T15:18:40.8173177Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-01-29T15:30:51.7295976Z 
2020-01-29T15:30:51.7300366Z    Doc-tests core
2020-01-29T15:30:56.1386509Z 
2020-01-29T15:30:56.1387237Z running 2467 tests
2020-01-29T15:31:04.5686562Z ......iiiii......................................................................................... 100/2467
2020-01-29T15:31:12.7734894Z ..................................................................................ii................ 200/2467
2020-01-29T15:31:32.1232373Z .................i.................................................................................. 400/2467
2020-01-29T15:31:32.1232373Z .................i.................................................................................. 400/2467
2020-01-29T15:31:41.1065558Z ..................................................................i..i..................iiii........ 500/2467
2020-01-29T15:31:55.8559888Z .................................................................................................... 700/2467
2020-01-29T15:32:03.6562165Z .................................................................................................... 800/2467
2020-01-29T15:32:11.4327132Z .................................................................................................... 900/2467
2020-01-29T15:32:19.3442847Z .................................................................................................... 1000/2467
---
2020-01-29T15:35:41.6342409Z 
2020-01-29T15:35:41.6342774Z running 1007 tests
2020-01-29T15:35:58.1555273Z i................................................................................................... 100/1007
2020-01-29T15:36:07.2076345Z .................................................................................................... 200/1007
2020-01-29T15:36:13.7450156Z ..................iii......i......i...i......i...................................................... 300/1007
2020-01-29T15:36:18.6007272Z .................................................................................................... 400/1007
2020-01-29T15:36:25.2031298Z ..........................................i..i.....................................ii............... 500/1007
2020-01-29T15:36:37.3969134Z .................................................................................................... 700/1007
2020-01-29T15:36:37.3969134Z .................................................................................................... 700/1007
2020-01-29T15:36:43.7208991Z .................................iiii............................................................... 800/1007
2020-01-29T15:36:56.6825582Z .................................................................................................... 900/1007
2020-01-29T15:37:03.0845049Z .......................................................iiii......................................... 1000/1007
2020-01-29T15:37:03.3894444Z failures:
2020-01-29T15:37:03.3895784Z 
2020-01-29T15:37:03.3900703Z ---- net/ip.rs - net::ip::IpAddr::from (line 820) stdout ----
2020-01-29T15:37:03.3900798Z error[E0433]: failed to resolve: use of undeclared type or module `Ipv4Addr`
2020-01-29T15:37:03.3900798Z error[E0433]: failed to resolve: use of undeclared type or module `Ipv4Addr`
2020-01-29T15:37:03.3901082Z  --> net/ip.rs:823:12
2020-01-29T15:37:03.3901133Z   |
2020-01-29T15:37:03.3901183Z 6 | let addr = Ipv4Addr::new(127, 0, 0, 1);
2020-01-29T15:37:03.3901255Z   |            ^^^^^^^^ use of undeclared type or module `Ipv4Addr`
2020-01-29T15:37:03.3901339Z error: unused import: `Ipv6Addr`
2020-01-29T15:37:03.3901543Z  --> net/ip.rs:821:24
2020-01-29T15:37:03.3901605Z   |
2020-01-29T15:37:03.3901605Z   |
2020-01-29T15:37:03.3901664Z 4 | use std::net::{IpAddr, Ipv6Addr};
2020-01-29T15:37:03.3901772Z   |
2020-01-29T15:37:03.3901817Z note: lint level defined here
2020-01-29T15:37:03.3902013Z  --> net/ip.rs:818:9
2020-01-29T15:37:03.3902058Z   |
---
2020-01-29T15:37:03.4094625Z   local time: Wed Jan 29 15:37:03 UTC 2020
2020-01-29T15:37:03.5767516Z   network time: Wed, 29 Jan 2020 15:37:03 GMT
2020-01-29T15:37:03.5771112Z == end clock drift check ==
2020-01-29T15:37:04.0315993Z 
2020-01-29T15:37:04.0390803Z ##[error]Bash exited with code '1'.
2020-01-29T15:37:04.0403425Z ##[section]Finishing: Run build
2020-01-29T15:37:04.0439772Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68640/merge to s
2020-01-29T15:37:04.0441984Z Task         : Get sources
2020-01-29T15:37:04.0442036Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-29T15:37:04.0442087Z Version      : 1.0.0
2020-01-29T15:37:04.0442132Z Author       : Microsoft
2020-01-29T15:37:04.0442132Z Author       : Microsoft
2020-01-29T15:37:04.0442197Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-29T15:37:04.0442254Z ==============================================================================
2020-01-29T15:37:04.4477044Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-29T15:37:04.4519732Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68640/merge to s
2020-01-29T15:37:04.4629504Z Cleaning up task key
2020-01-29T15:37:04.4630669Z Start cleaning up orphan processes.
2020-01-29T15:37:04.4754250Z Terminate orphan process: pid (3549) (python)
2020-01-29T15:37:04.4995981Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@LeSeulArtichaut
Copy link
Contributor Author

LeSeulArtichaut commented Jan 29, 2020 •
edited
Loading

@steveklabnik I had made a small mistake in an import, pushed a fix

@steveklabnik
Copy link
Member

It's all good, thank you!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jan 29, 2020

📌 Commit ab5e296 has been approved by steveklabnik

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 30, 2020
@Dylan-DPC
Rollup merge of rust-lang#68640 - LeSeulArtichaut:doc-from-ip, r=stev…
3df1ff2 
…eklabnik

Document remaining undocumented `From` implementations for IPs

Some `From` implementations were missing documentation. I added examples, I tried to be as close to existing examples as possible.

Related to rust-lang#51430 (cc @skade)

r? @steveklabnik
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 30, 2020
Merged
bors added a commit that referenced this pull request Jan 30, 2020
@bors
Auto merge of #68659 - Dylan-DPC:rollup-zo7zi9f, r=Dylan-DPC
3024c4e 
Rollup of 6 pull requests

Successful merges:

 - #66648 (Implement clone_from for BTreeMap and BTreeSet)
 - #68468 (BTreeMap: tag and explain unsafe internal functions or assert preconditions)
 - #68626 (Use termize instead of term_size)
 - #68640 (Document remaining undocumented `From` implementations for IPs)
 - #68651 (Document `From` implementation for NonZero nums)
 - #68655 (Fix revision annotations in borrowck-feature-nll-overrides-migrate)

Failed merges:

r? @ghost
@bors bors merged commit ab5e296 into rust-lang:master Jan 30, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the doc-from-ip branch January 31, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik Awaiting requested review from steveklabnik

Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LeSeulArtichaut @steveklabnik @bors @rust-highfive