Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue error on compile-fail header in UI test #68760

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

Tyg13
Copy link
Contributor

@Tyg13 Tyg13 commented Feb 2, 2020

Fixes #68732

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2020
@Centril
Copy link
Contributor

Centril commented Feb 2, 2020

Can you double check that this passes with --bless --pass check --compare-mode=nll?

@Tyg13
Copy link
Contributor Author

Tyg13 commented Feb 2, 2020

@Centril looks good

test.log

@Centril
Copy link
Contributor

Centril commented Feb 2, 2020

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Feb 2, 2020

📌 Commit e61176a82e73188be3341a78c59656d41998bbae has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2020
@rust-highfive

This comment has been minimized.

@Centril
Copy link
Contributor

Centril commented Feb 2, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Feb 2, 2020

📌 Commit f6c3894 has been approved by Centril

@Tyg13
Copy link
Contributor Author

Tyg13 commented Feb 2, 2020

@bors r=Centril

@bors
Copy link
Contributor

bors commented Feb 2, 2020

@Tyg13: 🔑 Insufficient privileges: Not in reviewers

@bors
Copy link
Contributor

bors commented Feb 2, 2020

⌛ Testing commit f6c3894 with merge be4608fef0952ea2cb7d06e9dfcd56c0ac3b8466...

Centril added a commit to Centril/rust that referenced this pull request Feb 2, 2020
Issue error on `compile-fail` header in UI test

Fixes rust-lang#68732

r? @Centril
@Centril
Copy link
Contributor

Centril commented Feb 2, 2020

@bors retry

Centril added a commit to Centril/rust that referenced this pull request Feb 2, 2020
Issue error on `compile-fail` header in UI test

Fixes rust-lang#68732

r? @Centril
bors added a commit that referenced this pull request Feb 2, 2020
Rollup of 5 pull requests

Successful merges:

 - #68733 (Update option.rs)
 - #68760 (Issue error on `compile-fail` header in UI test)
 - #68763 (Do not suggest duplicate bounds)
 - #68764 (parser: syntactically allow `self` in all `fn` contexts)
 - #68769 (parser: avoid re-wrapping NtItem)

Failed merges:

r? @ghost
@bors bors merged commit f6c3894 into rust-lang:master Feb 2, 2020
@Tyg13 Tyg13 deleted the compile_fail_ui_test branch February 2, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compiletest: issue error on compile-fail in UI tests
4 participants