Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: syntactically allow `self` in all `fn` contexts #68764

Merged
merged 2 commits into from Feb 2, 2020

Conversation

@Centril
Copy link
Member

Centril commented Feb 2, 2020

Part of #68728.

self parameters are now syntactically allowed as the first parameter irrespective of item context (and in function pointers). Instead, semantic validation (ast_validation) is used.

r? @petrochenkov

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Feb 2, 2020

r=me with the wording tweak.

@Centril Centril force-pushed the Centril:self-semantic branch from c0b371a to 71a6f58 Feb 2, 2020
@Centril

This comment has been minimized.

Copy link
Member Author

Centril commented Feb 2, 2020

@bors r=petrochenkov

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 2, 2020

📌 Commit 71a6f58 has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Feb 2, 2020
parser: syntactically allow `self` in all `fn` contexts

Part of rust-lang#68728.

`self` parameters are now *syntactically* allowed as the first parameter irrespective of item context (and in function pointers). Instead, semantic validation (`ast_validation`) is used.

r? @petrochenkov
bors added a commit that referenced this pull request Feb 2, 2020
Rollup of 4 pull requests

Successful merges:

 - #68733 (Update option.rs)
 - #68760 (Issue error on `compile-fail` header in UI test)
 - #68763 (Do not suggest duplicate bounds)
 - #68764 (parser: syntactically allow `self` in all `fn` contexts)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Feb 2, 2020
parser: syntactically allow `self` in all `fn` contexts

Part of rust-lang#68728.

`self` parameters are now *syntactically* allowed as the first parameter irrespective of item context (and in function pointers). Instead, semantic validation (`ast_validation`) is used.

r? @petrochenkov
bors added a commit that referenced this pull request Feb 2, 2020
Rollup of 5 pull requests

Successful merges:

 - #68733 (Update option.rs)
 - #68760 (Issue error on `compile-fail` header in UI test)
 - #68763 (Do not suggest duplicate bounds)
 - #68764 (parser: syntactically allow `self` in all `fn` contexts)
 - #68769 (parser: avoid re-wrapping NtItem)

Failed merges:

r? @ghost
@bors bors merged commit 71a6f58 into rust-lang:master Feb 2, 2020
4 checks passed
4 checks passed
pr Build #20200202.29 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@Centril Centril deleted the Centril:self-semantic branch Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.