error code examples: replace some more ignore with compile_fail #68888

tspiteri · 2020-02-06T12:32:44Z

Now that #68664 has been merged and compile_fail attempts a full build rather than --emit=metadata, these errors should be caught by compile_fail and do not need to be ignored.

rust-highfive · 2020-02-06T12:32:49Z

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2020-02-06T14:07:57Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-06T12:33:21.4054890Z ========================== Starting Command Output ===========================
2020-02-06T12:33:21.4070738Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/44a1c245-c2cc-461c-b0a9-b0f12d6e64af.sh
2020-02-06T12:33:21.4240344Z 
2020-02-06T12:33:21.4298095Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-06T12:33:21.4303892Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68888/merge to s
2020-02-06T12:33:21.4305594Z Task         : Get sources
2020-02-06T12:33:21.4305630Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-06T12:33:21.4305709Z Version      : 1.0.0
2020-02-06T12:33:21.4305743Z Author       : Microsoft
---
2020-02-06T12:33:22.8715932Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-06T12:33:22.8788547Z ##[command]git config gc.auto 0
2020-02-06T12:33:22.8846979Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-06T12:33:22.8902584Z ##[command]git config --get-all http.proxy
2020-02-06T12:33:22.9036583Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68888/merge:refs/remotes/pull/68888/merge
---
2020-02-06T13:23:57.6639269Z .................................................................................................... 1700/9589
2020-02-06T13:24:01.8103092Z .................................................................................................... 1800/9589
2020-02-06T13:24:12.3294239Z .............................i...................................................................... 1900/9589
2020-02-06T13:24:18.5406656Z .................................................................................................... 2000/9589
2020-02-06T13:24:30.4946680Z ...................iiiii............................................................................ 2100/9589
2020-02-06T13:24:38.7939557Z .................................................................................................... 2300/9589
2020-02-06T13:24:40.8467139Z .................................................................................................... 2400/9589
2020-02-06T13:24:44.9557361Z .................................................................................................... 2500/9589
2020-02-06T13:25:02.5871915Z .................................................................................................... 2600/9589
---
2020-02-06T13:27:16.5246820Z ..............................................................i...............i..................... 4900/9589
2020-02-06T13:27:23.1209173Z .................................................................................................... 5000/9589
2020-02-06T13:27:29.8905934Z .................................................................................................... 5100/9589
2020-02-06T13:27:33.7722644Z .....i.............................................................................................. 5200/9589
2020-02-06T13:27:43.1455814Z ...............................................................................ii.ii........i...i... 5300/9589
2020-02-06T13:27:50.3946922Z .................i.................................................................................. 5500/9589
2020-02-06T13:27:58.1159247Z .................................................................................................... 5600/9589
2020-02-06T13:28:03.8788746Z ..................................................................i................................. 5700/9589
2020-02-06T13:28:10.0429632Z .................................................................................................... 5800/9589
2020-02-06T13:28:10.0429632Z .................................................................................................... 5800/9589
2020-02-06T13:28:16.1143065Z .................................................................................................... 5900/9589
2020-02-06T13:28:24.4583166Z .........................................................ii...i..ii............i.................... 6000/9589
2020-02-06T13:28:43.3111089Z .................................................................................................... 6200/9589
2020-02-06T13:28:46.9173887Z .................................................................................................... 6300/9589
2020-02-06T13:28:46.9173887Z .................................................................................................... 6300/9589
2020-02-06T13:28:50.4723494Z .....................................................................................i..ii.......... 6400/9589
2020-02-06T13:29:10.1744888Z .................................................................................................... 6600/9589
2020-02-06T13:29:18.0392200Z .......................................................................i............................ 6700/9589
2020-02-06T13:29:19.8949303Z .................................................................................................... 6800/9589
2020-02-06T13:29:21.8499541Z ..........................................................................i......................... 6900/9589
---
2020-02-06T13:30:45.5838606Z .................................................................................................... 7600/9589
2020-02-06T13:30:49.5930735Z .................................................................................................... 7700/9589
2020-02-06T13:30:55.3918708Z .................................................................................................... 7800/9589
2020-02-06T13:31:02.6406021Z .................................................................................................... 7900/9589
2020-02-06T13:31:08.9401101Z ....................................iiiiiii.i....................................................... 8000/9589
2020-02-06T13:31:21.3553086Z .................................................................................................... 8200/9589
2020-02-06T13:31:28.2675981Z .................................................................................................... 8300/9589
2020-02-06T13:31:40.1281544Z .................................................................................................... 8400/9589
2020-02-06T13:31:46.3300812Z .................................................................................................... 8500/9589
---
2020-02-06T13:33:46.5824168Z  finished in 6.423
2020-02-06T13:33:46.5968493Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T13:33:46.7754120Z 
2020-02-06T13:33:46.7755374Z running 172 tests
2020-02-06T13:33:49.3667959Z iiii......i...........ii..iiii...i....i...........i............i..i..................i....i......... 100/172
2020-02-06T13:33:51.3117344Z ...i.i.i...iii..iiiiiiiiii.......................iii............ii......
2020-02-06T13:33:51.3118081Z 
2020-02-06T13:33:51.3122226Z  finished in 4.715
2020-02-06T13:33:51.3291410Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T13:33:51.4677312Z 
---
2020-02-06T13:33:53.1991839Z  finished in 1.870
2020-02-06T13:33:53.2167585Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T13:33:53.3588535Z 
2020-02-06T13:33:53.3590288Z running 9 tests
2020-02-06T13:33:53.3591657Z iiiiiiiii
2020-02-06T13:33:53.3592171Z 
2020-02-06T13:33:53.3594171Z  finished in 0.142
2020-02-06T13:33:53.3778217Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T13:33:53.5210324Z 
---
2020-02-06T13:34:10.4303837Z  finished in 17.052
2020-02-06T13:34:10.4500393Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T13:34:10.5820603Z 
2020-02-06T13:34:10.5820916Z running 116 tests
2020-02-06T13:34:22.4129126Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-02-06T13:34:24.0596701Z ....iiii.....ii.
2020-02-06T13:34:24.0599452Z 
2020-02-06T13:34:24.0603477Z  finished in 13.610
2020-02-06T13:34:24.0608311Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T13:34:24.0608832Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-02-06T13:45:21.8619278Z 
2020-02-06T13:45:21.8624231Z    Doc-tests core
2020-02-06T13:45:25.8548511Z 
2020-02-06T13:45:25.8579196Z running 2471 tests
2020-02-06T13:45:33.4595630Z ......iiiii......................................................................................... 100/2471
2020-02-06T13:45:40.9352597Z ..................................................................................ii................ 200/2471
2020-02-06T13:45:58.2328773Z .................i.................................................................................. 400/2471
2020-02-06T13:45:58.2328773Z .................i.................................................................................. 400/2471
2020-02-06T13:46:06.2128351Z ......................................................................i..i..................iiii.... 500/2471
2020-02-06T13:46:20.0003289Z .................................................................................................... 700/2471
2020-02-06T13:46:27.2604429Z .................................................................................................... 800/2471
2020-02-06T13:46:34.3729612Z .................................................................................................... 900/2471
2020-02-06T13:46:41.5965259Z .................................................................................................... 1000/2471
---
2020-02-06T13:49:31.8602736Z .................................................................................................... 500/760
2020-02-06T13:49:31.9006737Z .................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2741:22
2020-02-06T13:49:31.9028588Z ....thread 'thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2778:<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2766:17
2020-02-06T13:49:31.9028771Z 21
2020-02-06T13:49:31.9039029Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2645:13
2020-02-06T13:49:32.2105600Z ...........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1997:22
2020-02-06T13:49:32.2121445Z ....thread '<unnamed>.' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2034:21
2020-02-06T13:49:32.2143717Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1916:13
2020-02-06T13:49:34.2716729Z ....................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:633:13
2020-02-06T13:49:34.2717280Z .thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:587:13
2020-02-06T13:49:34.2728239Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:563:13
2020-02-06T13:49:34.2730852Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:694:13
---
2020-02-06T13:49:43.1287449Z 
2020-02-06T13:49:43.1289160Z running 1009 tests
2020-02-06T13:49:58.0789233Z i................................................................................................... 100/1009
2020-02-06T13:50:06.4239283Z .................................................................................................... 200/1009
2020-02-06T13:50:12.3677929Z ..................iii......i......i...i......i...................................................... 300/1009
2020-02-06T13:50:16.5461397Z .................................................................................................... 400/1009
2020-02-06T13:50:22.7632414Z ............................................i..i.....................................ii............. 500/1009
2020-02-06T13:50:33.0533062Z .................................................................................................... 700/1009
2020-02-06T13:50:33.0533062Z .................................................................................................... 700/1009
2020-02-06T13:50:38.6363827Z ...................................iiii............................................................. 800/1009
2020-02-06T13:50:50.3755299Z .................................................................................................... 900/1009
2020-02-06T13:50:55.9416356Z .........................................................iiii....................................... 1000/1009
2020-02-06T13:50:56.2812755Z test result: ok. 989 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-02-06T13:50:56.2812837Z 
2020-02-06T13:50:56.2917258Z  finished in 141.236
2020-02-06T13:50:56.2929775Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-02-06T14:07:50.4242973Z ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0565 (line 10329) stdout ----
2020-02-06T14:07:50.4243026Z error[E0535]: invalid argument
2020-02-06T14:07:50.4243266Z  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:10330:10
2020-02-06T14:07:50.4243314Z   |
2020-02-06T14:07:50.4243375Z 3 | #[inline("always")] // error: unsupported literal
2020-02-06T14:07:50.4243455Z 
2020-02-06T14:07:50.4243514Z error: aborting due to previous error
2020-02-06T14:07:50.4243543Z 
2020-02-06T14:07:50.4243767Z For more information about this error, try `rustc --explain E0535`.
2020-02-06T14:07:50.4243767Z For more information about this error, try `rustc --explain E0535`.
2020-02-06T14:07:50.4243818Z Some expected error codes were not found: ["E0565"]
2020-02-06T14:07:50.4244344Z Test compiled successfully, but it's marked `compile_fail`.
2020-02-06T14:07:50.4244635Z ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0633 (line 12080) stdout ----
2020-02-06T14:07:50.4244706Z error[E0658]: the `#[unwind]` attribute is an experimental feature
2020-02-06T14:07:50.4244948Z  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:12081:1
2020-02-06T14:07:50.4244948Z  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:12081:1
2020-02-06T14:07:50.4244995Z   |
2020-02-06T14:07:50.4245055Z 2 | #[unwind()] // error: expected one argument
2020-02-06T14:07:50.4245150Z   | ^^^^^^^^^^^
2020-02-06T14:07:50.4245191Z   |
2020-02-06T14:07:50.4245584Z   = note: for more information, see ***/issues/58760
2020-02-06T14:07:50.4245639Z   = help: add `#![feature(unwind_attributes)]` to the crate attributes to enable
2020-02-06T14:07:50.4245729Z error: aborting due to previous error
2020-02-06T14:07:50.4245758Z 
2020-02-06T14:07:50.4245985Z For more information about this error, try `rustc --explain E0658`.
2020-02-06T14:07:50.4245985Z For more information about this error, try `rustc --explain E0658`.
2020-02-06T14:07:50.4246088Z Some expected error codes were not found: ["E0633"]
2020-02-06T14:07:50.4246173Z failures:
2020-02-06T14:07:50.4246459Z     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0565 (line 10329)
2020-02-06T14:07:50.4246758Z     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0583 (line 10872)
2020-02-06T14:07:50.4247046Z     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0633 (line 12080)
---
2020-02-06T14:07:50.4252024Z   local time: Thu Feb  6 14:07:50 UTC 2020
2020-02-06T14:07:50.7012750Z   network time: Thu, 06 Feb 2020 14:07:50 GMT
2020-02-06T14:07:50.7017615Z == end clock drift check ==
2020-02-06T14:07:51.0653607Z 
2020-02-06T14:07:51.0741662Z ##[error]Bash exited with code '1'.
2020-02-06T14:07:51.0752814Z ##[section]Finishing: Run build
2020-02-06T14:07:51.0776612Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68888/merge to s
2020-02-06T14:07:51.0778663Z Task         : Get sources
2020-02-06T14:07:51.0792216Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-06T14:07:51.0792267Z Version      : 1.0.0
2020-02-06T14:07:51.0792308Z Author       : Microsoft
2020-02-06T14:07:51.0792308Z Author       : Microsoft
2020-02-06T14:07:51.0792372Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-06T14:07:51.0792442Z ==============================================================================
2020-02-06T14:07:51.4905969Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-06T14:07:51.4948595Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68888/merge to s
2020-02-06T14:07:51.5048902Z Cleaning up task key
2020-02-06T14:07:51.5049575Z Start cleaning up orphan processes.
2020-02-06T14:07:51.5137287Z Terminate orphan process: pid (3921) (python)
2020-02-06T14:07:51.5403542Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Now that compile_fail attempts a full build rather than --emit=metadata, these errors should be caught by compile_fail and do not need to be ignored.

petrochenkov · 2020-02-06T20:23:40Z

@bors r+

bors · 2020-02-06T20:23:42Z

📌 Commit 534c3ea has been approved by petrochenkov

…petrochenkov error code examples: replace some more ignore with compile_fail Now that rust-lang#68664 has been merged and `compile_fail` attempts a full build rather than `--emit=metadata`, these errors should be caught by `compile_fail` and do not need to be ignored.

@ghost

Rollup of 6 pull requests Successful merges: - #67359 (Rename -Zexternal-macro-backtrace to -Zmacro-backtrace and clean up implementation.) - #68524 (Generator Resume Arguments) - #68791 (implement proper linkchecker hardening) - #68886 (Mark fn map_or() as eagerly evaluated.) - #68888 (error code examples: replace some more ignore with compile_fail) - #68894 (Update E0565 examples) Failed merges: r? @ghost

rust-highfive assigned petrochenkov Feb 6, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2020

error code examples: replace some more ignore with compile_fail

534c3ea

Now that compile_fail attempts a full build rather than --emit=metadata, these errors should be caught by compile_fail and do not need to be ignored.

tspiteri force-pushed the ignore-to-compile_fail branch from 5a546b0 to 534c3ea Compare February 6, 2020 14:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2020

Dylan-DPC-zz mentioned this pull request Feb 6, 2020

Rollup of 6 pull requests #68907

Merged

bors merged commit 534c3ea into rust-lang:master Feb 7, 2020

tspiteri deleted the ignore-to-compile_fail branch February 7, 2020 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

error code examples: replace some more ignore with compile_fail #68888

error code examples: replace some more ignore with compile_fail #68888

tspiteri commented Feb 6, 2020

rust-highfive commented Feb 6, 2020

rust-highfive commented Feb 6, 2020

petrochenkov commented Feb 6, 2020

bors commented Feb 6, 2020

error code examples: replace some more ignore with compile_fail #68888

error code examples: replace some more ignore with compile_fail #68888

Conversation

tspiteri commented Feb 6, 2020

rust-highfive commented Feb 6, 2020

rust-highfive commented Feb 6, 2020

petrochenkov commented Feb 6, 2020

bors commented Feb 6, 2020