Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #68956

Closed
wants to merge 24 commits into from

Commits on Feb 4, 2020

  1. Configuration menu
    Copy the full SHA
    e590164 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3963387 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa9bfeb View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Configuration menu
    Copy the full SHA
    c00d8aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db9b578 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Configuration menu
    Copy the full SHA
    b82f6c5 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Don't use the word 'unwrap' to describe core unwrapping functions

    It's tautological, and Rust-specific Jargon.
    
    This changes various Option/Result methods to consistently describe unwrapping
    behavior using the words "return", "contain", "consume".
    
    It also renames the closure argument of `Return::unwrap_or_else` to `default` to
    be consistent with `Option`.
    brson committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    8251e12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73936ab View commit details
    Browse the repository at this point in the history
  3. add regression test

    basil-cow committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    ab6ea2b View commit details
    Browse the repository at this point in the history
  4. add hir printing

    basil-cow committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    bf82582 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2020

  1. Configuration menu
    Copy the full SHA
    0df21b2 View commit details
    Browse the repository at this point in the history
  2. Update tests

    Zoxc committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    1ae614f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66fd4e6 View commit details
    Browse the repository at this point in the history
  4. Use associated_items query in impl overlap check

    This reduces the number of `associated_item` queries done here.
    jonas-schievink committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    f416573 View commit details
    Browse the repository at this point in the history
  5. Add a fast path to inherent impl overlap check

    Quickly skip impls that do not define any items with the same name
    jonas-schievink committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    52f7711 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e0cb1ae View commit details
    Browse the repository at this point in the history
  7. Add missing import

    jonas-schievink committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    58a9284 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#68452 - msizanoen1:riscv-abi, r=nagisa,eddyb

    Implement proper C ABI lowering for RISC-V
    
    This is necessary for full RISC-V psABI compliance when passing argument across C FFI boundary.
    
    cc @lenary
    Dylan-DPC committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    76de8a6 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#68834 - ssomers:btree_first_last_fix68829, …

    …r=KodrAus
    
    Fix and test implementation of BTreeMap's first/last_entry, pop_first/last
    
    Properly implement and test `first_entry` & `last_entry` to fix problem report rust-lang#68829
    Dylan-DPC committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    3833344 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#68881 - eddyb:always-preserve-dbg-vars, r=n…

    …agisa
    
    rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variables
    
    Making this depend on the optimization level appears to have been a copy-paste mistake (other LLVM functions called in this module also take a `bool` argument, but there it means something unrelated).
    Also see rust-lang#8855 (comment).
    
    I don't believe we have any reason to let LLVM omit user variables from DWARF, and we were already setting this to `true` when LLVM *could* optimize them away, so this PR should have no effect anyway.
    
    r? @michaelwoerister or @nagisa cc @rkruppe @nikomatsakis
    Dylan-DPC committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    ff12360 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#68884 - Zoxc:gen-type, r=nikomatsakis

    Make the `type_of` return a generic type for generators
    
    Fixes rust-lang#67651.
    
    r? @nikomatsakis
    Dylan-DPC committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    923f824 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#68911 - jonas-schievink:inherent-overlap, r…

    …=petrochenkov
    
    Speed up the inherent impl overlap check
    
    This gives a ~7% improvement in compile times for the stm32f0(x2) crate.
    
    Also addresses @eddyb's comment in rust-lang#68837 (comment).
    Dylan-DPC committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    7a45eeb View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#68913 - Areredify:gat_pretty, r=cramertj

    Pretty-print generic params and where clauses on associated types
    
    closes rust-lang#67509
    Dylan-DPC committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    bab88ff View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#68918 - brson:unwrapdoc, r=Dylan-DPC

    Don't use the word "unwrap" to describe "unwrap" methods
    
    It's tautological, and "unwrap" is essentially Rust-specific jargon.
    
    I was teaching a newbie some Rust, and doing the usual hand-waving about error handling using unwrap. They asked what 'unwrap' means. I said look it up in the docs. The docs read (paraphrased) "unwrap unwraps". I was embarrassed.
    
    This changes all the Option/Result functions with unwrapping behavior to use a variation on a single description:
    
    > "Returns the contained `Some/Ok` value [or ...]."
    
    It also renames the closure of `Result::unwrap_or_else` to `default` for consistency with `Option`, and perhaps makes a few other small tweaks.
    
    Previous: rust-lang#68849
    Dylan-DPC committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    57212d8 View commit details
    Browse the repository at this point in the history