Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test implementation of BTreeMap's first/last_entry, pop_first/last #68834

Merged
merged 1 commit into from Feb 9, 2020

Conversation

@ssomers
Copy link
Contributor

ssomers commented Feb 4, 2020

Properly implement and test first_entry & last_entry to fix problem report #68829

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 4, 2020

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@KodrAus

This comment has been minimized.

Copy link
Contributor

KodrAus commented Feb 7, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 7, 2020

📌 Commit fa9bfeb has been approved by KodrAus

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 8, 2020
…r=KodrAus

Fix and test implementation of BTreeMap's first/last_entry, pop_first/last

Properly implement and test `first_entry` & `last_entry` to fix problem report rust-lang#68829
bors added a commit that referenced this pull request Feb 8, 2020
Rollup of 7 pull requests

Successful merges:

 - #68358 (Remove some unsound specializations)
 - #68802 (rustc_codegen_ssa: don't treat inlined variables as debuginfo arguments.)
 - #68834 (Fix and test implementation of BTreeMap's first/last_entry, pop_first/last)
 - #68881 (rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variables)
 - #68913 (Pretty-print generic params and where clauses on associated types)
 - #68918 (Don't use the word "unwrap" to describe "unwrap" methods)
 - #68929 (Make issue references consistent)

Failed merges:

r? @ghost
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 8, 2020
…r=KodrAus

Fix and test implementation of BTreeMap's first/last_entry, pop_first/last

Properly implement and test `first_entry` & `last_entry` to fix problem report rust-lang#68829
bors added a commit that referenced this pull request Feb 8, 2020
Rollup of 7 pull requests

Successful merges:

 - #68452 (Implement proper C ABI lowering for RISC-V)
 - #68834 (Fix and test implementation of BTreeMap's first/last_entry, pop_first/last)
 - #68881 (rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variables)
 - #68884 (Make the `type_of` return a generic type for generators)
 - #68911 (Speed up the inherent impl overlap check)
 - #68913 (Pretty-print generic params and where clauses on associated types)
 - #68918 (Don't use the word "unwrap" to describe "unwrap" methods)

Failed merges:

r? @ghost
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 8, 2020
…r=KodrAus

Fix and test implementation of BTreeMap's first/last_entry, pop_first/last

Properly implement and test `first_entry` & `last_entry` to fix problem report rust-lang#68829
bors added a commit that referenced this pull request Feb 9, 2020
Rollup of 7 pull requests

Successful merges:

 - #68718 (Move `rustc_hir::def_id` to `rustc_span::def_id`)
 - #68834 (Fix and test implementation of BTreeMap's first/last_entry, pop_first/last)
 - #68857 (perf: Reduce Vec allocations in normalization by passing &mut Vec)
 - #68918 (Don't use the word "unwrap" to describe "unwrap" methods)
 - #68946 (Mark several functions and methods in core::cmp as #[must_use])
 - #68958 (Clean up E0277 and E0282 explanations)
 - #68960 (codegen: misc cleanups around debuginfo scopes and locations.)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Feb 9, 2020
Rollup of 7 pull requests

Successful merges:

 - #68718 (Move `rustc_hir::def_id` to `rustc_span::def_id`)
 - #68834 (Fix and test implementation of BTreeMap's first/last_entry, pop_first/last)
 - #68857 (perf: Reduce Vec allocations in normalization by passing &mut Vec)
 - #68918 (Don't use the word "unwrap" to describe "unwrap" methods)
 - #68946 (Mark several functions and methods in core::cmp as #[must_use])
 - #68958 (Clean up E0277 and E0282 explanations)
 - #68960 (codegen: misc cleanups around debuginfo scopes and locations.)

Failed merges:

r? @ghost
@bors bors merged commit fa9bfeb into rust-lang:master Feb 9, 2020
4 checks passed
4 checks passed
pr Build #20200204.49 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@ssomers ssomers deleted the ssomers:btree_first_last_fix68829 branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.