Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant clones, references to operands, explicit boolean comparisons and filter(x).next() calls. #69547

Merged
merged 1 commit into from
Feb 28, 2020
Merged

remove redundant clones, references to operands, explicit boolean comparisons and filter(x).next() calls. #69547

merged 1 commit into from
Feb 28, 2020

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@Mark-Simulacrum
Copy link
Member

r? @Mark-Simulacrum

@bors r+ rollup

The if let Some(_) = slice.iter().find(...) pattern seems quite verbose, it would perhaps be nice to take at least some of the longer cases and break them out to avoid the really long multi-line conditionals... but creating a temporary variable seems unfortunate too.

@bors
Copy link
Contributor

bors commented Feb 28, 2020

📌 Commit ff9341a has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 28, 2020
@Centril Centril mentioned this pull request Feb 28, 2020
Merged
bors added a commit that referenced this pull request Feb 28, 2020
@bors
Auto merge of #69555 - Centril:rollup-e53lxz4, r=Centril
0eb878d 
Rollup of 10 pull requests

Successful merges:

 - #68989 (Update RELEASES.md for 1.42.0)
 - #69340 (instantiate_value_path: on `SelfCtor`, avoid unconstrained tyvars)
 - #69384 (parser: `token` -> `normalized_token`, `nonnormalized_token` -> `token`)
 - #69452 (typeck: use `Pattern` obligation cause more for better diagnostics)
 - #69481 (use char instead of &str for single char patterns)
 - #69522 (error_derive_forbidden_on_non_adt: be more graceful)
 - #69538 (Stabilize `boxed_slice_try_from`)
 - #69539 (late resolve, visit_fn: bail early if there's no body.)
 - #69541 (Remove unneeded calls to format!())
 - #69547 (remove redundant clones, references to operands, explicit boolean comparisons and filter(x).next() calls.)

Failed merges:

r? @ghost
@bors bors merged commit 13e4c6c into rust-lang:master Feb 28, 2020
@matthiaskrgr matthiaskrgr deleted the more_misc branch February 29, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthiaskrgr @Mark-Simulacrum @bors @estebank