Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize `boxed_slice_try_from` #69538

Merged
merged 1 commit into from Feb 28, 2020
Merged

Conversation

@JohnTitor
Copy link
Member

JohnTitor commented Feb 28, 2020

Closes #69202

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 28, 2020

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-28T04:36:59.1231483Z ========================== Starting Command Output ===========================
2020-02-28T04:36:59.1234394Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/dfd0400f-8155-4197-9010-b02c204fb2ad.sh
2020-02-28T04:36:59.1234663Z 
2020-02-28T04:36:59.1239897Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-28T04:36:59.1259330Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69538/merge to s
2020-02-28T04:36:59.1262907Z Task         : Get sources
2020-02-28T04:36:59.1263206Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-28T04:36:59.1263490Z Version      : 1.0.0
2020-02-28T04:36:59.1263684Z Author       : Microsoft
---
2020-02-28T04:37:00.3020847Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-28T04:37:00.3037024Z ##[command]git config gc.auto 0
2020-02-28T04:37:00.3041805Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-28T04:37:00.3045160Z ##[command]git config --get-all http.proxy
2020-02-28T04:37:00.3052413Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69538/merge:refs/remotes/pull/69538/merge
---
2020-02-28T04:40:26.2415990Z E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
2020-02-28T04:40:26.2457491Z 
2020-02-28T04:40:26.2531910Z ##[error]Bash exited with code '100'.
2020-02-28T04:40:26.2545776Z ##[section]Finishing: Install awscli
2020-02-28T04:40:26.2609573Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69538/merge to s
2020-02-28T04:40:26.2614626Z Task         : Get sources
2020-02-28T04:40:26.2614978Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-28T04:40:26.2615320Z Version      : 1.0.0
2020-02-28T04:40:26.2615544Z Author       : Microsoft
2020-02-28T04:40:26.2615544Z Author       : Microsoft
2020-02-28T04:40:26.2615903Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-28T04:40:26.2616335Z ==============================================================================
2020-02-28T04:40:26.6000575Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-28T04:40:26.6044664Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69538/merge to s
2020-02-28T04:40:26.6139380Z Cleaning up task key
2020-02-28T04:40:26.6141186Z Start cleaning up orphan processes.
2020-02-28T04:40:26.6342542Z Terminate orphan process: pid (4339) (python)
2020-02-28T04:40:26.6594820Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril added the relnotes label Feb 28, 2020
@Centril Centril added this to the 1.43 milestone Feb 28, 2020
@Centril Centril added the T-libs label Feb 28, 2020
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Feb 28, 2020

r? @Centril @bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 28, 2020

📌 Commit 4e0bea3 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned dtolnay Feb 28, 2020
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 28, 2020
…entril

Stabilize `boxed_slice_try_from`

Closes rust-lang#69202
bors added a commit that referenced this pull request Feb 28, 2020
Rollup of 7 pull requests

Successful merges:

 - #68989 (Update RELEASES.md for 1.42.0)
 - #69148 (Account for bounds and asociated items when denying `_`)
 - #69255 (Add more context to E0599 errors)
 - #69263 (Blacklist powerpc-unknown-linux-{gnu,musl} as having non-ignored GNU C ZSTs.)
 - #69408 (Miri: let machine canonicalize AllocIDs)
 - #69538 (Stabilize `boxed_slice_try_from`)
 - #69539 (late resolve, visit_fn: bail early if there's no body.)

Failed merges:

 - #69260 (Create E0747 error code for unterminated raw strings)

r? @ghost
@lzutao

This comment has been minimized.

Copy link
Contributor

lzutao commented Feb 28, 2020

Is there any FCP completed?

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Feb 28, 2020

These are already stable so FCP is a moot point I believe.

bors added a commit that referenced this pull request Feb 28, 2020
Rollup of 10 pull requests

Successful merges:

 - #68989 (Update RELEASES.md for 1.42.0)
 - #69340 (instantiate_value_path: on `SelfCtor`, avoid unconstrained tyvars)
 - #69384 (parser: `token` -> `normalized_token`, `nonnormalized_token` -> `token`)
 - #69452 (typeck: use `Pattern` obligation cause more for better diagnostics)
 - #69481 (use char instead of &str for single char patterns)
 - #69522 (error_derive_forbidden_on_non_adt: be more graceful)
 - #69538 (Stabilize `boxed_slice_try_from`)
 - #69539 (late resolve, visit_fn: bail early if there's no body.)
 - #69541 (Remove unneeded calls to format!())
 - #69547 (remove redundant clones, references to operands, explicit boolean comparisons and filter(x).next() calls.)

Failed merges:

r? @ghost
@bors bors merged commit e4cedc9 into rust-lang:master Feb 28, 2020
2 of 4 checks passed
2 of 4 checks passed
pr Build #20200228.8 failed
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 failed
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@JohnTitor JohnTitor deleted the JohnTitor:boxed-slice-try-from branch Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants
You can’t perform that action at this time.