Use pprust to print attributes in rustdoc
#69686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
added
the
S-waiting-on-review
JohnCSimon
added
S-waiting-on-author
varkor
added
S-waiting-on-review
|
Thanks! Please also open an issue to fix the spacing problem. Also please rebase. :) Once done, r=me. |
varkor
force-pushed
the
rustdoc-attributes
branch
from
6577e9a
to
c599ec4
Compare
|
@bors r=GuillaumeGomez rollup |
|
📌 Commit c599ec4 has been approved by |
bors
added
S-waiting-on-bors
|
Opened #70027 to track the spacing issue. |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 15, 2020
…umeGomez Use `pprust` to print attributes in rustdoc Fixes rust-lang#69559. I'm not sure what the original motivation was for the `render_attribute`, so I may be missing something, but replacing it with `pprust::attribute_to_string` seems to give the intended output (modulo some spacing idiosyncrasies). r? @GuillaumeGomez
bors
added a commit
that referenced
this pull request
Mar 16, 2020
Rollup of 8 pull requests Successful merges: - #69686 (Use `pprust` to print attributes in rustdoc) - #69858 (std: on Windows, use GetSystemTimePreciseAsFileTime if it is available) - #69917 (Cleanup E0412 and E0422) - #69964 (Add Node.js to PR CI image) - #69992 (Block version-specific docs from search engines) - #69995 (Add more context to the literal overflow message) - #69998 (Add long error explanation for E0634) - #70014 (Small fixes in rustdoc book) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69559.
I'm not sure what the original motivation was for the
render_attribute, so I may be missing something, but replacing it withpprust::attribute_to_stringseems to give the intended output (modulo some spacing idiosyncrasies).r? @GuillaumeGomez