Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodules: update clippy from 1ff81c1b to 70b93aab #70485

Merged
merged 1 commit into from
Mar 28, 2020
Merged

submodules: update clippy from 1ff81c1b to 70b93aab #70485

merged 1 commit into from
Mar 28, 2020

Conversation

matthiaskrgr
Copy link
Member

Changes:

remove redundant import
rustup https://github.com/rust-lang/rust/pull/68404
rustup https://github.com/rust-lang/rust/pull/69644
rustup https://github.com/rust-lang/rust/pull/70344
Move verbose_file_reads to restriction
move redundant_pub_crate to nursery
readme: explain how to run only a single lint on a codebase
Remove dependency on `matches` crate
Move useless_transmute to nursery
nursery group -> style
Update for PR feedback
Auto merge of #5314 - ehuss:remove-git2, r=flip1995
Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them

Fixes #70456

@matthiaskrgr
submodules: update clippy from 1ff81c1 to 70b93aa
6e01d0f 
Changes:
````
remove redundant import
rustup rust-lang#68404
rustup rust-lang#69644
rustup rust-lang#70344
Move verbose_file_reads to restriction
move redundant_pub_crate to nursery
readme: explain how to run only a single lint on a codebase
Remove dependency on `matches` crate
Move useless_transmute to nursery
nursery group -> style
Update for PR feedback
Auto merge of rust-lang#5314 - ehuss:remove-git2, r=flip1995
Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them
````

Fixes rust-lang#70456
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2020
@Dylan-DPC-zz
Copy link

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Mar 28, 2020

📌 Commit 6e01d0f has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2020
@bors
Copy link
Contributor

bors commented Mar 28, 2020

⌛ Testing commit 6e01d0f with merge 03ce263ca75c81aec98021f700990c2444fb7de1...

@bors
Copy link
Contributor

bors commented Mar 28, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2020
@matthiaskrgr
Copy link
Member Author 

test vec::test_splice_unbounded ... ok
test vec::test_split_at_mut ... ok
test vec::test_split_off ... ok
test vec::test_stable_push_pop ... ok
test vec::test_swap_remove_empty ... ok
test slice::test_sort ... ok
died due to signal 11
error: test failed, to rerun pass '-p alloc --test collectionstests'


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "alloc" "--"
expected success, got: exit code: 3


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target arm-linux-androideabi
Build completed unsuccessfully in 2:25:06

looks spurious.

@Dylan-DPC-zz
Copy link

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2020
@bors
Copy link
Contributor

bors commented Mar 28, 2020

⌛ Testing commit 6e01d0f with merge e768d6f...

@bors
Copy link
Contributor

bors commented Mar 28, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing e768d6f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 28, 2020
@bors bors merged commit e768d6f into rust-lang:master Mar 28, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #70485!

Tested on commit e768d6f.
Direct link to PR: #70485

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Mar 28, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#70485!
e353723 
Tested on commit rust-lang/rust@e768d6f.
Direct link to PR: <rust-lang/rust#70485>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
@matthiaskrgr matthiaskrgr deleted the submodule_upd branch March 28, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#70451
5 participants
@matthiaskrgr @rust-highfive @Dylan-DPC-zz @bors @nikomatsakis