Remove framework in dataflow/mod.rs in favor of "generic" one
#69644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @pnkfelix |
|
☔ The latest upstream changes (presumably #69746) made this pull request unmergeable. Please resolve the merge conflicts. |
ecstatic-morse
force-pushed
the
unified-dataflow-cleanup
branch
from
370e52c
to
29dc6d0
Compare
|
Ping @pnkfelix. I'll hold off on rebasing this again until it is reviewed since it is prone to merge conflicts. |
|
☔ The latest upstream changes (presumably #70040) made this pull request unmergeable. Please resolve the merge conflicts. |
|
ping @pnkfelix This is just removing dead code and renaming some modules. Can you reassign if you're not going to get to this? |
ecstatic-morse
force-pushed
the
unified-dataflow-cleanup
branch
from
29dc6d0
to
89d6009
Compare
|
Not sure what the hold up is. Can someone from @rust-lang/compiler review this? |
|
r? @eddyb (feel free to ask me in PMs for reviews) |
eddyb
approved these changes
Mar 26, 2020
|
@bors r+ |
|
📌 Commit 89d6009 has been approved by |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#69644 (Remove framework in `dataflow/mod.rs` in favor of "generic" one) - rust-lang#69936 (Fix cycle error when emitting suggestion for mismatched `fn` type) - rust-lang#70048 (Allow obtaining &mut OsStr) - rust-lang#70344 (Decouple `rustc_hir::print` into `rustc_hir_pretty`) - rust-lang#70435 (Add regression test for rust-lang#66706) Failed merges: r? @ghost
matthiaskrgr
added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Mar 27, 2020
matthiaskrgr
added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Mar 27, 2020
matthiaskrgr
added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Mar 27, 2020
matthiaskrgr
added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Mar 27, 2020
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 27, 2020
Changes: ```` remove redundant import rustup rust-lang#68404 rustup rust-lang#69644 rustup rust-lang#70344 Move verbose_file_reads to restriction move redundant_pub_crate to nursery readme: explain how to run only a single lint on a codebase Remove dependency on `matches` crate Move useless_transmute to nursery nursery group -> style Update for PR feedback Auto merge of rust-lang#5314 - ehuss:remove-git2, r=flip1995 Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them ```` Fixes rust-lang#70456
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2020
submodules: update clippy from 1ff81c1 to 70b93aa Changes: ```` remove redundant import rustup rust-lang#68404 rustup rust-lang#69644 rustup rust-lang#70344 Move verbose_file_reads to restriction move redundant_pub_crate to nursery readme: explain how to run only a single lint on a codebase Remove dependency on `matches` crate Move useless_transmute to nursery nursery group -> style Update for PR feedback Auto merge of rust-lang#5314 - ehuss:remove-git2, r=flip1995 Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them ```` Fixes rust-lang#70456
ecstatic-morse
added a commit
to ecstatic-morse/rust
that referenced
this pull request
Apr 2, 2020
This was used by the old framework that was removed in rust-lang#69644.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 3, 2020
…eanup, r=nikomatsakis Remove unused graphviz emitter This was only used by the old dataflow framework that was removed in rust-lang#69644.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 3, 2020
…eanup, r=nikomatsakis Remove unused graphviz emitter This was only used by the old dataflow framework that was removed in rust-lang#69644.
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Changes: ```` remove redundant import rustup rust-lang/rust#68404 rustup rust-lang/rust#69644 rustup rust-lang/rust#70344 Move verbose_file_reads to restriction move redundant_pub_crate to nursery readme: explain how to run only a single lint on a codebase Remove dependency on `matches` crate Move useless_transmute to nursery nursery group -> style Update for PR feedback Auto merge of rust-lang#5314 - ehuss:remove-git2, r=flip1995 Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them ```` Fixes #70456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the culmination of the work described in rust-lang/compiler-team#202. All dataflow analyses (including the one in
clippy) have been ported to use the framework indataflow/generic, which can efficiently handle both gen/kill and generic problems. This PR moves the framework indataflow/generictodataflow/framework, and removes the gen/kill framework indataflow/mod.rs.More comprehensive documentation for the new framework is tracked in rust-lang/rustc-dev-guide#564.
clippywill need to change the path it uses to import the dataflow analysis traits.