Rollup of 4 pull requests #70670
Closed
Rollup of 4 pull requests #70670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic parameter is unused, and so is `map`
…ikomatsakis Track the finalizing node in the specialization graph Fixes rust-lang#70419 Fixes rust-lang#70442 r? @eddyb
…-obk rustc_target::abi: rename FieldPlacement to FieldsShape. Originally suggested by @eddyb.
…an-DPC clean up E0468 explanation r? @Dylan-DPC
…k-Simulacrum compiletest: don't use `std::io::stdout()`, as it bypasses `set_print`. This PR undoes a change made during rust-lang#69916, which became unnecessary during review but was left in by accident, and which isn't correct due to `libtest` using `std::io::set_print`, which overwrites the `println!` behavior but *not* `writeln!(std::io::stdout(), ...)`. The effect of using `writeln!(std::io::stdout(), ...)` was that the diff output would show *while* running the tests, instead of at the end, when failing tests are listed. r? @Mark-Simulacrum cc @oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
std::io::stdout(), as it bypassesset_print. #70662 (compiletest: don't usestd::io::stdout(), as it bypassesset_print.)Failed merges:
STILL_FURTHER_SPECIALIZABLEflag #70658 (addSTILL_FURTHER_SPECIALIZABLEflag)r? @ghost