Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_target::abi: rename FieldPlacement to FieldsShape. #70616

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

anyska
Copy link
Contributor

@anyska anyska commented Mar 31, 2020

Originally suggested by @eddyb.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2020
@eddyb
Copy link
Member

eddyb commented Mar 31, 2020

r? @oli-obk cc @RalfJung

@RalfJung
Copy link
Member

RalfJung commented Mar 31, 2020

I was never bothered by FieldPlacement. Why is FieldsShape better? It is shorter, granted, but the sS is slightly awkward to read and type.

But it's also not worse, so whatever.^^ No strong opinion here.

@oli-obk
Copy link
Contributor

oli-obk commented Apr 1, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 1, 2020

📌 Commit f259470 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Apr 1, 2020

🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 1, 2020
…-obk

rustc_target::abi: rename FieldPlacement to FieldsShape.

Originally suggested by @eddyb.
Centril added a commit to Centril/rust that referenced this pull request Apr 1, 2020
…-obk

rustc_target::abi: rename FieldPlacement to FieldsShape.

Originally suggested by @eddyb.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 1, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#70535 (Track the finalizing node in the specialization graph)
 - rust-lang#70590 (Miri: make backtrace function names and spans match up)
 - rust-lang#70616 (rustc_target::abi: rename FieldPlacement to FieldsShape.)
 - rust-lang#70626 (cargotest: remove webrender)
 - rust-lang#70649 (clean up E0468 explanation)
 - rust-lang#70662 (compiletest: don't use `std::io::stdout()`, as it bypasses `set_print`.)

Failed merges:

r? @ghost
@bors bors merged commit 1b40067 into rust-lang:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants