Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update miri #71917

Merged
merged 1 commit into from
May 8, 2020
Merged

update miri #71917

merged 1 commit into from
May 8, 2020

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 5, 2020 •
edited
Loading

In particular this includes the change to yield on spin_loop_hint, which is needed for #71737.
r? @ghost Cc @rust-lang/miri

Fixes #71963

@RalfJung
Copy link
Member Author

RalfJung commented May 5, 2020

@bors r+ (no priority, toolstate is green)

@bors
Copy link
Contributor

bors commented May 5, 2020

📌 Commit 99f53c7dca2a67cedac231a5f40a60df41b8040f has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 5, 2020
@RalfJung
Copy link
Member Author

RalfJung commented May 5, 2020

Included another PR.
@bors r+

@bors
Copy link
Contributor

bors commented May 5, 2020

📌 Commit fa5d7221b3490cae4f2f57d70ef2f7b215f164e4 has been approved by RalfJung

@RalfJung
Copy link
Member Author

RalfJung commented May 7, 2020

@bors r-
Miri broke

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 7, 2020
@RalfJung
Copy link
Member Author

RalfJung commented May 7, 2020

Fixes toolstate.
@bors r+ p=1

@bors
Copy link
Contributor

bors commented May 7, 2020

📌 Commit e583a5c has been approved by RalfJung

@bors
Copy link
Contributor

bors commented May 7, 2020

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2020
@RalfJung
Copy link
Member Author

RalfJung commented May 8, 2020

The python issue seems to be fixed I think... let's see
@bors p=1001

@bors
Copy link
Contributor

bors commented May 8, 2020

⌛ Testing commit e583a5c with merge a51e004...

@pietroalbini
Copy link
Member

@bors treeclosed=500

Temporary treeclose, I need to re-enable the gate on GHA after this PR merges.

@bors
Copy link
Contributor

bors commented May 8, 2020

☀️ Test successful - checks-azure
Approved by: RalfJung
Pushing a51e004 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 8, 2020
@RalfJung
Copy link
Member Author

RalfJung commented May 8, 2020

Sorry for that @pietroalbini, I hope letting bors work on this PR won't cause problems!

@bors bors merged commit a51e004 into rust-lang:master May 8, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #71917!

Tested on commit a51e004.
Direct link to PR: #71917

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 8, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#71917!
f6227d7 
Tested on commit rust-lang/rust@a51e004.
Direct link to PR: <rust-lang/rust#71917>

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
@pietroalbini
Copy link
Member

@RalfJung it didn't! Don't worry about it :)

@RalfJung RalfJung deleted the miri branch May 8, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#71958
4 participants
@RalfJung @bors @pietroalbini @rust-highfive