add long error explanation for E0228 #72127
Conversation
|
Some changes occurred in diagnostic error codes |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Reference test outputs need to be updated. |
petrochenkov
added
S-waiting-on-author
|
I updated the tests - will have a fix shortly for remaining failures. |
|
LGTM. |
imogenkinsman
force-pushed
the
long-error-explanation-E0228
branch
from
a5495e8
to
5320bd9
Compare
|
done :) |
|
Thanks! |
|
📌 Commit 5320bd9 has been approved by |
bors
added
S-waiting-on-bors
…E0228, r=petrochenkov add long error explanation for E0228 Add long explanation for the E0228 error code Part of rust-lang#61137 Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.
…E0228, r=petrochenkov add long error explanation for E0228 Add long explanation for the E0228 error code Part of rust-lang#61137 Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.
Rollup of 8 pull requests Successful merges: - rust-lang#71910 (Fix unused_parens false positive when using binary operations) - rust-lang#72087 (Fix hang in lexical_region_resolve) - rust-lang#72126 (Change `WorkProduct::saved_files` to an `Option`.) - rust-lang#72127 (add long error explanation for E0228) - rust-lang#72141 (Warn against thread::sleep in async fn) - rust-lang#72170 (use `require_lang_item` over `unwrap`.) - rust-lang#72191 (Clean up E0589 explanation) - rust-lang#72194 (Don't ICE on missing `Unsize` impl) Failed merges: r? @ghost
Add long explanation for the E0228 error code
Part of #61137
Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.