Rollup of 9 pull requests #72182
Closed
Rollup of 9 pull requests #72182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`prefix` should not be mutable. Change the process from for loop to find, which makes the `prefix` able to be immutable.
…matsakis Fix hang in lexical_region_resolve Regionck was stuck in a loop where a region value was changing between two equal regions. Closes rust-lang#72051
…E0228, r=petrochenkov add long error explanation for E0228 Add long explanation for the E0228 error code Part of rust-lang#61137 Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.
…an-DPC Clean up E0581 explanation r? @Dylan-DPC
…hewjasper Add doc comment for `rustc_middle::mir::mono::Linkage`
Warn against thread::sleep in async fn I've seen `thread::sleep` wrecking havoc in async servers. There's already an [issue for clippy](rust-lang/rust-clippy#4377), but the std docs could warn against it too.
…atsakis Remove UnnormalizedProjection This was only used for the old chalk integration with chalk-engine r? @nikomatsakis
…wjasper docs: remove comment referencing non-existent method
…an-DPC Clean up E0582 explanation r? @Dylan-DPC
|
@bors r+ rollup=never p=9 |
|
📌 Commit c44a762 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit c44a762 with merge 8ab0258cb3022089fc3a23a12ff51a0b5b9dcd9c... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@rust-lang/infra I am unable to see the failure in this run -- the only failing job is "mark the job as failure". Usually then there is another job that also failed that shows the actual error; that does not seem to be the case this time. |
|
The two canceled jobs in this run are:
|
bors
added
S-waiting-on-bors
bors
added
S-waiting-on-author
|
@bors p=0 r- retry |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
prefixshould not be mutable. #71525 (prefixshould not be mutable.)rustc_middle::mir::mono::Linkage#72138 (Add doc comment forrustc_middle::mir::mono::Linkage)Failed merges:
r? @ghost