Rollup of 5 pull requests #72844
Merged
Rollup of 5 pull requests #72844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful feature that people might not automatically associate with `cargo tree`.
If the reader assumes that 'pointer type's include 'smart pointer's, the term 'non-pointer type' could mislead the reader to assume that x should not be a smart pointer type. I tried to rephrase the term 'non-pointer type' to remove ambiguity in the doc comments. closes rust-lang#72335 Thank you for reviewing this PR! :)
…cote fulfill: try using SmallVec or Box for stalled_on Tested both `Box` and `SmallVec` for `stalled_on`, with both resulting in a perf loss. Adds a comment mentioning this and removes an now outdated FIXME. Logging the length of `stalled_on` resulted in the following distribution while building a part of stage 1 libs: ``` 22627647 counts: ( 1) 20983696 (92.7%, 92.7%): process_obligation_len: 1 ( 2) 959711 ( 4.2%, 97.0%): process_obligation_len: 2 ( 3) 682326 ( 3.0%,100.0%): process_obligation_len: 0 ( 4) 1914 ( 0.0%,100.0%): process_obligation_len: 3 ``` cc @eddyb r? @nnethercote
…an-DPC Clean up E0622 explanation r? @Dylan-DPC
…ddyb Add descriptions for all queries This also removes the default description for queries with DefId keys and makes the macro validate that a description is provided. cc rust-lang#72730 r? @eddyb
…imulacrum RELEASES.md: Expand `cargo tree` note to mention `cargo tree -d` Useful feature that people might not automatically associate with `cargo tree`.
…fackler Rephrase term 'non-pointer type' Hello 🐈 , If the reader assumes that 'pointer type's include 'smart pointer's, the term 'non-pointer type' could mislead the reader to assume that x should not be a smart pointer type. I tried to rephrase the term 'non-pointer type' to remove ambiguity in the doc comments. closes rust-lang#72335 Thank you for reviewing this PR! 🦸♀️
|
@bors r+ p=5 rollup=never |
|
📌 Commit 16b4dc0 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors retry |
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
cargo treenote to mentioncargo tree -d#72832 (RELEASES.md: Expandcargo treenote to mentioncargo tree -d)Failed merges:
r? @ghost